mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-23 07:26:30 +00:00
Maurice Böe
942e1932c9
The key was 'parkings', which is not a word and does not match the 'parking' the reservation type uses everywhere else. The shared trip page prints the stored category verbatim, so a share link would have shown "parkings" in every language. The category also had no relationship to the booking type of the same name: RESERVATION_TYPE_TO_COST_CATEGORY still sent a parking booking's auto-expense to Transport, so the new bucket sat empty next to the costs that belong in it while a manually typed "parking" resolved into it. Both paths agree now.
64 lines
2.2 KiB
TypeScript
64 lines
2.2 KiB
TypeScript
import {
|
|
budgetCreateItemRequestSchema,
|
|
budgetUpdateMembersRequestSchema,
|
|
budgetToggleMemberPaidRequestSchema,
|
|
budgetReorderItemsRequestSchema,
|
|
COST_CATEGORIES,
|
|
typeToCostCategory,
|
|
} from './budget.schema';
|
|
|
|
import { describe, it, expect } from 'vitest';
|
|
|
|
describe('budgetCreateItemRequestSchema', () => {
|
|
it('requires a name; money/meta fields optional + nullable', () => {
|
|
expect(budgetCreateItemRequestSchema.safeParse({ name: 'Hotel' }).success).toBe(true);
|
|
expect(
|
|
budgetCreateItemRequestSchema.safeParse({
|
|
name: 'Hotel',
|
|
total_price: 200,
|
|
persons: null,
|
|
}).success,
|
|
).toBe(true);
|
|
expect(budgetCreateItemRequestSchema.safeParse({}).success).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('budgetUpdateMembersRequestSchema', () => {
|
|
it('requires a numeric user_ids array', () => {
|
|
expect(budgetUpdateMembersRequestSchema.safeParse({ user_ids: [1, 2] }).success).toBe(true);
|
|
expect(budgetUpdateMembersRequestSchema.safeParse({ user_ids: 'no' }).success).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('budgetToggleMemberPaidRequestSchema', () => {
|
|
it('requires a boolean paid', () => {
|
|
expect(budgetToggleMemberPaidRequestSchema.safeParse({ paid: true }).success).toBe(true);
|
|
expect(budgetToggleMemberPaidRequestSchema.safeParse({ paid: 'yes' }).success).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('budgetReorderItemsRequestSchema', () => {
|
|
it('requires numeric ids', () => {
|
|
expect(budgetReorderItemsRequestSchema.safeParse({ orderedIds: [3, 1, 2] }).success).toBe(true);
|
|
expect(budgetReorderItemsRequestSchema.safeParse({ orderedIds: ['a'] }).success).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('COST_CATEGORIES', () => {
|
|
it('includes fuel and parking alongside the existing fixed categories', () => {
|
|
expect(COST_CATEGORIES).toContain('fuel');
|
|
expect(COST_CATEGORIES).toContain('parking');
|
|
});
|
|
});
|
|
|
|
describe('typeToCostCategory', () => {
|
|
it('files a parking booking under parking, not transport', () => {
|
|
expect(typeToCostCategory('parking')).toBe('parking');
|
|
});
|
|
|
|
it('leaves the other vehicle types on transport', () => {
|
|
expect(typeToCostCategory('car-rental')).toBe('transport');
|
|
expect(typeToCostCategory('taxi')).toBe('transport');
|
|
});
|
|
});
|