mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-23 07:26:30 +00:00
Maurice
72a82b3c44
214 items came out of writing the tests. Real defects are corrected, dead code is removed rather than covered, and the tests that pinned the old behaviour move with them. Also drops two agent coverage scratch files that slipped into the coverage PR and adds the ignore rule that keeps them out.
275 lines
14 KiB
TypeScript
275 lines
14 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
||
import MTransportSheet from '../../../../src/mobile/screens/trip/sheets/MTransportSheet'
|
||
import { openFile } from '../../../../src/utils/fileDownload'
|
||
import { useSettingsStore } from '../../../../src/store/settingsStore'
|
||
import type { Reservation, TripFile } from '../../../../src/types'
|
||
import { buildPlanner, buildShell } from '../../../helpers/mobileTrip'
|
||
import { resetAllStores, seedStore } from '../../../helpers/store'
|
||
import { fireEvent, render, screen } from '../../../helpers/render'
|
||
|
||
// FE-MOB-TRSH-001 to FE-MOB-TRSH-020
|
||
|
||
vi.mock('../../../../src/utils/fileDownload', () => ({ openFile: vi.fn() }))
|
||
|
||
const FLIGHT = {
|
||
id: 7,
|
||
trip_id: 1,
|
||
type: 'flight',
|
||
title: 'FRA → HND',
|
||
status: 'pending',
|
||
day_id: 3,
|
||
reservation_time: '2026-05-01T10:20',
|
||
reservation_end_time: '2026-05-02T06:45',
|
||
confirmation_number: 'QW7788',
|
||
notes: 'Window seat requested',
|
||
metadata: JSON.stringify({ airline: 'Lufthansa', flight_number: 'LH 716', seat: '31A' }),
|
||
endpoints: [
|
||
{ id: 1, reservation_id: 7, role: 'from', sequence: 0, name: 'Frankfurt (FRA)', code: 'FRA', lat: 50.03, lng: 8.57, timezone: 'Europe/Berlin', local_date: '2026-05-01', local_time: '10:20' },
|
||
{ id: 2, reservation_id: 7, role: 'to', sequence: 1, name: 'Tokyo (HND)', code: 'HND', lat: 35.55, lng: 139.78, timezone: 'Asia/Tokyo', local_date: '2026-05-02', local_time: '06:45' },
|
||
],
|
||
} as unknown as Reservation
|
||
|
||
function makePlanner(overrides: Record<string, unknown> = {}) {
|
||
return buildPlanner({
|
||
reservations: [FLIGHT],
|
||
files: [],
|
||
...overrides,
|
||
} as unknown as Parameters<typeof buildPlanner>[0])
|
||
}
|
||
|
||
function makeShell(overrides: Record<string, unknown> = {}) {
|
||
return buildShell({ sheet: { id: 'transport', payload: { reservationId: 7 } }, ...overrides } as unknown as Parameters<typeof buildShell>[0])
|
||
}
|
||
|
||
describe('MTransportSheet', () => {
|
||
beforeEach(() => {
|
||
resetAllStores()
|
||
})
|
||
|
||
afterEach(() => {
|
||
vi.clearAllMocks()
|
||
})
|
||
|
||
it('FE-MOB-TRSH-001: renders nothing when the payload points at an unknown reservation', () => {
|
||
render(<MTransportSheet planner={makePlanner({ reservations: [] })} shell={makeShell()} />)
|
||
expect(screen.queryByRole('dialog')).not.toBeInTheDocument()
|
||
})
|
||
|
||
it('FE-MOB-TRSH-002: stays closed while another sheet id is active', () => {
|
||
render(<MTransportSheet planner={makePlanner()} shell={makeShell({ sheet: { id: 'mehr', payload: { reservationId: 7 } } })} />)
|
||
expect(screen.queryByRole('dialog')).not.toBeInTheDocument()
|
||
})
|
||
|
||
it('FE-MOB-TRSH-003: shows title, airline meta and the endpoint route in the subline', () => {
|
||
render(<MTransportSheet planner={makePlanner()} shell={makeShell()} />)
|
||
expect(screen.getByRole('dialog', { name: 'FRA → HND' })).toBeInTheDocument()
|
||
expect(screen.getByText('Lufthansa · LH 716 · Frankfurt (FRA) → Tokyo (HND)')).toBeInTheDocument()
|
||
})
|
||
|
||
it('FE-MOB-TRSH-004: falls back to the formatted date when the booking has no endpoints', () => {
|
||
const res = { ...FLIGHT, endpoints: [], metadata: null } as unknown as Reservation
|
||
render(<MTransportSheet planner={makePlanner({ reservations: [res] })} shell={makeShell()} />)
|
||
expect(screen.getByText('Fri, May 1')).toBeInTheDocument()
|
||
})
|
||
|
||
it('FE-MOB-TRSH-005: shows departure and arrival stat boxes labelled with the endpoint names', () => {
|
||
render(<MTransportSheet planner={makePlanner()} shell={makeShell()} />)
|
||
expect(screen.getByText('10:20')).toBeInTheDocument()
|
||
expect(screen.getByText('06:45')).toBeInTheDocument()
|
||
expect(screen.getByText('Frankfurt (FRA)')).toBeInTheDocument()
|
||
expect(screen.getByText('Tokyo (HND)')).toBeInTheDocument()
|
||
expect(screen.getByText('31A')).toBeInTheDocument()
|
||
expect(screen.getByText('Seat')).toBeInTheDocument()
|
||
})
|
||
|
||
it('FE-MOB-TRSH-006: renders the ISO reservation time in the 12h format and the generic time label', () => {
|
||
seedStore(useSettingsStore, { settings: { ...useSettingsStore.getState().settings, time_format: '12h' } })
|
||
const res = {
|
||
...FLIGHT,
|
||
endpoints: [],
|
||
reservation_time: '2026-05-01T15:30:00Z',
|
||
reservation_end_time: null,
|
||
metadata: null,
|
||
} as unknown as Reservation
|
||
render(<MTransportSheet planner={makePlanner({ reservations: [res] })} shell={makeShell()} />)
|
||
expect(screen.getByText(/PM$/)).toBeInTheDocument()
|
||
expect(screen.getByText('Time')).toBeInTheDocument()
|
||
})
|
||
|
||
it('FE-MOB-TRSH-007: shows the train number and platform of a train booking', () => {
|
||
const res = {
|
||
...FLIGHT, type: 'train', title: 'ICE to Berlin',
|
||
metadata: { train_number: 'ICE 599', platform: '7', seat: '12C' },
|
||
} as unknown as Reservation
|
||
render(<MTransportSheet planner={makePlanner({ reservations: [res] })} shell={makeShell()} />)
|
||
expect(screen.getByText(/ICE 599/)).toBeInTheDocument()
|
||
expect(screen.getByText('7')).toBeInTheDocument()
|
||
expect(screen.getByText('Platform')).toBeInTheDocument()
|
||
})
|
||
|
||
it('FE-MOB-TRSH-008: survives unparsable metadata without meta rows', () => {
|
||
const res = { ...FLIGHT, metadata: '{not json', endpoints: [] } as unknown as Reservation
|
||
render(<MTransportSheet planner={makePlanner({ reservations: [res] })} shell={makeShell()} />)
|
||
expect(screen.getByRole('dialog', { name: 'FRA → HND' })).toBeInTheDocument()
|
||
expect(screen.queryByText('Seat')).not.toBeInTheDocument()
|
||
})
|
||
|
||
it('FE-MOB-TRSH-009: renders the transit itinerary with line, walk, duration and stop counts', () => {
|
||
const res = {
|
||
...FLIGHT, type: 'transit', title: 'To the museum', endpoints: [], metadata: {
|
||
transit: {
|
||
legs: [
|
||
{ mode: 'WALK', duration: 240, to: { name: 'Karlsplatz' } },
|
||
{
|
||
mode: 'SUBWAY', line: 'U4', line_color: '#00a94f', line_text_color: '#fff', duration: 600, stops: 4,
|
||
from: { name: 'Karlsplatz', time: '09:10' }, to: { name: 'Schwedenplatz', time: '09:20' },
|
||
},
|
||
{ mode: 'BUS', line: null, duration: 0, from: { name: 'Schwedenplatz', time: null }, to: { name: 'Prater' } },
|
||
],
|
||
},
|
||
},
|
||
} as unknown as Reservation
|
||
render(<MTransportSheet planner={makePlanner({ reservations: [res] })} shell={makeShell()} />)
|
||
expect(screen.getByText('Walk to Karlsplatz')).toBeInTheDocument()
|
||
expect(screen.getByText('4 min')).toBeInTheDocument()
|
||
expect(screen.getByText('U4')).toBeInTheDocument()
|
||
expect(screen.getByText('09:10 – 09:20 · 10 min · 4 stops')).toBeInTheDocument()
|
||
// A leg without a line falls back to its mode and renders no meta line.
|
||
expect(screen.getByText('BUS')).toBeInTheDocument()
|
||
expect(screen.getByText('Prater')).toBeInTheDocument()
|
||
})
|
||
|
||
it('FE-MOB-TRSH-010: shows the pending status and the booking code unblurred by default', () => {
|
||
render(<MTransportSheet planner={makePlanner()} shell={makeShell()} />)
|
||
expect(screen.getByText('Pending')).toBeInTheDocument()
|
||
const code = screen.getByText('#QW7788')
|
||
expect(code.className).not.toContain('blur')
|
||
})
|
||
|
||
it('FE-MOB-TRSH-011: blurs the booking code until it is tapped', () => {
|
||
seedStore(useSettingsStore, { settings: { ...useSettingsStore.getState().settings, blur_booking_codes: true } })
|
||
const res = { ...FLIGHT, status: 'confirmed' } as unknown as Reservation
|
||
render(<MTransportSheet planner={makePlanner({ reservations: [res] })} shell={makeShell()} />)
|
||
expect(screen.getByText('Confirmed')).toBeInTheDocument()
|
||
const code = screen.getByText('#QW7788')
|
||
expect(code.className).toContain('blur-[4px]')
|
||
fireEvent.click(code)
|
||
expect(screen.getByText('#QW7788').className).not.toContain('blur-[4px]')
|
||
})
|
||
|
||
it('FE-MOB-TRSH-012: re-blurs the code once the sheet is closed again', () => {
|
||
seedStore(useSettingsStore, { settings: { ...useSettingsStore.getState().settings, blur_booking_codes: true } })
|
||
const planner = makePlanner()
|
||
const { rerender } = render(<MTransportSheet planner={planner} shell={makeShell()} />)
|
||
fireEvent.click(screen.getByText('#QW7788'))
|
||
expect(screen.getByText('#QW7788').className).not.toContain('blur-[4px]')
|
||
rerender(<MTransportSheet planner={planner} shell={makeShell({ sheet: null })} />)
|
||
rerender(<MTransportSheet planner={planner} shell={makeShell()} />)
|
||
expect(screen.getByText('#QW7788').className).toContain('blur-[4px]')
|
||
})
|
||
|
||
it('FE-MOB-TRSH-013: renders the notes block only when the booking has notes', () => {
|
||
render(<MTransportSheet planner={makePlanner()} shell={makeShell()} />)
|
||
expect(screen.getByText('Window seat requested')).toBeInTheDocument()
|
||
|
||
const res = { ...FLIGHT, notes: null } as unknown as Reservation
|
||
render(<MTransportSheet planner={makePlanner({ reservations: [res] })} shell={makeShell()} />)
|
||
expect(screen.getAllByText('Notes')).toHaveLength(1)
|
||
})
|
||
|
||
it('FE-MOB-TRSH-014: drawing the route closes the sheet and jumps to the plan map', () => {
|
||
const planner = makePlanner()
|
||
const shell = makeShell({ trTab: 'transports', view: 'plan' })
|
||
render(<MTransportSheet planner={planner} shell={shell} />)
|
||
const btn = screen.getByRole('button', { name: 'On map' })
|
||
expect(btn).toHaveAttribute('aria-pressed', 'false')
|
||
fireEvent.click(btn)
|
||
expect(planner.toggleConnection).toHaveBeenCalledWith(7)
|
||
expect(shell.closeSheet).toHaveBeenCalledTimes(1)
|
||
expect(shell.setTrTab).toHaveBeenCalledWith('plan')
|
||
expect(shell.toggleView).toHaveBeenCalledTimes(1)
|
||
})
|
||
|
||
it('FE-MOB-TRSH-015: hides an already drawn route without navigating away', () => {
|
||
const planner = makePlanner({ visibleConnections: [7] })
|
||
const shell = makeShell({ trTab: 'plan', view: 'map' })
|
||
render(<MTransportSheet planner={planner} shell={shell} />)
|
||
const btn = screen.getByRole('button', { name: 'On map' })
|
||
expect(btn).toHaveAttribute('aria-pressed', 'true')
|
||
fireEvent.click(btn)
|
||
expect(planner.toggleConnection).toHaveBeenCalledWith(7)
|
||
expect(shell.closeSheet).not.toHaveBeenCalled()
|
||
expect(shell.setTrTab).not.toHaveBeenCalled()
|
||
expect(shell.toggleView).not.toHaveBeenCalled()
|
||
})
|
||
|
||
it('FE-MOB-TRSH-016: lists the attached files and opens one on tap', () => {
|
||
const files = [
|
||
{ id: 1, reservation_id: 7, original_name: 'boardingpass.pdf', url: '/api/trips/1/files/1/download' },
|
||
{ id: 2, reservation_id: null, linked_reservation_ids: [7], original_name: 'invoice.pdf', url: '/api/trips/1/files/2/download' },
|
||
{ id: 3, reservation_id: 7, deleted_at: '2026-04-01', original_name: 'trashed.pdf', url: '/x' },
|
||
{ id: 4, reservation_id: 99, original_name: 'other.pdf', url: '/y' },
|
||
] as unknown as TripFile[]
|
||
render(<MTransportSheet planner={makePlanner({ files })} shell={makeShell()} />)
|
||
expect(screen.getByText('boardingpass.pdf')).toBeInTheDocument()
|
||
expect(screen.getByText('invoice.pdf')).toBeInTheDocument()
|
||
expect(screen.queryByText('trashed.pdf')).not.toBeInTheDocument()
|
||
expect(screen.queryByText('other.pdf')).not.toBeInTheDocument()
|
||
|
||
fireEvent.click(screen.getByText('boardingpass.pdf'))
|
||
expect(openFile).toHaveBeenCalledWith('/api/trips/1/files/1/download', 'boardingpass.pdf')
|
||
})
|
||
|
||
it('FE-MOB-TRSH-017: opens the transport editor for the booking', () => {
|
||
const planner = makePlanner()
|
||
const shell = makeShell()
|
||
render(<MTransportSheet planner={planner} shell={shell} />)
|
||
fireEvent.click(screen.getByRole('button', { name: 'Edit' }))
|
||
expect(planner.setEditingTransport).toHaveBeenCalledWith(expect.objectContaining({ id: 7 }))
|
||
expect(planner.setTransportModalDayId).toHaveBeenCalledWith(3)
|
||
expect(planner.setShowTransportModal).toHaveBeenCalledWith(true)
|
||
expect(shell.closeSheet).toHaveBeenCalledTimes(1)
|
||
})
|
||
|
||
it('FE-MOB-TRSH-018: passes a null day id to the editor when the booking has none', () => {
|
||
const res = { ...FLIGHT, day_id: null } as unknown as Reservation
|
||
const planner = makePlanner({ reservations: [res] })
|
||
render(<MTransportSheet planner={planner} shell={makeShell()} />)
|
||
fireEvent.click(screen.getByRole('button', { name: 'Edit' }))
|
||
expect(planner.setTransportModalDayId).toHaveBeenCalledWith(null)
|
||
})
|
||
|
||
it('FE-MOB-TRSH-019: deletes the booking and closes the sheet', () => {
|
||
const planner = makePlanner()
|
||
const shell = makeShell()
|
||
render(<MTransportSheet planner={planner} shell={shell} />)
|
||
fireEvent.click(screen.getByRole('button', { name: 'Delete' }))
|
||
expect(planner.handleDeleteReservation).toHaveBeenCalledWith(7)
|
||
expect(shell.closeSheet).toHaveBeenCalledTimes(1)
|
||
})
|
||
|
||
it('FE-MOB-TRSH-020: hides edit and delete without the day_edit permission but keeps the map toggle', () => {
|
||
const planner = makePlanner({ can: vi.fn(() => false) })
|
||
render(<MTransportSheet planner={planner} shell={makeShell()} />)
|
||
expect(screen.queryByRole('button', { name: 'Edit' })).not.toBeInTheDocument()
|
||
expect(screen.queryByRole('button', { name: 'Delete' })).not.toBeInTheDocument()
|
||
expect(screen.getByRole('button', { name: 'On map' })).toBeInTheDocument()
|
||
})
|
||
|
||
it('FE-MOB-TRSH-021: keeps the last booking on screen while the sheet animates out', () => {
|
||
const planner = makePlanner()
|
||
const shell = makeShell()
|
||
const { rerender } = render(<MTransportSheet planner={planner} shell={shell} />)
|
||
expect(screen.getByText('FRA → HND')).toBeInTheDocument()
|
||
rerender(<MTransportSheet planner={makePlanner({ reservations: [] })} shell={shell} />)
|
||
expect(screen.getByText('FRA → HND')).toBeInTheDocument()
|
||
})
|
||
|
||
it('FE-MOB-TRSH-022: closes from the header button', () => {
|
||
const shell = makeShell()
|
||
render(<MTransportSheet planner={makePlanner()} shell={shell} />)
|
||
fireEvent.click(screen.getByRole('button', { name: 'Close' }))
|
||
expect(shell.closeSheet).toHaveBeenCalledTimes(1)
|
||
})
|
||
})
|