Maurice
299beb65b1
A car booking without an end day is a one-day booking everywhere else in the plan, but the road trip read it as a car never handed back: only its pick-up desk stood on the road. Two one-way car bookings on one day (Bologna to Villach, then Villach to Klagenfurt) therefore drove from the first pick-up to the second and on to whatever came before, counting the road between the two cities twice and never reaching Klagenfurt. This applies to the planner, the phone and calculate_roadtrip alike, since all three seat the desks through the shared carrierSeam. Such a car now has its return desk on the pick-up day. A return without a time goes back before the next car of that day is collected rather than closing the day behind it, so each one-way car drives its own road once. Bookings with a return day and cars without a located return desk are unchanged. Closes #2894
@trek/shared
Single source of truth for TREK's API contracts, expressed as Zod schemas and consumed by both the server (request validation + inferred DTO types) and the client (typed requests/responses).
This package is part of the incremental NestJS + React 19 migration (see the "Brownfield Rewrite" board). It is intentionally dormant until modules start importing it — adding it changes nothing for users.
Rules
- One folder per domain:
src/<domain>/<domain>.schema.ts(+.spec.ts). - Domain-agnostic building blocks live in
src/common/. - A route is only considered migrated once its contract lives here.
- Schemas are the source of truth; server DTOs and client types are inferred from them
(
z.infer<typeof schema>), never hand-duplicated.
Consumption (dev)
Both apps resolve @trek/shared to this package's TypeScript source:
- Server (
tsx): viapathsinserver/tsconfig.json. - Client (
vite): viaresolve.aliasinclient/vite.config.ts(+pathsfor the type-checker).
Production packaging (Docker / workspace wiring) is introduced in card F2, when the server first depends on this package at runtime. Until then prod builds are untouched.
Not yet here
The canonical error envelope is finalised in card F5 (it must match TREK's current Express error responses byte-for-byte), so it is deliberately not invented in F1.