Files
TREK/client/src/components/Journey/PhotoLightbox.test.tsx
T
Maurice d6435572b7 fix(journey): two quick swipes in the photo viewer turn pages instead of zooming
A double tap counted every lift of a finger, the end of a swipe included, so
two quick swipes zoomed in. Only a touch that stays in place is a tap now.
The client tests follow the fields and arguments the qol sweep added.
2026-09-30 23:30:51 +02:00

251 lines
11 KiB
TypeScript

// FE-COMP-LIGHTBOX-001 to FE-COMP-LIGHTBOX-021
// Plyr needs a real media pipeline, so the player is stubbed here.
vi.mock('./VideoPlayer', () => ({
default: ({ src }: { src: string }) => <video data-testid="video-player" src={src} />,
}));
vi.mock('../../api/websocket', () => ({
connect: vi.fn(),
disconnect: vi.fn(),
getSocketId: vi.fn(() => null),
setRefetchCallback: vi.fn(),
setPreReconnectHook: vi.fn(),
addListener: vi.fn(),
removeListener: vi.fn(),
}));
import { render, screen, fireEvent } from '../../../tests/helpers/render';
import { resetAllStores } from '../../../tests/helpers/store';
import PhotoLightbox from './PhotoLightbox';
const samplePhotos = [
{ id: 'p1', src: '/photos/1.jpg', caption: 'Sunset at the beach' },
{ id: 'p2', src: '/photos/2.jpg', caption: 'Mountain trail' },
{ id: 'p3', src: '/photos/3.jpg', caption: null },
];
beforeEach(() => {
resetAllStores();
});
describe('PhotoLightbox', () => {
it('FE-COMP-LIGHTBOX-001: renders without crashing when open', () => {
const onClose = vi.fn();
render(<PhotoLightbox photos={samplePhotos} onClose={onClose} />);
expect(document.body).toBeInTheDocument();
});
it('FE-COMP-LIGHTBOX-002: shows photo image', () => {
const onClose = vi.fn();
render(<PhotoLightbox photos={samplePhotos} onClose={onClose} />);
const img = screen.getByRole('img');
expect(img).toBeInTheDocument();
expect(img).toHaveAttribute('src', '/photos/1.jpg');
});
it('FE-COMP-LIGHTBOX-003: shows close button', () => {
const onClose = vi.fn();
render(<PhotoLightbox photos={samplePhotos} onClose={onClose} />);
const buttons = screen.getAllByRole('button');
// Close button exists (the X button in the top bar)
expect(buttons.length).toBeGreaterThan(0);
});
it('FE-COMP-LIGHTBOX-004: previous/next navigation works', () => {
const onClose = vi.fn();
render(<PhotoLightbox photos={samplePhotos} onClose={onClose} />);
// Initially shows photo 1
expect(screen.getByText('1 / 3')).toBeInTheDocument();
const img = screen.getByRole('img');
expect(img).toHaveAttribute('src', '/photos/1.jpg');
// Navigate to next photo via ArrowRight key
fireEvent.keyDown(window, { key: 'ArrowRight' });
expect(screen.getByText('2 / 3')).toBeInTheDocument();
expect(screen.getByRole('img')).toHaveAttribute('src', '/photos/2.jpg');
// Navigate back via ArrowLeft key
fireEvent.keyDown(window, { key: 'ArrowLeft' });
expect(screen.getByText('1 / 3')).toBeInTheDocument();
expect(screen.getByRole('img')).toHaveAttribute('src', '/photos/1.jpg');
});
it('FE-COMP-LIGHTBOX-005: keyboard Escape closes lightbox', () => {
const onClose = vi.fn();
render(<PhotoLightbox photos={samplePhotos} onClose={onClose} />);
fireEvent.keyDown(window, { key: 'Escape' });
expect(onClose).toHaveBeenCalled();
});
it('FE-COMP-LIGHTBOX-006: counter shows "1 / N"', () => {
const onClose = vi.fn();
render(<PhotoLightbox photos={samplePhotos} onClose={onClose} />);
expect(screen.getByText('1 / 3')).toBeInTheDocument();
});
it('FE-COMP-LIGHTBOX-007: does not render when photos array is empty', () => {
const onClose = vi.fn();
const { container } = render(<PhotoLightbox photos={[]} onClose={onClose} />);
// Component returns null when photo is undefined (empty array, index 0 is undefined)
expect(container.querySelector('img')).not.toBeInTheDocument();
});
it('FE-COMP-LIGHTBOX-008: calls onClose when close button clicked', () => {
const onClose = vi.fn();
render(<PhotoLightbox photos={samplePhotos} onClose={onClose} />);
screen.getByRole('button', { name: 'Close' }).click();
expect(onClose).toHaveBeenCalled();
});
it('FE-COMP-LIGHTBOX-009: opens at the requested start index', () => {
const { container } = render(<PhotoLightbox photos={samplePhotos} startIndex={2} onClose={vi.fn()} />);
expect(screen.getByText('3 / 3')).toBeInTheDocument();
// The third photo has no caption, so its img is presentational.
expect(container.querySelector('img')).toHaveAttribute('src', '/photos/3.jpg');
});
it('FE-COMP-LIGHTBOX-010: only offers the arrows that lead somewhere', () => {
render(<PhotoLightbox photos={samplePhotos} onClose={vi.fn()} />);
// First photo: the two zoom buttons, close and next.
expect(screen.getAllByRole('button')).toHaveLength(4);
fireEvent.keyDown(window, { key: 'ArrowRight' });
expect(screen.getAllByRole('button')).toHaveLength(5);
fireEvent.keyDown(window, { key: 'ArrowRight' });
// Last photo: zoom, close and prev.
expect(screen.getAllByRole('button')).toHaveLength(4);
fireEvent.keyDown(window, { key: 'ArrowRight' });
expect(screen.getByText('3 / 3')).toBeInTheDocument();
});
it('FE-COMP-LIGHTBOX-011: navigates with the on-screen arrows', () => {
render(<PhotoLightbox photos={samplePhotos} startIndex={1} onClose={vi.fn()} />);
const [, , , prev, next] = screen.getAllByRole('button');
fireEvent.click(next);
expect(screen.getByText('3 / 3')).toBeInTheDocument();
fireEvent.click(screen.getAllByRole('button')[3]);
expect(screen.getByText('2 / 3')).toBeInTheDocument();
expect(prev).toBeInTheDocument();
});
it('FE-COMP-LIGHTBOX-012: stays on the first photo when arrowing left', () => {
render(<PhotoLightbox photos={samplePhotos} onClose={vi.fn()} />);
fireEvent.keyDown(window, { key: 'ArrowLeft' });
expect(screen.getByText('1 / 3')).toBeInTheDocument();
});
it('FE-COMP-LIGHTBOX-013: renders the caption of the current photo only', () => {
render(<PhotoLightbox photos={samplePhotos} onClose={vi.fn()} />);
expect(screen.getByText('Sunset at the beach')).toBeInTheDocument();
expect(screen.queryByText('Mountain trail')).not.toBeInTheDocument();
fireEvent.keyDown(window, { key: 'ArrowRight' });
expect(screen.getByText('Mountain trail')).toBeInTheDocument();
});
it('FE-COMP-LIGHTBOX-014: renders a video item through the player instead of an image', async () => {
render(
<PhotoLightbox
photos={[{ id: 'v1', src: '/videos/1.mp4', caption: null, mediaType: 'video' }]}
onClose={vi.fn()}
/>,
);
// The player loads on demand now — plyr no longer ships with the journal.
expect(await screen.findByTestId('video-player')).toHaveAttribute('src', '/videos/1.mp4');
expect(screen.queryByRole('img')).not.toBeInTheDocument();
});
it('FE-COMP-LIGHTBOX-015: swipes horizontally to move between photos', () => {
const { container } = render(<PhotoLightbox photos={samplePhotos} startIndex={1} onClose={vi.fn()} />);
const surface = container.firstElementChild as HTMLElement;
fireEvent.touchStart(surface, { touches: [{ clientX: 200, clientY: 200 }] });
fireEvent.touchEnd(surface, { changedTouches: [{ clientX: 100, clientY: 210 }] });
expect(screen.getByText('3 / 3')).toBeInTheDocument();
fireEvent.touchStart(surface, { touches: [{ clientX: 100, clientY: 200 }] });
fireEvent.touchEnd(surface, { changedTouches: [{ clientX: 200, clientY: 210 }] });
expect(screen.getByText('2 / 3')).toBeInTheDocument();
});
it('FE-COMP-LIGHTBOX-016: swipes down to close', () => {
const onClose = vi.fn();
const { container } = render(<PhotoLightbox photos={samplePhotos} onClose={onClose} />);
const surface = container.firstElementChild as HTMLElement;
fireEvent.touchStart(surface, { touches: [{ clientX: 200, clientY: 100 }] });
fireEvent.touchEnd(surface, { changedTouches: [{ clientX: 210, clientY: 300 }] });
expect(onClose).toHaveBeenCalledTimes(1);
});
it('FE-COMP-LIGHTBOX-017: ignores a touch end without a matching touch start', () => {
const onClose = vi.fn();
const { container } = render(<PhotoLightbox photos={samplePhotos} onClose={onClose} />);
const surface = container.firstElementChild as HTMLElement;
fireEvent.touchEnd(surface, { changedTouches: [{ clientX: 210, clientY: 300 }] });
expect(onClose).not.toHaveBeenCalled();
expect(screen.getByText('1 / 3')).toBeInTheDocument();
});
it('FE-COMP-LIGHTBOX-018: zooms with the buttons and a double click, and starts over on the next photo (#1484)', () => {
render(<PhotoLightbox photos={samplePhotos} onClose={vi.fn()} />);
const img = screen.getByRole('img');
expect(screen.getByRole('button', { name: 'Zoom out' })).toBeDisabled();
fireEvent.click(screen.getByRole('button', { name: 'Zoom in' }));
expect(img.style.transform).toContain('scale(1.5)');
expect(screen.getByRole('button', { name: 'Back to full photo' })).toHaveTextContent('150%');
fireEvent.click(screen.getByRole('button', { name: 'Back to full photo' }));
expect(img.style.transform).toBe('translate(0px, 0px) scale(1)');
fireEvent.doubleClick(img);
expect(img.style.transform).toContain('scale(2.5)');
fireEvent.keyDown(window, { key: 'ArrowRight' });
expect(screen.getByRole('img').style.transform).toBe('translate(0px, 0px) scale(1)');
});
it('FE-COMP-LIGHTBOX-021: two quick taps zoom in, two quick swipes turn two pages', () => {
render(<PhotoLightbox photos={samplePhotos} startIndex={0} onClose={vi.fn()} />);
const surface = screen.getByRole('img').closest('div[style*="position: fixed"]') as HTMLElement;
for (let i = 0; i < 2; i++) {
fireEvent.touchStart(surface, { touches: [{ clientX: 200, clientY: 200 }] });
fireEvent.touchEnd(surface, { touches: [], changedTouches: [{ clientX: 202, clientY: 201 }] });
}
expect(screen.getByRole('button', { name: 'Zoom out' })).not.toBeDisabled();
expect(screen.getByText('1 / 3')).toBeInTheDocument();
});
it('FE-COMP-LIGHTBOX-019: a swipe on an enlarged photo pans instead of turning the page', () => {
const onClose = vi.fn();
render(<PhotoLightbox photos={samplePhotos} onClose={onClose} />);
fireEvent.click(screen.getByRole('button', { name: 'Zoom in' }));
const overlay = screen.getByRole('img').closest('div[style*="position: fixed"]') as HTMLElement;
fireEvent.touchStart(overlay, { touches: [{ clientX: 200, clientY: 200 }] });
fireEvent.touchMove(overlay, { touches: [{ clientX: 80, clientY: 320 }] });
fireEvent.touchEnd(overlay, { touches: [], changedTouches: [{ clientX: 80, clientY: 320 }] });
expect(screen.getByText('1 / 3')).toBeInTheDocument();
expect(onClose).not.toHaveBeenCalled();
});
it('FE-COMP-LIGHTBOX-020: a pinch zooms in without closing', () => {
const onClose = vi.fn();
render(<PhotoLightbox photos={samplePhotos} onClose={onClose} />);
const img = screen.getByRole('img');
const overlay = img.closest('div[style*="position: fixed"]') as HTMLElement;
fireEvent.touchStart(overlay, { touches: [{ clientX: 100, clientY: 100 }, { clientX: 200, clientY: 100 }] });
fireEvent.touchMove(overlay, { touches: [{ clientX: 50, clientY: 100 }, { clientX: 250, clientY: 100 }] });
fireEvent.touchEnd(overlay, { touches: [], changedTouches: [{ clientX: 250, clientY: 100 }] });
expect(img.style.transform).toContain('scale(2)');
expect(onClose).not.toHaveBeenCalled();
});
});