Files
TREK/server/src/db/repositories/_shared/reservation-accommodation.ts
T
Maurice 0e911608af fix(db): match a stay's bookings by the stored '<id>.0' text, as SQLite did
Reading the TEXT column as an integer also matched '14', ' 14' and '14abc',
which the legacy REAL-bound compare never did (AC37/AC40). Comparing with the
'<id>.0' text the services store keeps that contract on both engines.
2026-11-17 23:03:59 +01:00

42 lines
1.9 KiB
TypeScript

import { legacyBoundIntegerText } from '../../../nest/common/row-id';
import { integerTextEqualsKysely } from '../../dialect/kysely-functions';
import type { Platform } from '@mikro-orm/core';
import type { ExpressionBuilder, ExpressionWrapper, SqlBool, StringReference } from 'kysely';
/**
* The join condition between a reservation and the stay it is booked against.
*
* `reservations.accommodation_id` is TEXT with no foreign key, while
* `day_accommodations.id` is INTEGER, and the services store the id as
* `'14.0'` (`legacyBoundIntegerText`). The dialect helper
* `integerTextEqualsKysely` compares the two so that `'14'`, `'14.0'` and 14
* match the stay 14 on both engines. Every join and correlation on this pair
* goes through here, so the comparison has one spelling.
*/
export function accommodationIdMatches<DB, TB extends keyof DB>(
platform: Platform,
eb: ExpressionBuilder<DB, TB>,
reservationAccommodationId: StringReference<DB, TB>,
stayId: StringReference<DB, TB>,
): ExpressionWrapper<DB, TB, SqlBool> {
return integerTextEqualsKysely(platform, eb, reservationAccommodationId, stayId);
}
/**
* A reservation booked against the stay `stayId`, the filter form of
* {@link accommodationIdMatches}, held to the legacy compare: SQLite bound the
* id as a REAL, so only the stored `'<id>.0'` shape ever matched, never `'14'`,
* `' 14'` or `'14abc'` (Reservations.repository.test.ts AC37/AC40). Comparing
* the column with that same text keeps that on both engines. Compared with a
* bare number instead, Postgres binds it as the text `'14'` and finds no row
* at all, which no error reports.
*/
export function reservationStayIs<DB, TB extends keyof DB>(
eb: ExpressionBuilder<DB, TB>,
accommodationId: StringReference<DB, TB>,
stayId: number,
): ExpressionWrapper<DB, TB, SqlBool> {
return eb(accommodationId, '=', legacyBoundIntegerText(stayId));
}