mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-06-19 13:21:46 +00:00
247433fb2a
* fix(journey): authorize reads of the journey share link GET /api/journeys/:id/share-link now requires journey access (canAccessJourney), matching the create/delete share-link routes and the get_journey_share_link MCP tool. Returns no link when the caller lacks access to the journey. * feat(costs): rework Budget into Costs — Splitwise-style, multi-currency, mobile Renames the Budget addon to "Costs" (UI only) and reworks it into a Tricount/ Splitwise-style cost tracker: multiple payers per expense, equal split across chosen members, settle-up with persisted history + undo, 12 fixed categories, per-expense currency with live FX conversion to a user-set display currency (Settings -> Display), and locale-correct money formatting. Adds a desktop and a dedicated mobile layout. A migration backfills existing budget items (single payer, split members, currency). Closes #551 (per-expense currency). Also switches the app font to self-hosted Poppins (Geist for secondary subtext), replacing the Google Fonts CDN dependency. * fix(costs): neutral dashboard dark palette + liquid glass, full page width, entry-count badge - Dark mode used a warm oklch palette that read brownish; switch to the neutral zinc tokens used by the dashboard (#121215 bg, #f4f4f5 ink) and add a subtle backdrop-blur glass on cards. - Costs now uses the full available page width on desktop instead of a 1280px cap. - Render the expense count next to the Expenses title as a badge. - Adapt budget/journey unit tests to the new payer-based settlement model and the Costs rename (category default 'other', Costs tab/CostsPanel). * fix(costs): drop the entry-count badge, always show row edit/delete actions Removes the count badge next to the Expenses title and makes the per-row edit/delete actions permanently visible (no longer hover-only) on desktop too. * feat(costs): currency-native money formatting, custom select/date, rename addon to Costs - Format every amount in its own currency convention (symbol position, grouping and decimal separators) regardless of app language, via a currency->locale map (EUR -> '12,00 €', USD -> '$12.00', JPY -> '¥12', ...). Previously Intl used the app locale, so EUR showed the symbol in front under an English UI. - Use TREK's CustomSelect (searchable, with symbols) and CustomDatePicker in the add/edit expense modal instead of the native <select>/<input type=date>. - Rename the 'Budget Planner' add-on to 'Costs' in the admin list (display only; id/tables/permissions/MCP stay 'budget') via seed + a migration for existing DBs. * feat(auth): configurable session duration via SESSION_DURATION Adds a SESSION_DURATION env var (ms-style strings: 1h, 7d, 30d, ...) controlling how long a session stays valid before re-login. It drives both the trek_session JWT exp claim and the cookie maxAge from one source, so they never drift. Invalid values warn at startup and fall back to the default (24h — unchanged). The MFA challenge token and MCP OAuth tokens keep their own TTL. Implements the request from discussion #946. Documented in the env-var wiki page, .env.example and docker-compose.yml.
126 lines
5.0 KiB
TypeScript
126 lines
5.0 KiB
TypeScript
/**
|
|
* BOOTSTRAP / F6 — boots the unified production bootstrap (buildApp) and asserts
|
|
* the whole shell is intact on the single NestJS instance now that Express is gone:
|
|
* the global security pipeline (helmet/CSP), the /uploads platform routes, the
|
|
* migrated /api domains (with the JWT guard), the /api/health + /api/addons
|
|
* platform/inline endpoints, and (in production) HSTS. This is the test that proves
|
|
* server/src/bootstrap.ts + index.ts serve everything correctly without the legacy app.
|
|
*/
|
|
import { describe, it, expect, vi, beforeAll, afterAll } from 'vitest';
|
|
import request from 'supertest';
|
|
import type { INestApplication } from '@nestjs/common';
|
|
|
|
const { testDb, dbMock } = vi.hoisted(() => {
|
|
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
|
const Database = require('better-sqlite3');
|
|
const db = new Database(':memory:');
|
|
db.exec('PRAGMA journal_mode = WAL');
|
|
db.exec('PRAGMA foreign_keys = ON');
|
|
db.exec('PRAGMA busy_timeout = 5000');
|
|
const mock = {
|
|
db,
|
|
closeDb: () => {},
|
|
reinitialize: () => {},
|
|
getPlaceWithTags: () => null,
|
|
canAccessTrip: (tripId: any, userId: number) =>
|
|
db
|
|
.prepare(
|
|
`SELECT t.id, t.user_id FROM trips t LEFT JOIN trip_members m ON m.trip_id = t.id AND m.user_id = ? WHERE t.id = ? AND (t.user_id = ? OR m.user_id IS NOT NULL)`,
|
|
)
|
|
.get(userId, tripId, userId),
|
|
isOwner: (tripId: any, userId: number) => !!db.prepare('SELECT id FROM trips WHERE id = ? AND user_id = ?').get(tripId, userId),
|
|
};
|
|
return { testDb: db, dbMock: mock };
|
|
});
|
|
|
|
vi.mock('../../src/db/database', () => dbMock);
|
|
vi.mock('../../src/config', () => ({
|
|
JWT_SECRET: 'test-jwt-secret-for-trek-testing-only',
|
|
ENCRYPTION_KEY: 'a1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2',
|
|
updateJwtSecret: () => {},
|
|
SESSION_DURATION: '24h',
|
|
SESSION_DURATION_MS: 86400000,
|
|
SESSION_DURATION_SECONDS: 86400,
|
|
DEFAULT_LANGUAGE: 'en',
|
|
}));
|
|
vi.mock('../../src/websocket', () => ({ broadcast: vi.fn(), broadcastToUser: vi.fn() }));
|
|
|
|
import { createTables } from '../../src/db/schema';
|
|
import { runMigrations } from '../../src/db/migrations';
|
|
import { resetTestDb } from '../helpers/test-db';
|
|
import { createUser } from '../helpers/factories';
|
|
import { authCookie } from '../helpers/auth';
|
|
import { buildApp } from '../../src/bootstrap';
|
|
|
|
describe('BOOTSTRAP (F6) — unified NestJS app serves the whole surface', () => {
|
|
let app: INestApplication;
|
|
let instance: import('express').Application;
|
|
|
|
beforeAll(async () => {
|
|
createTables(testDb);
|
|
runMigrations(testDb);
|
|
resetTestDb(testDb);
|
|
app = await buildApp();
|
|
instance = app.getHttpAdapter().getInstance();
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await app.close();
|
|
testDb.close();
|
|
});
|
|
|
|
it('BOOT-001 — GET /api/health returns 200 { status: ok } (platform transport on Nest)', async () => {
|
|
const res = await request(instance).get('/api/health');
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.status).toBe('ok');
|
|
expect(res.headers['cache-control']).toContain('no-store');
|
|
});
|
|
|
|
it('BOOT-002 — the global security pipeline (helmet) is applied', async () => {
|
|
const res = await request(instance).get('/api/health');
|
|
// helmet defaults — proof applyGlobalMiddleware ran on the Nest instance.
|
|
expect(res.headers['x-content-type-options']).toBe('nosniff');
|
|
expect(res.headers['content-security-policy']).toBeDefined();
|
|
});
|
|
|
|
it('BOOT-003 — public /api/config is reachable without auth (migrated Nest domain)', async () => {
|
|
const res = await request(instance).get('/api/config');
|
|
expect(res.status).toBe(200);
|
|
});
|
|
|
|
it('BOOT-004 — a protected /api domain rejects an anonymous request (JWT guard wired)', async () => {
|
|
const res = await request(instance).get('/api/trips');
|
|
expect(res.status).toBe(401);
|
|
});
|
|
|
|
it('BOOT-005 — /uploads/files is blocked without auth (platform uploads on Nest)', async () => {
|
|
const res = await request(instance).get('/uploads/files/anything.bin');
|
|
expect(res.status).toBe(401);
|
|
});
|
|
|
|
it('BOOT-006 — GET /api/addons works end-to-end (guard → Nest AddonsController)', async () => {
|
|
const anon = await request(instance).get('/api/addons');
|
|
expect(anon.status).toBe(401);
|
|
|
|
const { user } = createUser(testDb);
|
|
const res = await request(instance).get('/api/addons').set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
expect(Array.isArray(res.body.addons)).toBe(true);
|
|
});
|
|
|
|
it('BOOT-007 — HSTS is advertised when NODE_ENV=production', async () => {
|
|
const prev = process.env.NODE_ENV;
|
|
process.env.NODE_ENV = 'production';
|
|
let prodApp: INestApplication | undefined;
|
|
try {
|
|
prodApp = await buildApp();
|
|
const res = await request(prodApp.getHttpAdapter().getInstance()).get('/api/health');
|
|
expect(res.headers['strict-transport-security']).toContain('max-age=');
|
|
} finally {
|
|
if (prodApp) await prodApp.close();
|
|
if (prev === undefined) delete process.env.NODE_ENV;
|
|
else process.env.NODE_ENV = prev;
|
|
}
|
|
});
|
|
});
|