Files
TREK/client/tests/unit/scripts/ratchet.test.ts
Maurice bd267c67f8 ci(client): fail the count ratchets on an entry above the tree
lint:size, lint:layers, lint:rtl (both baselines), lint:skips and
lint:warnings only failed a count that passed its entry. A count that
fell below its entry was logged and nothing more, so a file that shrank
could grow back to its old entry unseen, and the entry of a deleted
file stayed behind for the next file at that path. lint:format and
lint:offline already fail on such a stale entry, and the docs said
these counts may only shrink.

Each of them now fails on an entry that lowerCounts would lower or
drop, naming its count or saying the file is gone, and tells to run
--update, which still only lowers. staleCounts and reportStale in
lib/ratchet.mjs hold the shared part. Every baseline matches the tree
today, so none needed lowering. The client CLAUDE.md says so, and that
CI lints through lint:warnings rather than lint:check.
2026-10-08 14:11:54 +02:00

134 lines
5.5 KiB
TypeScript

import { spawnSync } from 'node:child_process';
import { resolve } from 'node:path';
import { pathToFileURL } from 'node:url';
import { afterEach, describe, expect, it } from 'vitest';
import {
countMap,
fileList,
listFiles,
lowerCounts,
lowerList,
RatchetError,
readBaseline,
readText,
reportStale,
staleCounts,
writeBaseline,
} from '../../../scripts/lib/ratchet.mjs';
import { ratchetTree, type RatchetTree } from '../../helpers/ratchetFixture';
let tree: RatchetTree;
afterEach(() => tree?.remove());
describe('scripts/lib/ratchet', () => {
it('RATCHET-001: lists the accepted files under each directory, sorted', () => {
tree = ratchetTree({ 'src/b.ts': '', 'src/a/c.tsx': '', 'src/d.css': '', 'tests/e.ts': '' });
const files = listFiles(tree.root, ['src', 'tests'], (key: string) => /\.tsx?$/.test(key));
expect(
files.map((f: string) =>
f
.slice(tree.root.length + 1)
.split('\\')
.join('/')
)
).toEqual(['src/a/c.tsx', 'src/b.ts', 'tests/e.ts']);
});
it('RATCHET-002: a directory that is not there stops the scan instead of passing it', () => {
tree = ratchetTree({ 'src/a.ts': '' });
expect(() => listFiles(tree.root, ['src', 'tests'], () => true)).toThrow(RatchetError);
expect(() => listFiles(tree.root, ['src', 'tests'], () => true)).toThrow(/tests\/ does not exist/);
});
it('RATCHET-003: a scan that finds no file at all fails', () => {
tree = ratchetTree({ 'src/a.md': '' });
expect(() => listFiles(tree.root, ['src'], (key: string) => key.endsWith('.ts'))).toThrow(/no file to check/);
});
it('RATCHET-004: reads CRLF and a byte order mark as the LF text git holds', () => {
tree = ratchetTree({ 'a.ts': '\uFEFFone\r\ntwo\r\n' });
expect(readText(tree.path('a.ts'))).toBe('one\ntwo\n');
});
it('RATCHET-005: a missing, broken or misshapen baseline is an error, never an empty one', () => {
tree = ratchetTree({
'broken.json': '{ "a": ',
'array.json': '["a"]',
'zero.json': '{ "a": 0 }',
'twice.json': '["a", "a"]',
});
expect(() => readBaseline(tree.path('missing.json'), countMap)).toThrow(/cannot be read/);
expect(() => readBaseline(tree.path('broken.json'), countMap)).toThrow(/not valid JSON/);
expect(() => readBaseline(tree.path('array.json'), countMap)).toThrow(/wrong shape/);
expect(() => readBaseline(tree.path('zero.json'), countMap)).toThrow(/positive whole number/);
expect(() => readBaseline(tree.path('twice.json'), fileList)).toThrow(/listed twice/);
});
it('RATCHET-006: writes a baseline sorted, with a final newline, and reads it back', () => {
tree = ratchetTree();
writeBaseline(tree.path('b.json'), { 'src/z.ts': 2, 'src/a.ts': 1 });
expect(readText(tree.path('b.json'))).toBe('{\n "src/a.ts": 1,\n "src/z.ts": 2\n}\n');
expect(readBaseline(tree.path('b.json'), countMap)).toEqual({ 'src/a.ts': 1, 'src/z.ts': 2 });
});
it('RATCHET-007: lowering never raises an entry, never adds one and drops what fell to the floor', () => {
const lowered = lowerCounts(
{ grew: 5, shrank: 5, gone: 5, floor: 5 },
{ grew: 9, shrank: 3, floor: 2, fresh: 7 },
2
);
expect(lowered).toEqual({ grew: 5, shrank: 3 });
expect(lowerCounts({ a: 9 }, { a: 4 }, (key: string) => (key === 'a' ? 4 : 0))).toEqual({});
});
it('RATCHET-010: an entry above the count, at the floor or for a gone file is stale, one at the count is not', () => {
expect(
staleCounts({ held: 5, shrank: 5, gone: 5, floor: 5 }, { held: 5, shrank: 3, floor: 2, fresh: 9 }, 2)
).toEqual([
{ key: 'shrank', entry: 5, now: 3 },
{ key: 'gone', entry: 5, now: 0 },
{ key: 'floor', entry: 5, now: 2 },
]);
expect(staleCounts({ a: 3 }, { a: 4 })).toEqual([]);
});
it('RATCHET-011: a stale entry is reported with its count, or as gone, and how to lower it', () => {
tree = ratchetTree({ 'src/here.ts': 'x\n' });
const lines: string[] = [];
const error = (line: string) => lines.push(line);
const stale = [
{ key: 'src/here.ts', entry: 4, now: 2 },
{ key: 'src/gone.ts', entry: 3, now: 0 },
];
reportStale(stale, { file: 'b.json', command: 'lint:x', root: tree.root, error });
expect(lines).toEqual([
'FAIL src/here.ts is held at 4 in scripts/b.json, but there are 2 now.',
'FAIL src/gone.ts is held at 3 in scripts/b.json, but the file is gone.',
expect.stringMatching(/^Run npm run lint:x -- --update to lower the baseline/),
]);
lines.length = 0;
reportStale([], { file: 'b.json', command: 'lint:x', error });
expect(lines).toEqual([]);
});
it('RATCHET-008: a file list only loses the files that stopped offending', () => {
expect(lowerList(['a', 'b', 'c'], ['c', 'a', 'new'])).toEqual(['a', 'c']);
});
it('RATCHET-009: a command exits with what its check returns, and 1 when the check itself fails', () => {
const lib = pathToFileURL(resolve('scripts/lib/ratchet.mjs')).href;
const command = (body: string) =>
spawnSync(
process.execPath,
['--input-type=module', '-e', `import { runCli, RatchetError } from '${lib}'; await runCli('lint:x', ${body})`],
{ encoding: 'utf8' }
);
expect(command('() => 0').status).toBe(0);
expect(command('async () => 1').status).toBe(1);
const broken = command("() => { throw new RatchetError('baseline gone') }");
expect(broken.status).toBe(1);
expect(broken.stderr).toContain('FAIL lint:x: baseline gone');
expect(command("() => { throw new Error('bug') }").status).not.toBe(0);
});
});