/** * Unit tests for memories/unifiedService — MEM-UNIFIED-001 to MEM-UNIFIED-010. * Covers error paths: access denied, disabled provider, no providers enabled. */ import { describe, it, expect, vi, beforeAll, beforeEach, afterAll } from 'vitest'; // ── DB setup ───────────────────────────────────────────────────────────────── const { testDb, dbMock } = vi.hoisted(() => { const Database = require('better-sqlite3'); const db = new Database(':memory:'); db.exec('PRAGMA journal_mode = WAL'); db.exec('PRAGMA foreign_keys = ON'); db.exec('PRAGMA busy_timeout = 5000'); const mock = { db, closeDb: () => {}, reinitialize: () => {}, getPlaceWithTags: () => null, canAccessTrip: (tripId: any, userId: number) => db.prepare(` SELECT t.id FROM trips t LEFT JOIN trip_members m ON m.trip_id = t.id AND m.user_id = ? WHERE t.id = ? AND (t.user_id = ? OR m.user_id IS NOT NULL) `).get(userId, tripId, userId), isOwner: (tripId: any, userId: number) => !!db.prepare('SELECT id FROM trips WHERE id = ? AND user_id = ?').get(tripId, userId), }; return { testDb: db, dbMock: mock }; }); vi.mock('../../../src/db/database', () => dbMock); vi.mock('../../../src/config', () => ({ JWT_SECRET: 'test-secret', ENCRYPTION_KEY: 'a1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2', updateJwtSecret: () => {}, })); vi.mock('../../../src/websocket', () => ({ broadcast: vi.fn() })); vi.mock('../../../src/services/notificationService', () => ({ send: vi.fn().mockResolvedValue(undefined), })); import { createTables } from '../../../src/db/schema'; import { runMigrations } from '../../../src/db/migrations'; import { resetTestDb } from '../../helpers/test-db'; import { createUser, createTrip } from '../../helpers/factories'; import { listTripPhotos, listTripAlbumLinks, addTripPhotos, setTripPhotoSharing, removeTripPhoto, createTripAlbumLink, removeAlbumLink, } from '../../../src/services/memories/unifiedService'; beforeAll(() => { createTables(testDb); runMigrations(testDb); }); beforeEach(() => { resetTestDb(testDb); // Ensure default providers are enabled (resetTestDb seeds them but doesn't reset enabled flag) testDb.prepare('UPDATE photo_providers SET enabled = 1').run(); }); afterAll(() => { testDb.close(); }); // ── listTripPhotos ──────────────────────────────────────────────────────────── describe('listTripPhotos', () => { it('MEM-UNIFIED-001: returns 404 when user cannot access trip', () => { const result = listTripPhotos('9999', 1); expect(result.success).toBe(false); expect((result as any).error.status).toBe(404); }); it('MEM-UNIFIED-002: returns 400 when no photo providers are enabled', () => { const { user } = createUser(testDb); const trip = createTrip(testDb, user.id); // Disable all providers testDb.prepare('UPDATE photo_providers SET enabled = 0').run(); const result = listTripPhotos(String(trip.id), user.id); expect(result.success).toBe(false); expect((result as any).error.status).toBe(400); expect((result as any).error.message).toMatch(/no photo providers enabled/i); }); }); // ── listTripAlbumLinks ──────────────────────────────────────────────────────── describe('listTripAlbumLinks', () => { it('MEM-UNIFIED-003: returns 404 when user cannot access trip', () => { const result = listTripAlbumLinks('9999', 1); expect(result.success).toBe(false); expect((result as any).error.status).toBe(404); }); it('MEM-UNIFIED-004: returns 400 when no photo providers are enabled', () => { const { user } = createUser(testDb); const trip = createTrip(testDb, user.id); testDb.prepare('UPDATE photo_providers SET enabled = 0').run(); const result = listTripAlbumLinks(String(trip.id), user.id); expect(result.success).toBe(false); expect((result as any).error.status).toBe(400); }); }); // ── addTripPhotos ───────────────────────────────────────────────────────────── describe('addTripPhotos', () => { it('MEM-UNIFIED-005: returns 404 when user cannot access trip', async () => { const result = await addTripPhotos('9999', 1, false, [{ provider: 'immich', asset_ids: ['a1'] }], 'sid'); expect(result.success).toBe(false); expect((result as any).error.status).toBe(404); }); it('MEM-UNIFIED-006: returns 400 when provider is found but disabled (covers line 25)', async () => { const { user } = createUser(testDb); const trip = createTrip(testDb, user.id); // Insert a disabled provider testDb.prepare( 'INSERT OR IGNORE INTO photo_providers (id, name, description, icon, enabled, sort_order) VALUES (?, ?, ?, ?, ?, ?)' ).run('disabled-prov', 'Disabled', 'Disabled provider', 'Image', 0, 99); const result = await addTripPhotos( String(trip.id), user.id, false, [{ provider: 'disabled-prov', asset_ids: ['asset-x'] }], 'sid', ); expect(result.success).toBe(false); expect((result as any).error.status).toBe(400); expect((result as any).error.message).toMatch(/not enabled/i); }); it('MEM-UNIFIED-007: returns 400 when provider is not found', async () => { const { user } = createUser(testDb); const trip = createTrip(testDb, user.id); const result = await addTripPhotos( String(trip.id), user.id, false, [{ provider: 'nonexistent-provider', asset_ids: ['asset-x'] }], 'sid', ); expect(result.success).toBe(false); expect((result as any).error.status).toBe(400); expect((result as any).error.message).toMatch(/not supported/i); }); }); // ── setTripPhotoSharing ─────────────────────────────────────────────────────── describe('setTripPhotoSharing', () => { it('MEM-UNIFIED-008: returns 404 when user cannot access trip', async () => { const result = await setTripPhotoSharing('9999', 1, 'immich', 'asset-1', true); expect(result.success).toBe(false); expect((result as any).error.status).toBe(404); }); }); // ── removeTripPhoto ─────────────────────────────────────────────────────────── describe('removeTripPhoto', () => { it('MEM-UNIFIED-009: returns 404 when user cannot access trip', () => { const result = removeTripPhoto('9999', 1, 'immich', 'asset-1'); expect(result.success).toBe(false); expect((result as any).error.status).toBe(404); }); }); // ── createTripAlbumLink ─────────────────────────────────────────────────────── describe('createTripAlbumLink', () => { it('MEM-UNIFIED-010: returns 404 when user cannot access trip', () => { const result = createTripAlbumLink('9999', 1, 'immich', 'album-1', 'My Album'); expect(result.success).toBe(false); expect((result as any).error.status).toBe(404); }); it('MEM-UNIFIED-011: returns 400 when provider is disabled', () => { const { user } = createUser(testDb); const trip = createTrip(testDb, user.id); testDb.prepare( 'INSERT OR IGNORE INTO photo_providers (id, name, description, icon, enabled, sort_order) VALUES (?, ?, ?, ?, ?, ?)' ).run('disabled-prov2', 'Disabled2', 'desc', 'Image', 0, 100); const result = createTripAlbumLink(String(trip.id), user.id, 'disabled-prov2', 'album-1', 'My Album'); expect(result.success).toBe(false); expect((result as any).error.status).toBe(400); }); }); // ── removeAlbumLink ─────────────────────────────────────────────────────────── describe('removeAlbumLink', () => { it('MEM-UNIFIED-012: returns 404 when user cannot access trip', () => { const result = removeAlbumLink('9999', '1', 1); expect(result.success).toBe(false); expect((result as any).error.status).toBe(404); }); });