/** * The change cards: names instead of ids, dates and amounts in the user's * locale, the value before a change, and the receipt of an applied change. */ import { buildTripCard } from '../../../../src/nest/assistant/assistant-context'; import type { AssistantWriteTool } from '../../../../src/nest/assistant/assistant-tools.constants'; import type { PreviewContext, ToolCards } from '../../../../src/nest/assistant/cards/card-types'; import { dayLabel, Rows } from '../../../../src/nest/assistant/cards/preview-format'; import { ASSISTANT_WRITE_TOOLS, FOREIGN_ID_GROUPS, TOOL_CARDS } from '../../../../src/nest/assistant/cards/registry'; import { appliedChange, describeToolCall } from '../../../../src/nest/assistant/tool-call-preview.helpers'; import { assistantChangePreviewSchema, trekCardSchema, type TrekCard } from '@trek/shared'; import { describe, expect, it } from 'vitest'; const card = buildTripCard( 1, 7, { trip: { title: 'Kyoto', currency: 'EUR' }, members: { owner: { id: 7, username: 'mia' }, collaborators: [{ id: 8, username: 'jon' }] }, days: [ { id: 31, day_number: 1, date: '2026-06-11', title: 'Arrival', assignments: [{ id: 301, place: { id: 12, name: 'Nishiki Market' } }], notes: [{ id: 41, text: 'Rail pass', time: '09:00' }], }, { id: 32, day_number: 2, date: '2026-06-12', assignments: [], notes: [] }, { id: 33, day_number: 3, date: null, title: 'Spare day', assignments: [], notes: [] }, ], packing: { items: [{ id: 51, name: 'Umbrella', quantity: 1 }] }, }, { places: [ { id: 12, name: 'Nishiki Market', address: 'Old street', lat: 35, lng: 135, price: 5, currency: 'EUR', category_id: 2, }, ], }, null, ); const ctx: PreviewContext = { card, categories: new Map([ [2, 'Food'], [3, 'Sights'], ]), locale: 'en-GB', today: '2026-06-01', airport: () => null, }; const describe_ = (name: string, args: Record) => describeToolCall(name, 'tc-1', args, ctx); describe('dayLabel', () => { it('ASTPRV-001: names a day by its date and title, its title, or its number', () => { expect(dayLabel(ctx, 31)).toBe('Thu 11 Jun, Arrival'); expect(dayLabel(ctx, 32)).toBe('Fri 12 Jun'); expect(dayLabel(ctx, 33)).toBe('Spare day'); expect(dayLabel(ctx, 99)).toBe('#99'); expect(dayLabel({ ...ctx, locale: 'de' }, 32)).toBe('Fr., 12. Juni'); expect(dayLabel({ ...ctx, locale: 'not a locale!' }, 32)).toBe('Fri, Jun 12'); expect(dayLabel({ ...ctx, locale: 'br' }, 32)).toBe(dayLabel({ ...ctx, locale: 'pt-BR' }, 32)); }); }); describe('describeToolCall', () => { it('ASTPRV-010: a place for a day names the day and the fields it carries', () => { const preview = describe_('create_and_assign_place', { dayId: 32, name: 'Kinkaku-ji', address: '1 Kinkakujicho', lat: 35.0394, lng: 135.7292, category_id: 3, price: 4, currency: 'JPY', website: 'https://www.shokoku-ji.jp/kinkakuji/', }); expect(preview).toEqual({ toolCallId: 'tc-1', verbKey: 'addPlaceToDay', subject: 'Kinkaku-ji', rows: [ { op: 'add', labelKey: 'day', before: null, after: 'Fri 12 Jun' }, { op: 'add', labelKey: 'address', before: null, after: '1 Kinkakujicho' }, { op: 'add', labelKey: 'coordinates', before: null, after: '35.03940, 135.72920' }, { op: 'add', labelKey: 'category', before: null, after: 'Sights' }, { op: 'add', labelKey: 'website', before: null, after: 'https://www.shokoku-ji.jp/kinkakuji/' }, { op: 'add', labelKey: 'price', before: null, after: 'JPĀ„4' }, ], dayId: 32, placeIds: [], undoable: true, effect: { kind: 'add', dayId: 32, fromDayId: null, placeId: null, assignmentId: null, place: { name: 'Kinkaku-ji', lat: 35.0394, lng: 135.7292, categoryId: 3 }, }, }); expect(assistantChangePreviewSchema.safeParse(preview).success).toBe(true); }); it('ASTPRV-011: an update shows what each field held before', () => { const preview = describe_('update_place', { placeId: 12, name: 'Nishiki', category_id: 3, price: 6, lat: 35.5 }); expect(preview.subject).toBe('Nishiki Market'); expect(preview.placeIds).toEqual([12]); expect(preview.undoable).toBe(false); expect(preview.rows).toEqual([ { op: 'change', labelKey: 'name', before: 'Nishiki Market', after: 'Nishiki' }, { op: 'change', labelKey: 'coordinates', before: '35.00000, 135.00000', after: '35.50000, 135.00000' }, { op: 'change', labelKey: 'category', before: 'Food', after: 'Sights' }, { op: 'change', labelKey: 'price', before: '€5.00', after: '€6.00' }, ]); }); it('ASTPRV-012: a move names both days, a note its day, a cleared field reads empty', () => { expect(describe_('move_assignment', { assignmentId: 301, newDayId: 32 })).toMatchObject({ subject: 'Nishiki Market', rows: [{ op: 'move', labelKey: 'day', before: 'Thu 11 Jun, Arrival', after: 'Fri 12 Jun' }], dayId: 32, placeIds: [12], }); expect(describe_('unassign_place', { dayId: 31, assignmentId: 301 })).toMatchObject({ verbKey: 'removeFromDay', subject: 'Nishiki Market', rows: [{ op: 'add', labelKey: 'day', before: null, after: 'Thu 11 Jun, Arrival' }], dayId: 31, placeIds: [12], }); expect(describe_('update_day_note', { dayId: 31, noteId: 41, time: null })).toMatchObject({ subject: 'Rail pass', rows: [{ op: 'change', labelKey: 'content', before: '09:00', after: '' }], }); expect(describe_('create_day_note', { dayId: 33, text: 'Laundry', icon: '🧺' }).rows).toEqual([ { op: 'add', labelKey: 'day', before: null, after: 'Spare day' }, { op: 'add', labelKey: 'icon', before: null, after: '🧺' }, ]); }); it('ASTPRV-013: people are named, money is in the trip currency, booleans are marks', () => { expect(describe_('create_budget_item', { name: 'Taxi', total_price: 30, member_ids: [7, 8, 9] }).rows).toEqual([ { op: 'add', labelKey: 'price', before: null, after: '€30.00' }, { op: 'add', labelKey: 'members', before: null, after: 'mia, jon, #9' }, ]); expect( describe_('create_todo', { name: 'Book', due_date: '2026-06-01', priority: 1, assigned_user_id: 8 }).rows, ).toEqual([ { op: 'add', labelKey: 'dueDate', before: null, after: 'Mon 1 Jun' }, { op: 'add', labelKey: 'priority', before: null, after: 'P1' }, { op: 'add', labelKey: 'assignee', before: null, after: 'jon' }, ]); expect(describe_('create_packing_item', { name: 'Socks', quantity: 3, checked: true }).rows).toEqual([ { op: 'add', labelKey: 'quantity', before: null, after: '3' }, { op: 'add', labelKey: 'packed', before: null, after: 'āœ“' }, ]); expect(describe_('update_packing_item', { itemId: 51, quantity: 2 }).rows).toEqual([ { op: 'change', labelKey: 'quantity', before: '1', after: '2' }, ]); }); it('ASTPRV-014: a hotel booking names its stay, and long values are cut', () => { const preview = describe_('create_reservation', { title: 'Hotel Gion', type: 'hotel', place_id: 12, start_day_id: 31, end_day_id: 32, reservation_time: '2026-06-11T15:00', notes: 'x'.repeat(400), }); expect(preview.rows).toContainEqual({ op: 'add', labelKey: 'stay', before: null, after: 'Nishiki Market, Thu 11 Jun, Arrival → Fri 12 Jun', }); expect(preview.rows).toContainEqual({ op: 'add', labelKey: 'time', before: null, after: 'Thu 11 Jun, 15:00' }); expect(preview.rows.find((row) => row.labelKey === 'notes')?.after).toHaveLength(160); expect(preview.dayId).toBe(31); }); it('ASTPRV-015: every writing tool has a card, a tool without one of its own a card from its arguments', () => { for (const name of Object.keys(ASSISTANT_WRITE_TOOLS)) { const preview = describe_(name, {}); expect(assistantChangePreviewSchema.safeParse(preview).success, name).toBe(true); expect(preview.verbKey).toBe(ASSISTANT_WRITE_TOOLS[name].verbKey); } const hinted = (destructive: boolean, creates: boolean, group: string | null) => ({ ...ctx, hintOf: () => ({ destructive, creates, group }), }); // The time of a place on a day: the place is the subject, the time a row under its usual label. const time = describeToolCall( 'update_assignment_time', 'tc-7', { assignmentId: 301, place_time: '10:00', end_time: '11:30' }, hinted(false, false, null), ); expect(assistantChangePreviewSchema.safeParse(time).success).toBe(true); expect(time).toMatchObject({ verbKey: 'genericUpdate', subject: 'Nishiki Market', dayId: 31, placeIds: [12] }); expect(time.rows).toEqual([ { op: 'add', labelKey: 'time', before: null, after: '10:00' }, { op: 'add', labelKey: 'endTime', before: null, after: '11:30' }, ]); // A new order reads as the names in that order. const order = describeToolCall('reorder_day_assignments', 'tc-6', { dayId: 31, assignmentIds: [301] }, ctx); expect(order).toMatchObject({ subject: 'Arrival', tool: 'reorder_day_assignments' }); expect(order.rows).toEqual([{ op: 'add', labelKey: 'order', before: null, after: 'Nishiki Market' }]); const gone = describeToolCall('delete_day_note', 'tc-8', { dayId: 31, noteId: 41 }, hinted(true, false, null)); expect(gone).toMatchObject({ verbKey: 'genericRemove', subject: 'Rail pass', dayId: 31 }); expect(gone.rows).toEqual([{ op: 'add', labelKey: 'day', before: null, after: 'Arrival' }]); // A tool of an addon without a card of its own: named by its words, its arguments as rows, its part of TREK. const year = describeToolCall('add_vacay_year', 'tc-9', { year: 2027 }, hinted(false, true, 'vacay')); expect(year).toMatchObject({ verbKey: 'genericCreate', domain: 'vacay', undoable: false }); // A vacation day has a card of its own, even before its lookup ran: the day, in the vacation planner. const vacay = describeToolCall('toggle_vacay_entry', 'tc-10', { date: '2026-07-01', half: true }, ctx); expect(vacay).toMatchObject({ verbKey: 'addVacationDay', subject: 'Wed 1 Jul', domain: 'vacay', undoable: false }); expect(vacay.rows).toEqual([]); // Without hints the name still tells a removal from an addition. expect(describe_('create_collab_poll', { question: 'Where?' }).verbKey).toBe('genericCreate'); expect(describe_('unmark_country_visited', {}).verbKey).toBe('genericRemove'); expect(appliedChange('add_vacay_year', 'tc-9', {}, { years: [2026, 2027] }, null, null)).toMatchObject({ entity: 'other', }); expect(appliedChange('toggle_vacay_entry', 'tc-10', {}, { action: 'added' }, null, null)).toMatchObject({ entity: 'vacay', ids: [], }); }); it('ASTPRV-018: a change to the day plan says what it does to which day; anything else has no effect', () => { expect(describe_('assign_place_to_day', { dayId: 32, placeId: 12 }).effect).toEqual({ kind: 'add', dayId: 32, fromDayId: null, placeId: 12, assignmentId: null, place: null, }); expect(describe_('move_assignment', { assignmentId: 301, newDayId: 32 }).effect).toEqual({ kind: 'move', dayId: 32, fromDayId: 31, placeId: 12, assignmentId: 301, place: null, }); expect(describe_('unassign_place', { dayId: 31, assignmentId: 301 }).effect).toMatchObject({ kind: 'remove', dayId: 31, placeId: 12, assignmentId: 301, }); expect(describe_('unassign_place', { dayId: 33, assignmentId: 999 }).effect).toMatchObject({ kind: 'remove', dayId: 33, placeId: null, }); // A new place without a usable position has no ghost on the map, and a move without a day no effect. expect(describe_('create_and_assign_place', { dayId: 32, name: 'X', lat: 95, lng: 10 }).effect?.place).toBeNull(); expect(describe_('create_and_assign_place', { dayId: 32, name: '', lat: 1, lng: 1 }).effect?.place).toBeNull(); expect(describe_('move_assignment', { assignmentId: 301 }).effect).toBeNull(); expect(describe_('create_place', { name: 'X', lat: 1, lng: 2 }).effect).toBeNull(); expect(describe_('create_day_note', { dayId: 31, text: 'x' }).effect).toBeNull(); }); it('ASTPRV-019: a found place reads as the tool it runs through, verb, rows, undo and effect alike', () => { const created = describe_('add_found_place', { via: 'create_and_assign_place', dayId: 32, name: 'Ginkaku-ji', lat: 35.027, lng: 135.798, }); expect(created).toMatchObject({ verbKey: 'addPlaceToDay', subject: 'Ginkaku-ji', dayId: 32, undoable: true }); expect(created.effect?.place).toMatchObject({ name: 'Ginkaku-ji', lat: 35.027 }); const assigned = describe_('add_found_place', { via: 'assign_place_to_day', dayId: 31, placeId: 12, name: 'x' }); expect(assigned).toMatchObject({ verbKey: 'assignPlace', subject: 'Nishiki Market', placeIds: [12] }); expect(assigned.effect).toMatchObject({ kind: 'add', dayId: 31, placeId: 12 }); expect(() => describe_('add_found_place', { via: 'delete_trip', dayId: 31 })).toThrow(/No change card/); expect( appliedChange('add_found_place', 'tc', { via: 'assign_place_to_day' }, { assignment: { id: 4 } }, 31, null), ).toMatchObject({ entity: 'assignment', ids: [4], dayId: 31 }); }); it('ASTPRV-016: a booking from a file names its route, day, times, reference and price', () => { const preview = describe_('import_booking', { type: 'flight', title: 'LH 716 to Tokyo', reservation_time: '2026-06-11T13:30', reservation_end_time: '2026-06-12T08:05', confirmation_number: 'ABC123', endpoints: [ { role: 'from', sequence: 0, name: 'Frankfurt', code: 'FRA' }, { role: 'to', sequence: 1, name: 'Haneda', code: 'HND' }, ], metadata: { price: 812.5, priceCurrency: 'EUR' }, source: { fileName: 'lh.pdf', index: 0 }, }); expect(assistantChangePreviewSchema.safeParse(preview).success).toBe(true); expect(preview).toMatchObject({ verbKey: 'importBooking', subject: 'LH 716 to Tokyo', dayId: 31, undoable: false }); const after = Object.fromEntries(preview.rows.map((row) => [row.labelKey, row.after])); expect(after).toEqual({ type: 'flight', route: 'Frankfurt (FRA) → Haneda (HND)', day: 'Thu 11 Jun, Arrival', time: 'Thu 11 Jun, 13:30', endTime: 'Fri 12 Jun, 08:05', confirmation: 'ABC123', price: '€812.50', }); }); it('ASTPRV-017: a stay from a file names its nights and venue; a booking off the trip has no day', () => { const stay = describe_('import_booking', { type: 'hotel', title: 'Hotel Gion', _accommodation: { check_in: '2026-06-12', check_out: '2026-06-14', confirmation: 'H-9' }, _venue: { name: 'Hotel Gion', address: 'Gion 1' }, endpoints: [{ role: 'from', sequence: 0, name: 'Gion' }], source: { fileName: 'stay.eml', index: 0 }, }); expect(stay.dayId).toBe(32); const after = Object.fromEntries(stay.rows.map((row) => [row.labelKey, row.after])); expect(after).toMatchObject({ checkIn: 'Fri 12 Jun', checkOut: 'Sun 14 Jun', confirmation: 'H-9' }); expect(after).toMatchObject({ location: 'Hotel Gion', address: 'Gion 1' }); expect(after.route).toBeUndefined(); const elsewhere = describe_('import_booking', { type: 'train', title: 'Shinkansen', reservation_time: '2027-01-01', endpoints: 'odd', metadata: { price: 'free' }, source: { fileName: 't.pdf', index: 0 }, }); expect(elsewhere.dayId).toBeNull(); expect(elsewhere.rows.map((row) => row.labelKey)).toEqual(['type', 'time']); }); it('ASTPRV-022: a changed expense names what it becomes, a kept note is its own subject', () => { const expense = describe_('update_budget_item', { itemId: 31, total_price: 60, member_ids: [7, 8] }); expect(expense).toMatchObject({ verbKey: 'updateBudgetItem', subject: '#31', dayId: null }); expect(expense.rows).toEqual([ { op: 'add', labelKey: 'price', before: null, after: '€60.00' }, { op: 'add', labelKey: 'members', before: null, after: 'mia, jon' }, ]); expect(describe_('update_budget_item', { itemId: 31, name: 'Dinner for two' }).subject).toBe('Dinner for two'); const note = describe_('remember_for_trip', { note: ' We travel as two. ' }); expect(note).toMatchObject({ verbKey: 'rememberNote', subject: 'We travel as two.', rows: [] }); }); it('ASTPRV-023: an attached file is read by its name and where its text goes, kept by what it goes with', () => { const read = describe_('read_attached_file', { attachmentId: 'a', name: 'AirBnB Buchung.pdf', sentTo: 'gpt-5 (api.openai.com)', }); expect(read).toMatchObject({ verbKey: 'readAttachment', subject: 'AirBnB Buchung.pdf', rows: [{ op: 'add', labelKey: 'sentTo', before: null, after: 'gpt-5 (api.openai.com)' }], undoable: false, }); const tripCard = buildTripCard( 1, 7, { reservations: [{ id: 5, title: 'Casa Lisboa' }], budget: { items: [{ id: 12, name: 'Deposit' }] } }, { places: [{ id: 12, name: 'Nishiki Market', lat: 35, lng: 135 }] }, null, ); const kept = describeToolCall( 'keep_attached_file', 'tc-2', { attachmentId: 'a', name: 'AirBnB Buchung.pdf', reservation_id: 5, budget_item_id: 12, place_id: 12, description: 'Stay', }, { ...ctx, card: tripCard }, ); expect(kept).toMatchObject({ verbKey: 'keepFile', subject: 'AirBnB Buchung.pdf', placeIds: [12], undoable: false }); expect(kept.rows).toEqual([ { op: 'add', labelKey: 'attachedTo', before: null, after: 'Casa Lisboa, Deposit, Nishiki Market' }, { op: 'add', labelKey: 'description', before: null, after: 'Stay' }, ]); const unknown = describe_('keep_attached_file', { attachmentId: 'a', name: 'x.pdf', reservation_id: 77, budget_item_id: 78, }); expect(unknown.rows[0]).toMatchObject({ labelKey: 'attachedTo', after: '#77, #78' }); expect(describe_('keep_attached_file', { attachmentId: 'a', name: 'x.pdf' }).rows).toEqual([]); expect(appliedChange('keep_attached_file', 'tc', {}, { file: { id: 31 } }, null, null)).toMatchObject({ entity: 'file', ids: [], }); }); }); describe('appliedChange', () => { it('ASTPRV-020: names what was created from the answer, what was changed from the arguments', () => { expect(appliedChange('create_place', 'tc', {}, { place: { id: 9 } }, null, '2026-06-11T10:15:00Z')).toEqual({ toolCallId: 'tc', entity: 'place', ids: [9], dayId: null, undoUntil: '2026-06-11T10:15:00Z', }); expect(appliedChange('update_day_note', 'tc', { noteId: 41 }, { note: {} }, 31, null)).toMatchObject({ entity: 'day_note', ids: [41], dayId: 31, }); expect(appliedChange('create_todo', 'tc', {}, 'odd', null, null)).toMatchObject({ entity: 'todo', ids: [] }); // A tool without a card of its own leaves a receipt with nothing to show on the map. expect(appliedChange('list_places', 'tc', {}, {}, null, null)).toMatchObject({ entity: 'other', ids: [] }); }); it('ASTPRV-021: a booking from a file is a reservation, on the day its card named or it landed on', () => { const result = { reservation: { id: 5, day_id: 32 } }; expect(appliedChange('import_booking', 'tc', {}, result, null, null)).toEqual({ toolCallId: 'tc', entity: 'reservation', ids: [5], dayId: 32, undoUntil: null, }); expect(appliedChange('import_booking', 'tc', {}, result, 31, null)).toMatchObject({ dayId: 31 }); expect(appliedChange('import_booking', 'tc', {}, { reservation: { id: 5 } }, null, null)).toMatchObject({ dayId: null, }); }); }); describe('the cards of tours', () => { it('ASTPRV-023: a new hike names its route by its points, its grade, its planned time and its words', () => { const preview = describe_('create_hike', { name: 'Herzogstand', description: 'Up from the car park', waypoints: [ { lat: 47.6, lng: 11.3, name: 'Car park' }, { lat: 47.61, lng: 11.3 }, { lat: 47.62, lng: 11.3, name: 'Summit' }, ], round_trip: true, max_hiking_difficulty: 3, planned_duration_minutes: 330, }); expect(assistantChangePreviewSchema.safeParse(preview).success).toBe(true); expect(preview).toMatchObject({ verbKey: 'addTour', subject: 'Herzogstand', undoable: true, placeIds: [] }); expect(preview.rows).toEqual([ { op: 'add', labelKey: 'route', before: null, after: 'Car park → Summit → Car park' }, { op: 'add', labelKey: 'difficulty', before: null, after: 'T3' }, { op: 'add', labelKey: 'time', before: null, after: '5:30 h' }, { op: 'add', labelKey: 'description', before: null, after: 'Up from the car park' }, ]); // Left without a limit, the hike is planned at T2, and the card says so. const plain = describe_('create_hike', { name: 'Walk', waypoints: [ { lat: 1, lng: 1 }, { lat: 2, lng: 2 }, ], }); expect(plain.rows).toEqual([{ op: 'add', labelKey: 'difficulty', before: null, after: 'T2' }]); expect( describe_('create_hike', { name: 'Odd', max_hiking_difficulty: 9, planned_duration_minutes: -5 }).rows, ).toEqual([]); }); it('ASTPRV-024: a new city walk names its stations, a linked one by its place, and points at the places it uses', () => { const preview = describe_('create_city_walk', { name: 'Market morning', stations: [ { lat: 35, lng: 135, name: 'Hotel' }, { lat: 35.01, lng: 135, linked_place_id: 12 }, { lat: 35.02, lng: 135, linked_place_id: 99 }, 'odd', ], }); expect(preview).toMatchObject({ verbKey: 'addTour', subject: 'Market morning', undoable: true, placeIds: [12] }); expect(preview.rows).toEqual([{ op: 'add', labelKey: 'route', before: null, after: 'Hotel → Nishiki Market' }]); }); it('ASTPRV-025: a changed hike is named by its place and shows what it becomes', () => { const preview = describe_('update_tour', { placeId: 12, expected_revision: 2, name: 'Market loop', description: null, waypoints: [ { lat: 35, lng: 135, name: 'Gate' }, { lat: 35.01, lng: 135, name: 'Shrine' }, ], max_hiking_difficulty: 2, planned_duration_minutes: 90, }); expect(preview).toMatchObject({ verbKey: 'updateTour', subject: 'Nishiki Market', undoable: false, placeIds: [12], }); expect(preview.rows).toEqual([ { op: 'change', labelKey: 'name', before: 'Nishiki Market', after: 'Market loop' }, { op: 'change', labelKey: 'description', before: null, after: '' }, { op: 'add', labelKey: 'route', before: null, after: 'Gate → Shrine' }, { op: 'add', labelKey: 'difficulty', before: null, after: 'T2' }, { op: 'add', labelKey: 'time', before: null, after: '1:30 h' }, ]); expect(describe_('update_tour', { placeId: 77, name: 'Gone' })).toMatchObject({ subject: 'Gone', placeIds: [77] }); expect(describe_('update_tour', {})).toMatchObject({ subject: '', rows: [], placeIds: [] }); }); it('ASTPRV-026: tours from a file are named by the file, else by the first name in it', () => { const gpx = 'Ridge walk'; expect(describe_('import_tour_gpx', { gpx, file_name: 'ridge.gpx', tour_type: 'bike' })).toMatchObject({ verbKey: 'importTour', subject: 'ridge.gpx', rows: [{ op: 'add', labelKey: 'type', before: null, after: 'bike' }], // A file of one track can be taken back once it is in; the receipt says whether this one was. undoable: true, }); expect(describe_('import_tour_gpx', { gpx }).subject).toBe('Ridge walk'); expect(describe_('import_tour_gpx', { gpx: 'Open' }).subject).toBe('GPX'); expect(describe_('import_tour_gpx', { gpx: '' }).subject).toBe('GPX'); }); it('ASTPRV-027: a tour is named by its place in the receipt, every tour a file brought in too', () => { expect(appliedChange('create_hike', 'tc', {}, { tour: { place_id: 61 }, waypoints: [] }, null, null)).toEqual({ toolCallId: 'tc', entity: 'tour', ids: [61], dayId: null, undoUntil: null, }); expect(appliedChange('update_tour', 'tc', { placeId: 61 }, { tour: { place_id: 61 } }, null, null)).toMatchObject({ entity: 'tour', ids: [61], }); expect( appliedChange( 'import_tour_gpx', 'tc', {}, { tours: [{ place_id: 62 }, { place_id: 63 }, {}], skipped: 0 }, null, null, ), ).toMatchObject({ entity: 'tour', ids: [62, 63] }); expect(appliedChange('import_tour_gpx', 'tc', {}, { tours: [], skipped: 1 }, null, null)).toMatchObject({ ids: [], }); }); /** * Lends a tool package cards for one case, the way a package's index adds * them, and takes them back after it. */ function withCards(tool: string, cards: ToolCards, write: AssistantWriteTool | null, run: () => T): T { const tools = TOOL_CARDS as Record; const writes = ASSISTANT_WRITE_TOOLS as Record; const [before, writeBefore] = [tools[tool], writes[tool]]; tools[tool] = { ...before, ...cards }; if (write) writes[tool] = write; try { return run(); } finally { if (before) tools[tool] = before; else Reflect.deleteProperty(tools, tool); if (writeBefore) writes[tool] = writeBefore; else Reflect.deleteProperty(writes, tool); } } it("ASTPRV-028: a package's describer speaks for its tool with its lookup, its overrides and its effect", () => { const cards: ToolCards = { describe: (_ctx, args, loaded) => ({ subject: `${String(args.name)} (${loaded ?? 'none'})`, rows: new Rows().add('day', 'Fri'), dayId: 32, placeIds: [], verbKey: 'genericUpdate', tool: 'plan_vacay_days', domain: 'vacay', }), effect: (_ctx, _args, loaded) => loaded ? { kind: 'add', dayId: 32, fromDayId: null, placeId: 12, assignmentId: null, place: null } : null, }; const preview = withCards('plan_vacay_days', cards, { verbKey: 'genericCreate', entity: 'other' }, () => describeToolCall('plan_vacay_days', 'tc-30', { name: 'Summer' }, ctx, 'plan'), ); expect(preview).toMatchObject({ verbKey: 'genericUpdate', subject: 'Summer (plan)', tool: 'plan_vacay_days', domain: 'vacay', dayId: 32, undoable: false, effect: { kind: 'add', dayId: 32, placeId: 12 }, }); expect(assistantChangePreviewSchema.safeParse(preview).success).toBe(true); }); it('ASTPRV-029: a change card rides on a curated and on a generic card; one its kind refuses stays out', () => { const built = { kind: 'tourRoute' } as TrekCard; const drawn = trekCardSchema.safeParse(built).success ? { card: built } : {}; const curated = withCards('create_place', { change: () => built }, null, () => describe_('create_place', { name: 'Kinkaku-ji' }), ); expect(curated).toMatchObject({ verbKey: 'addPlace', subject: 'Kinkaku-ji', ...drawn }); const generic = withCards('set_vacay_days', { change: () => built }, null, () => describe_('set_vacay_days', { days: 3 }), ); expect(generic).toMatchObject({ tool: 'set_vacay_days', ...drawn }); const refused = withCards( 'set_vacay_days', { change: () => ({ kind: 'bookPage' }) as unknown as TrekCard }, null, () => describe_('set_vacay_days', { days: 3 }), ); expect(refused).not.toHaveProperty('card'); expect(describe_('create_place', { name: 'Kinkaku-ji' })).not.toHaveProperty('card'); }); it("ASTPRV-030: a package's applied ids name the receipt before the answer's usual keys", () => { const applied = withCards('create_place', { appliedIds: (_args, result) => [Number(result)] }, null, () => appliedChange('create_place', 'tc', {}, 77, null, null), ); expect(applied).toMatchObject({ entity: 'place', ids: [77] }); expect(appliedChange('create_place', 'tc', {}, { place: { id: 5 } }, null, null)).toMatchObject({ ids: [5] }); // The hook reads what the receipt is made with: the stored preview and the trip of the chat, or none of them. const preview = describe_('create_place', { name: 'Kinkaku-ji' }); const seen: unknown[] = []; const hook = (_args: unknown, _result: unknown, from: unknown): number[] => { seen.push(from); return []; }; withCards('create_place', { appliedIds: hook }, null, () => { appliedChange('create_place', 'tc', {}, {}, null, null, { preview, tripId: 1 }); return appliedChange('create_place', 'tc', {}, {}, null, null); }); expect(seen).toEqual([ { preview, tripId: 1 }, { preview: null, tripId: null }, ]); }); it('ASTPRV-031: a package names its ids first; a place id of a tool outside the trip is no trip place', () => { const hinted = (group: string) => ({ ...ctx, hintOf: () => ({ destructive: false, creates: true, group }) }); const add = (group: string) => describeToolCall('add_collection_place', 'tc-31', { placeId: 12 }, hinted(group)); // Place 12 is the trip's Nishiki Market for a tool of a group whose ids are the trip's. expect(FOREIGN_ID_GROUPS.has('tours')).toBe(false); expect(add('tours')).toMatchObject({ subject: 'Nishiki Market', placeIds: [12], domain: 'tours' }); // The collections say their place ids are their own. expect(FOREIGN_ID_GROUPS.has('collections')).toBe(true); const outside = add('collections'); expect(outside).toMatchObject({ subject: 'add collection place', placeIds: [] }); expect(outside.rows).toEqual([{ op: 'add', labelKey: 'field', field: 'placeId', before: null, after: '12' }]); const named = withCards( 'add_collection_place', { nameArg: (key, value) => (key === 'placeId' ? `Saved place ${value}` : null) }, null, () => add('collections'), ); expect(named).toMatchObject({ subject: 'Saved place 12', rows: [], placeIds: [] }); }); });