/** * Unit tests for MCP vacay tools (vacay addon-gated, VacayMcp — DI-discovered * via the hand-built test registry in tests/helpers/mcp-test-controllers.ts): * get_vacay_plan, update_vacay_plan, set_vacay_color, * list_vacay_years, add_vacay_year, delete_vacay_year, * get_vacay_entries, toggle_vacay_entry, toggle_company_holiday, * get_vacay_stats, update_vacay_stats, * add_holiday_calendar, update_holiday_calendar, delete_holiday_calendar, * list_holiday_countries, list_holidays. * Resources: trek://vacay/plan, trek://vacay/entries/{year}, * trek://vacay/holidays/{year} — these ride the registry too (attached inside * registerTools), so `withTools` must stay on even for resource reads. */ import { describe, it, expect, vi, beforeAll, beforeEach, afterAll } from 'vitest'; const { testDb, dbMock } = vi.hoisted(() => { const Database = require('better-sqlite3'); const db = new Database(':memory:'); db.exec('PRAGMA journal_mode = WAL'); db.exec('PRAGMA foreign_keys = ON'); db.exec('PRAGMA busy_timeout = 5000'); const mock = { db, closeDb: () => {}, reinitialize: () => {}, getPlaceWithTags: () => null, canAccessTrip: (tripId: any, userId: number) => db.prepare(`SELECT t.id, t.user_id FROM trips t LEFT JOIN trip_members m ON m.trip_id = t.id AND m.user_id = ? WHERE t.id = ? AND (t.user_id = ? OR m.user_id IS NOT NULL)`).get(userId, tripId, userId), isOwner: (tripId: any, userId: number) => !!db.prepare('SELECT id FROM trips WHERE id = ? AND user_id = ?').get(tripId, userId), }; return { testDb: db, dbMock: mock }; }); vi.mock('../../../src/db/database', () => dbMock); vi.mock('../../../src/config', () => ({ JWT_SECRET: 'test-jwt-secret-for-trek-testing-only', ENCRYPTION_KEY: 'a1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2', updateJwtSecret: () => {}, })); const { broadcastMock } = vi.hoisted(() => ({ broadcastMock: vi.fn() })); vi.mock('../../../src/websocket', () => ({ broadcast: broadcastMock })); // share_vacay_calendar fires a user notification after inserting; stub it out vi.mock('../../../src/nest/notifications/notifications.bridge', () => ({ send: vi.fn().mockResolvedValue(undefined) })); import { createTables } from '../../../src/db/schema'; import { runMigrations } from '../../../src/db/migrations'; import { resetTestDb } from '../../helpers/test-db'; import { createUser } from '../../helpers/factories'; import { setAddonEnabled } from '../../helpers/test-db'; import { ADDON_IDS } from '../../../src/addons'; import { createMcpHarness, parseToolResult, parseResourceResult, type McpHarness } from '../../helpers/mcp-harness'; import { VacayService } from '../../../src/nest/vacay/vacay.service'; // Stub the async methods that make external calls (VacayService is DI-native; // the registry constructs a real instance, so spy on the prototype — the // successor of the legacy path-level partial mock of services/vacayService). vi.spyOn(VacayService.prototype, 'updatePlan').mockResolvedValue({ plan: { id: 1, block_weekends: true, holidays_enabled: false, company_holidays_enabled: false, carry_over_enabled: false, holiday_calendars: [] }, } as never); vi.spyOn(VacayService.prototype, 'getCountries').mockResolvedValue({ data: [{ code: 'US', name: 'United States' }] }); vi.spyOn(VacayService.prototype, 'getHolidays').mockResolvedValue({ data: [{ date: '2025-01-01', name: 'New Year' }] }); beforeAll(() => { createTables(testDb); runMigrations(testDb); }); beforeEach(() => { resetTestDb(testDb); // The `when:` gate reads the injected AddonsService, so the toggle is the row // the admin panel writes — and this addon ships disabled by default. setAddonEnabled(testDb, ADDON_IDS.VACAY, true); broadcastMock.mockClear(); delete process.env.DEMO_MODE; }); afterAll(() => { testDb.close(); }); async function withHarness(userId: number, fn: (h: McpHarness) => Promise) { const h = await createMcpHarness({ userId, withResources: false }); try { await fn(h); } finally { await h.cleanup(); } } async function withResourceHarness(userId: number, fn: (h: McpHarness) => Promise) { const h = await createMcpHarness({ userId, withResources: true }); try { await fn(h); } finally { await h.cleanup(); } } // --------------------------------------------------------------------------- // get_vacay_plan // --------------------------------------------------------------------------- describe('Tool: get_vacay_plan', () => { it('returns plan data object', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'get_vacay_plan', arguments: {} }); const data = parseToolResult(result) as any; expect(data.plan).toBeDefined(); }); }); }); // --------------------------------------------------------------------------- // update_vacay_plan // --------------------------------------------------------------------------- describe('Tool: update_vacay_plan', () => { it('calls updatePlan and returns the hydrated plan', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'update_vacay_plan', arguments: { block_weekends: true, holidays_enabled: false }, }); const data = parseToolResult(result) as any; // Now returns the fully-hydrated plan (matching get_vacay_plan), not { success }. expect(data.plan).toBeDefined(); expect(data.plan.block_weekends).toBe(true); expect(data.plan.holidays_enabled).toBe(false); expect(Array.isArray(data.plan.holiday_calendars)).toBe(true); }); }); it('blocks demo user', async () => { process.env.DEMO_MODE = 'true'; const { user } = createUser(testDb, { email: 'demo@nomad.app' }); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'update_vacay_plan', arguments: { block_weekends: true } }); expect(result.isError).toBe(true); }); }); }); // --------------------------------------------------------------------------- // set_vacay_color // --------------------------------------------------------------------------- describe('Tool: set_vacay_color', () => { it('updates color and returns success', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'set_vacay_color', arguments: { color: '#ff0000' } }); const data = parseToolResult(result) as any; expect(data.success).toBe(true); expect(data.color).toBe('#ff0000'); // echoes the persisted color }); }); it('blocks demo user', async () => { process.env.DEMO_MODE = 'true'; const { user } = createUser(testDb, { email: 'demo@nomad.app' }); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'set_vacay_color', arguments: { color: '#ff0000' } }); expect(result.isError).toBe(true); }); }); }); // --------------------------------------------------------------------------- // list_vacay_years // --------------------------------------------------------------------------- describe('Tool: list_vacay_years', () => { it('returns years array', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'list_vacay_years', arguments: {} }); const data = parseToolResult(result) as any; expect(Array.isArray(data.years)).toBe(true); }); }); }); // --------------------------------------------------------------------------- // add_vacay_year // --------------------------------------------------------------------------- describe('Tool: add_vacay_year', () => { it('adds year to list', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'add_vacay_year', arguments: { year: 2025 } }); const data = parseToolResult(result) as any; expect(Array.isArray(data.years)).toBe(true); expect(data.years).toContain(2025); }); }); it('blocks demo user', async () => { process.env.DEMO_MODE = 'true'; const { user } = createUser(testDb, { email: 'demo@nomad.app' }); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'add_vacay_year', arguments: { year: 2025 } }); expect(result.isError).toBe(true); }); }); }); // --------------------------------------------------------------------------- // delete_vacay_year // --------------------------------------------------------------------------- describe('Tool: delete_vacay_year', () => { it('removes year from list', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { // Add year first await h.client.callTool({ name: 'add_vacay_year', arguments: { year: 2025 } }); const result = await h.client.callTool({ name: 'delete_vacay_year', arguments: { year: 2025 } }); const data = parseToolResult(result) as any; expect(Array.isArray(data.years)).toBe(true); expect(data.years).not.toContain(2025); }); }); it('blocks demo user', async () => { process.env.DEMO_MODE = 'true'; const { user } = createUser(testDb, { email: 'demo@nomad.app' }); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'delete_vacay_year', arguments: { year: 2025 } }); expect(result.isError).toBe(true); }); }); }); // --------------------------------------------------------------------------- // get_vacay_entries // --------------------------------------------------------------------------- describe('Tool: get_vacay_entries', () => { it('returns entries array (empty initially)', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'get_vacay_entries', arguments: { year: 2025 } }); const data = parseToolResult(result) as any; expect(data.entries).toBeDefined(); expect(Array.isArray(data.entries.entries)).toBe(true); }); }); }); // --------------------------------------------------------------------------- // toggle_vacay_entry // --------------------------------------------------------------------------- describe('Tool: toggle_vacay_entry', () => { it('toggles entry and returns action', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'toggle_vacay_entry', arguments: { date: '2025-06-15' } }); const data = parseToolResult(result) as any; expect(data.action).toBeDefined(); }); }); it('blocks demo user', async () => { process.env.DEMO_MODE = 'true'; const { user } = createUser(testDb, { email: 'demo@nomad.app' }); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'toggle_vacay_entry', arguments: { date: '2025-06-15' } }); expect(result.isError).toBe(true); }); }); }); // --------------------------------------------------------------------------- // toggle_company_holiday // --------------------------------------------------------------------------- describe('Tool: toggle_company_holiday', () => { it('toggles company holiday and returns action', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'toggle_company_holiday', arguments: { date: '2025-12-25', note: 'Christmas' }, }); const data = parseToolResult(result) as any; expect(data.action).toBeDefined(); }); }); it('blocks demo user', async () => { process.env.DEMO_MODE = 'true'; const { user } = createUser(testDb, { email: 'demo@nomad.app' }); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'toggle_company_holiday', arguments: { date: '2025-12-25' } }); expect(result.isError).toBe(true); }); }); }); // --------------------------------------------------------------------------- // get_vacay_stats // --------------------------------------------------------------------------- describe('Tool: get_vacay_stats', () => { it('returns stats object', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'get_vacay_stats', arguments: { year: 2025 } }); const data = parseToolResult(result) as any; expect(data.stats).toBeDefined(); }); }); }); // --------------------------------------------------------------------------- // update_vacay_stats // --------------------------------------------------------------------------- describe('Tool: update_vacay_stats', () => { it('updates vacation days allowance and returns success', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'update_vacay_stats', arguments: { year: 2025, vacationDays: 25 } }); const data = parseToolResult(result) as any; expect(data.success).toBe(true); }); }); it('blocks demo user', async () => { process.env.DEMO_MODE = 'true'; const { user } = createUser(testDb, { email: 'demo@nomad.app' }); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'update_vacay_stats', arguments: { year: 2025, vacationDays: 20 } }); expect(result.isError).toBe(true); }); }); }); // --------------------------------------------------------------------------- // add_holiday_calendar // --------------------------------------------------------------------------- describe('Tool: add_holiday_calendar', () => { it('inserts calendar row and returns calendar', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'add_holiday_calendar', arguments: { region: 'US', label: 'US Holidays', color: '#ff0000' }, }); const data = parseToolResult(result) as any; expect(data.calendar).toBeDefined(); expect(data.calendar.region).toBe('US'); }); }); it('blocks demo user', async () => { process.env.DEMO_MODE = 'true'; const { user } = createUser(testDb, { email: 'demo@nomad.app' }); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'add_holiday_calendar', arguments: { region: 'US' } }); expect(result.isError).toBe(true); }); }); }); // --------------------------------------------------------------------------- // update_holiday_calendar // --------------------------------------------------------------------------- describe('Tool: update_holiday_calendar', () => { it('updates label and color', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { // First add a calendar const addResult = await h.client.callTool({ name: 'add_holiday_calendar', arguments: { region: 'DE', label: 'Germany' }, }); const added = parseToolResult(addResult) as any; const calId = added.calendar.id; const result = await h.client.callTool({ name: 'update_holiday_calendar', arguments: { calendarId: calId, label: 'German Holidays', color: '#00ff00' }, }); const data = parseToolResult(result) as any; expect(data.calendar).toBeDefined(); expect(data.calendar.label).toBe('German Holidays'); }); }); it('blocks demo user', async () => { process.env.DEMO_MODE = 'true'; const { user } = createUser(testDb, { email: 'demo@nomad.app' }); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'update_holiday_calendar', arguments: { calendarId: 1, label: 'X' } }); expect(result.isError).toBe(true); }); }); }); // --------------------------------------------------------------------------- // delete_holiday_calendar // --------------------------------------------------------------------------- describe('Tool: delete_holiday_calendar', () => { it('removes calendar and returns success', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const addResult = await h.client.callTool({ name: 'add_holiday_calendar', arguments: { region: 'FR' }, }); const added = parseToolResult(addResult) as any; const calId = added.calendar.id; const result = await h.client.callTool({ name: 'delete_holiday_calendar', arguments: { calendarId: calId } }); const data = parseToolResult(result) as any; expect(data.success).toBe(true); }); }); it('blocks demo user', async () => { process.env.DEMO_MODE = 'true'; const { user } = createUser(testDb, { email: 'demo@nomad.app' }); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'delete_holiday_calendar', arguments: { calendarId: 1 } }); expect(result.isError).toBe(true); }); }); }); // --------------------------------------------------------------------------- // list_holiday_countries // --------------------------------------------------------------------------- describe('Tool: list_holiday_countries', () => { it('returns countries from mocked service', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'list_holiday_countries', arguments: {} }); const data = parseToolResult(result) as any; expect(data.countries).toBeDefined(); }); }); }); // --------------------------------------------------------------------------- // list_holidays // --------------------------------------------------------------------------- describe('Tool: list_holidays', () => { it('returns holidays from mocked service', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'list_holidays', arguments: { country: 'US', year: 2025 } }); const data = parseToolResult(result) as any; expect(data.holidays).toBeDefined(); }); }); }); // --------------------------------------------------------------------------- // list_vacay_shares // --------------------------------------------------------------------------- describe('Tool: list_vacay_shares', () => { it('returns outgoing and incoming shares', async () => { const { user } = createUser(testDb); const { user: other } = createUser(testDb); await withHarness(user.id, async (h) => { await h.client.callTool({ name: 'share_vacay_calendar', arguments: { targetUserId: other.id } }); const result = await h.client.callTool({ name: 'list_vacay_shares', arguments: {} }); const data = parseToolResult(result) as any; expect(Array.isArray(data.outgoing)).toBe(true); expect(Array.isArray(data.incoming)).toBe(true); expect(data.outgoing).toHaveLength(1); expect(data.outgoing[0].user_id).toBe(other.id); }); }); }); // --------------------------------------------------------------------------- // share_vacay_calendar // --------------------------------------------------------------------------- describe('Tool: share_vacay_calendar', () => { it('creates a share and returns success', async () => { const { user } = createUser(testDb); const { user: other } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'share_vacay_calendar', arguments: { targetUserId: other.id } }); const data = parseToolResult(result) as any; expect(data.success).toBe(true); const row = testDb.prepare('SELECT id FROM vacay_shares WHERE owner_id = ? AND user_id = ?').get(user.id, other.id); expect(row).toBeDefined(); }); }); it('errors when sharing with yourself', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'share_vacay_calendar', arguments: { targetUserId: user.id } }); expect(result.isError).toBe(true); }); }); it('blocks demo user', async () => { process.env.DEMO_MODE = 'true'; const { user } = createUser(testDb, { email: 'demo@nomad.app' }); const { user: other } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'share_vacay_calendar', arguments: { targetUserId: other.id } }); expect(result.isError).toBe(true); }); }); }); // --------------------------------------------------------------------------- // unshare_vacay_calendar // --------------------------------------------------------------------------- describe('Tool: unshare_vacay_calendar', () => { it('removes an existing share and returns success', async () => { const { user } = createUser(testDb); const { user: other } = createUser(testDb); await withHarness(user.id, async (h) => { await h.client.callTool({ name: 'share_vacay_calendar', arguments: { targetUserId: other.id } }); const shareId = (testDb.prepare('SELECT id FROM vacay_shares WHERE owner_id = ?').get(user.id) as any).id; const result = await h.client.callTool({ name: 'unshare_vacay_calendar', arguments: { shareId } }); const data = parseToolResult(result) as any; expect(data.success).toBe(true); expect(testDb.prepare('SELECT id FROM vacay_shares WHERE id = ?').get(shareId)).toBeUndefined(); }); }); it('errors when the share does not exist', async () => { const { user } = createUser(testDb); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'unshare_vacay_calendar', arguments: { shareId: 99999 } }); expect(result.isError).toBe(true); }); }); it('blocks demo user', async () => { process.env.DEMO_MODE = 'true'; const { user } = createUser(testDb, { email: 'demo@nomad.app' }); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'unshare_vacay_calendar', arguments: { shareId: 1 } }); expect(result.isError).toBe(true); }); }); }); // --------------------------------------------------------------------------- // get_shared_vacay_calendars // --------------------------------------------------------------------------- describe('Tool: get_shared_vacay_calendars', () => { it('returns the sharer entries for the viewer', async () => { const { user: owner } = createUser(testDb); const { user: viewer } = createUser(testDb); await withHarness(owner.id, async (h) => { await h.client.callTool({ name: 'toggle_vacay_entry', arguments: { date: '2025-06-15' } }); await h.client.callTool({ name: 'share_vacay_calendar', arguments: { targetUserId: viewer.id } }); }); await withHarness(viewer.id, async (h) => { const result = await h.client.callTool({ name: 'get_shared_vacay_calendars', arguments: { year: 2025 } }); const data = parseToolResult(result) as any; expect(Array.isArray(data.calendars)).toBe(true); expect(data.calendars).toHaveLength(1); expect(data.calendars[0].owner_id).toBe(owner.id); expect(data.calendars[0].entries.map((e: any) => e.date)).toContain('2025-06-15'); }); }); }); // --------------------------------------------------------------------------- // Resources // --------------------------------------------------------------------------- describe('Resource: trek://vacay/plan', () => { it('returns plan data', async () => { const { user } = createUser(testDb); await withResourceHarness(user.id, async (h) => { const result = await h.client.readResource({ uri: 'trek://vacay/plan' }); const data = parseResourceResult(result) as any; expect(data).toBeDefined(); }); }); }); describe('Resource: trek://vacay/entries/{year}', () => { it('returns entries for a year', async () => { const { user } = createUser(testDb); await withResourceHarness(user.id, async (h) => { const result = await h.client.readResource({ uri: 'trek://vacay/entries/2025' }); const data = parseResourceResult(result) as any; expect(data).toBeDefined(); expect(Array.isArray(data.entries)).toBe(true); }); }); }); describe('Resource: trek://vacay/holidays/{year}', () => { it('returns [] while public holidays are disabled or no region is set', async () => { const { user } = createUser(testDb); await withResourceHarness(user.id, async (h) => { const result = await h.client.readResource({ uri: 'trek://vacay/holidays/2025' }); const data = parseResourceResult(result) as unknown[]; expect(data).toEqual([]); }); }); }); // --------------------------------------------------------------------------- // decline_vacay_invite (demo guard added by the vacay quirk-fix commit — the // legacy registrar was the only vacay write without it) // --------------------------------------------------------------------------- describe('Tool: decline_vacay_invite', () => { it('declines a pending invite', async () => { const { user: owner } = createUser(testDb); const { user: invitee } = createUser(testDb); await withHarness(owner.id, async (h) => { await h.client.callTool({ name: 'send_vacay_invite', arguments: { targetUserId: invitee.id } }); }); await withHarness(invitee.id, async (h) => { const result = await h.client.callTool({ name: 'decline_vacay_invite', arguments: { planId: testDb.prepare('SELECT plan_id FROM vacay_plan_members WHERE user_id = ?').get(invitee.id)!.plan_id } }); const data = parseToolResult(result) as any; expect(data.success).toBe(true); }); }); it('blocks demo user', async () => { process.env.DEMO_MODE = 'true'; const { user } = createUser(testDb, { email: 'demo@nomad.app' }); await withHarness(user.id, async (h) => { const result = await h.client.callTool({ name: 'decline_vacay_invite', arguments: { planId: 1 } }); expect(result.isError).toBe(true); }); }); });