/** * Backup integration tests. * Covers BACKUP-001 to BACKUP-008. * * Note: createBackup() is async and creates real files. * These tests run in test env and may not have a full DB file to zip, * but the service should handle gracefully. */ import { describe, it, expect, vi, beforeAll, beforeEach, afterAll } from 'vitest'; import request from 'supertest'; import type { Application } from 'express'; import type { INestApplication } from '@nestjs/common'; const { testDb, dbMock } = vi.hoisted(() => { const Database = require('better-sqlite3'); const db = new Database(':memory:'); db.exec('PRAGMA journal_mode = WAL'); db.exec('PRAGMA foreign_keys = ON'); db.exec('PRAGMA busy_timeout = 5000'); const mock = { db, closeDb: () => {}, reinitialize: () => {}, getPlaceWithTags: (placeId: number) => { const place: any = db.prepare(`SELECT p.*, c.name as category_name, c.color as category_color, c.icon as category_icon FROM places p LEFT JOIN categories c ON p.category_id = c.id WHERE p.id = ?`).get(placeId); if (!place) return null; const tags = db.prepare(`SELECT t.* FROM tags t JOIN place_tags pt ON t.id = pt.tag_id WHERE pt.place_id = ?`).all(placeId); return { ...place, category: place.category_id ? { id: place.category_id, name: place.category_name, color: place.category_color, icon: place.category_icon } : null, tags }; }, canAccessTrip: (tripId: any, userId: number) => db.prepare(`SELECT t.id, t.user_id FROM trips t LEFT JOIN trip_members m ON m.trip_id = t.id AND m.user_id = ? WHERE t.id = ? AND (t.user_id = ? OR m.user_id IS NOT NULL)`).get(userId, tripId, userId), isOwner: (tripId: any, userId: number) => !!db.prepare('SELECT id FROM trips WHERE id = ? AND user_id = ?').get(tripId, userId), }; return { testDb: db, dbMock: mock }; }); vi.mock('../../src/db/database', () => dbMock); vi.mock('../../src/config', () => ({ JWT_SECRET: 'test-jwt-secret-for-trek-testing-only', ENCRYPTION_KEY: 'a1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2', updateJwtSecret: () => {}, SESSION_DURATION: '24h', SESSION_DURATION_MS: 86400000, SESSION_DURATION_SECONDS: 86400, DEFAULT_LANGUAGE: 'en', })); vi.mock('../../src/websocket', () => ({ broadcast: vi.fn(), broadcastToUser: vi.fn() })); // Mock filesystem-dependent service functions to avoid real disk I/O in tests vi.mock('../../src/services/backupService', async () => { const actual = await vi.importActual('../../src/services/backupService'); return { ...actual, createBackup: vi.fn().mockResolvedValue({ filename: 'backup-2026-04-03T06-00-00.zip', size: 1024, sizeText: '1.0 KB', created_at: new Date().toISOString(), }), updateAutoSettings: vi.fn().mockReturnValue({ enabled: false, interval: 'daily', keep_days: 7, hour: 2, day_of_week: 0, day_of_month: 1, }), restoreFromZip: vi.fn().mockResolvedValue({ success: true }), deleteBackup: vi.fn().mockReturnValue(undefined), backupFileExists: vi.fn().mockReturnValue(false), backupFilePath: vi.fn().mockReturnValue('/tmp/test-backup.zip'), // Keep checkRateLimit from actual so rate-limit tests work correctly checkRateLimit: vi.fn().mockReturnValue(true), }; }); import { buildApp } from '../../src/bootstrap'; import { createTables } from '../../src/db/schema'; import { runMigrations } from '../../src/db/migrations'; import { resetTestDb, resetRateLimits } from '../helpers/test-db'; import { createAdmin, createUser } from '../helpers/factories'; import { authCookie } from '../helpers/auth'; import * as backupService from '../../src/services/backupService'; import fs from 'fs'; import path from 'path'; import os from 'os'; let nestApp: INestApplication; let app: Application; beforeAll(async () => { createTables(testDb); runMigrations(testDb); nestApp = await buildApp(); app = nestApp.getHttpAdapter().getInstance(); }); beforeEach(() => { resetTestDb(testDb); resetRateLimits(nestApp); }); afterAll(async () => { await nestApp.close(); testDb.close(); }); describe('Backup access control', () => { it('non-admin cannot access backup routes', async () => { const { user } = createUser(testDb); const res = await request(app) .get('/api/backup/list') .set('Cookie', authCookie(user.id)); expect(res.status).toBe(403); }); }); describe('Backup list', () => { it('BACKUP-001 — GET /backup/list returns backups array', async () => { const { user: admin } = createAdmin(testDb); const res = await request(app) .get('/api/backup/list') .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(200); expect(Array.isArray(res.body.backups)).toBe(true); }); }); describe('Backup creation', () => { it('BACKUP-001 — POST /backup/create creates a backup', async () => { const { user: admin } = createAdmin(testDb); const res = await request(app) .post('/api/backup/create') .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(200); expect(res.body.success).toBe(true); expect(res.body.backup).toHaveProperty('filename'); expect(res.body.backup).toHaveProperty('size'); }); }); describe('Auto-backup settings', () => { it('BACKUP-008 — GET /backup/auto-settings returns current config', async () => { const { user: admin } = createAdmin(testDb); const res = await request(app) .get('/api/backup/auto-settings') .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(200); expect(res.body).toHaveProperty('settings'); expect(res.body.settings).toHaveProperty('enabled'); }); it('BACKUP-008 — PUT /backup/auto-settings updates settings', async () => { const { user: admin } = createAdmin(testDb); const res = await request(app) .put('/api/backup/auto-settings') .set('Cookie', authCookie(admin.id)) .send({ enabled: false, interval: 'daily', keep_days: 7 }); expect(res.status).toBe(200); expect(res.body).toHaveProperty('settings'); expect(res.body.settings).toHaveProperty('enabled'); expect(res.body.settings).toHaveProperty('interval'); }); }); describe('Backup security', () => { it('BACKUP-007 — Download with path traversal filename is rejected', async () => { const { user: admin } = createAdmin(testDb); const res = await request(app) .get('/api/backup/download/../../etc/passwd') .set('Cookie', authCookie(admin.id)); // Express normalises the URL before routing; path traversal gets resolved // to a path that matches no route → 404 expect(res.status).toBe(404); }); it('BACKUP-007 — Delete with path traversal filename is rejected', async () => { const { user: admin } = createAdmin(testDb); const res = await request(app) .delete('/api/backup/../../../etc/passwd') .set('Cookie', authCookie(admin.id)); // Express normalises the URL, stripping traversal → no route match → 404 expect(res.status).toBe(404); }); }); // --------------------------------------------------------------------------- // Download // --------------------------------------------------------------------------- describe('Backup download', () => { let tmpFile: string; beforeEach(() => { // Create a real temporary file that Express can stream back tmpFile = path.join(os.tmpdir(), `test-backup-${Date.now()}.zip`); fs.writeFileSync(tmpFile, 'fake zip content'); vi.mocked(backupService.backupFileExists).mockReturnValue(true); vi.mocked(backupService.backupFilePath).mockReturnValue(tmpFile); }); afterAll(() => { try { fs.unlinkSync(tmpFile); } catch {} }); it('BACKUP-INT-001 — GET /backup/download/:filename returns 200 with content-disposition', async () => { const { user: admin } = createAdmin(testDb); const filename = 'backup-2026-04-06T12-00-00.zip'; const res = await request(app) .get(`/api/backup/download/${filename}`) .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(200); expect(res.headers['content-disposition']).toMatch(/attachment/i); expect(res.headers['content-disposition']).toContain(filename); }); it('BACKUP-INT-002 — GET /backup/download/:filename returns 400 for invalid filename', async () => { const { user: admin } = createAdmin(testDb); vi.mocked(backupService.backupFileExists).mockReturnValue(false); const res = await request(app) .get('/api/backup/download/not-a-valid-name.tar.gz') .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(400); expect(res.body.error).toMatch(/invalid filename/i); }); it('BACKUP-INT-003 — GET /backup/download/:filename returns 404 when file not found', async () => { const { user: admin } = createAdmin(testDb); vi.mocked(backupService.backupFileExists).mockReturnValue(false); const res = await request(app) .get('/api/backup/download/backup-2026-04-06T12-00-00.zip') .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(404); expect(res.body.error).toMatch(/not found/i); }); }); // --------------------------------------------------------------------------- // Restore from existing backup // --------------------------------------------------------------------------- describe('Backup restore', () => { it('BACKUP-INT-004 — POST /backup/restore/:filename returns 200 on success', async () => { const { user: admin } = createAdmin(testDb); const filename = 'backup-2026-04-06T12-00-00.zip'; vi.mocked(backupService.backupFileExists).mockReturnValue(true); vi.mocked(backupService.restoreFromZip).mockResolvedValue({ success: true }); const res = await request(app) .post(`/api/backup/restore/${filename}`) .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(200); expect(res.body.success).toBe(true); }); it('BACKUP-INT-005 — POST /backup/restore/:filename returns 404 when backup not found', async () => { const { user: admin } = createAdmin(testDb); vi.mocked(backupService.backupFileExists).mockReturnValue(false); const res = await request(app) .post('/api/backup/restore/backup-2026-04-06T12-00-00.zip') .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(404); expect(res.body.error).toMatch(/not found/i); }); it('BACKUP-INT-006 — POST /backup/restore/:filename returns 400 for invalid filename', async () => { const { user: admin } = createAdmin(testDb); const res = await request(app) .post('/api/backup/restore/../../evil.zip') .set('Cookie', authCookie(admin.id)); // Express resolves path traversal → no route or invalid filename check expect([400, 404]).toContain(res.status); }); it('BACKUP-INT-007 — POST /backup/restore/:filename returns 400 when restoreFromZip reports failure', async () => { const { user: admin } = createAdmin(testDb); const filename = 'backup-2026-04-06T12-00-00.zip'; vi.mocked(backupService.backupFileExists).mockReturnValue(true); vi.mocked(backupService.restoreFromZip).mockResolvedValue({ success: false, error: 'Invalid backup: travel.db not found', status: 400, }); const res = await request(app) .post(`/api/backup/restore/${filename}`) .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(400); expect(res.body.error).toMatch(/travel\.db not found/i); }); }); // --------------------------------------------------------------------------- // Delete backup // --------------------------------------------------------------------------- describe('Backup delete', () => { it('BACKUP-INT-008 — DELETE /backup/:filename returns 200 on success', async () => { const { user: admin } = createAdmin(testDb); const filename = 'backup-2026-04-06T12-00-00.zip'; vi.mocked(backupService.backupFileExists).mockReturnValue(true); vi.mocked(backupService.deleteBackup).mockReturnValue(undefined); const res = await request(app) .delete(`/api/backup/${filename}`) .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(200); expect(res.body.success).toBe(true); expect(vi.mocked(backupService.deleteBackup)).toHaveBeenCalledWith(filename); }); it('BACKUP-INT-009 — DELETE /backup/:filename returns 404 when not found', async () => { const { user: admin } = createAdmin(testDb); vi.mocked(backupService.backupFileExists).mockReturnValue(false); const res = await request(app) .delete('/api/backup/backup-2026-04-06T12-00-00.zip') .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(404); expect(res.body.error).toMatch(/not found/i); }); it('BACKUP-INT-010 — DELETE /backup/:filename returns 400 for invalid filename', async () => { const { user: admin } = createAdmin(testDb); const res = await request(app) .delete('/api/backup/not-a-backup.tar.gz') .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(400); expect(res.body.error).toMatch(/invalid filename/i); }); }); // --------------------------------------------------------------------------- // Rate limiter on POST /create // --------------------------------------------------------------------------- describe('Backup rate limiter', () => { it('BACKUP-INT-011 — POST /backup/create returns 429 after 3 requests', async () => { const { user: admin } = createAdmin(testDb); // Allow first 3 calls, then block let callCount = 0; vi.mocked(backupService.checkRateLimit).mockImplementation(() => { callCount++; return callCount <= 3; }); // First 3 succeed for (let i = 0; i < 3; i++) { const res = await request(app) .post('/api/backup/create') .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(200); } // 4th is rate-limited const res = await request(app) .post('/api/backup/create') .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(429); expect(res.body.error).toMatch(/too many/i); }); }); // --------------------------------------------------------------------------- // Upload-restore // --------------------------------------------------------------------------- describe('Backup upload-restore', () => { it('BACKUP-INT-012 — POST /backup/upload-restore with zip file returns 200', async () => { const { user: admin } = createAdmin(testDb); vi.mocked(backupService.restoreFromZip).mockResolvedValue({ success: true }); // Create a minimal fake zip buffer (just needs to pass multer's file filter) const fakeZipBuffer = Buffer.from('PK\x03\x04'); // ZIP magic bytes const res = await request(app) .post('/api/backup/upload-restore') .set('Cookie', authCookie(admin.id)) .attach('backup', fakeZipBuffer, { filename: 'test-restore.zip', contentType: 'application/zip' }); expect(res.status).toBe(200); expect(res.body.success).toBe(true); expect(vi.mocked(backupService.restoreFromZip)).toHaveBeenCalled(); }); it('BACKUP-INT-013 — POST /backup/upload-restore with no file returns 400', async () => { const { user: admin } = createAdmin(testDb); const res = await request(app) .post('/api/backup/upload-restore') .set('Cookie', authCookie(admin.id)); expect(res.status).toBe(400); expect(res.body.error).toMatch(/no file/i); }); it('BACKUP-INT-014 — POST /backup/upload-restore returns 400 when restore fails', async () => { const { user: admin } = createAdmin(testDb); vi.mocked(backupService.restoreFromZip).mockResolvedValue({ success: false, error: 'Uploaded file is not a valid SQLite database', status: 400, }); const fakeZipBuffer = Buffer.from('PK\x03\x04'); const res = await request(app) .post('/api/backup/upload-restore') .set('Cookie', authCookie(admin.id)) .attach('backup', fakeZipBuffer, { filename: 'bad-restore.zip', contentType: 'application/zip' }); expect(res.status).toBe(400); expect(res.body.error).toMatch(/not a valid SQLite/i); }); });