k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-23 23:46:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(assistant): shared card tests, wiki rows and ratchets after the card packages

Browse Source
This commit is contained in:
Maurice
2026-10-22 15:50:57 +02:00
parent 0f5ecb70a2
commit fd01a090fc
16 changed files with 329 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/tests/unit/nest/assistant/assistant-tools.service.test.ts
+32 -1
View File
@@ -72,7 +72,7 @@ beforeAll(async () => {
orm = app.get(MikroORM);
registry = app.get(McpRegistryService);
tools = app.get(AssistantToolsService);
await Promise.all(['packing', 'budget'].map((addon) => setAddonEnabled(orm, addon, true)));
await Promise.all(['packing', 'budget', 'collections'].map((addon) => setAddonEnabled(orm, addon, true)));
const { user } = await makeUser(orm);
listed = await listRaw(user.id);
});
@@ -182,6 +182,37 @@ describe('the assistant tool catalog', () => {
expect(journey.map(groupOfTool)).toEqual(journey.map(() => 'journey'));
});
it('ASTTOOL-020: the Studio book tools sit in the journey group but no trip chat is offered them, the undo restore least of all', () => {
const bookTools = [
'get_book',
'describe_book_page',
'list_book_layouts',
'create_book',
'add_book_pages',
'move_book_page',
'delete_book_pages',
'edit_book_page',
'set_book_cover',
'restore_book_page',
];
const entries = bookTools.map((name) => registry.list().find((e) => e.kind === 'tool' && e.name === name));
expect(entries.map((entry) => entry && [entry.className, groupOf(entry)])).toEqual(
bookTools.map(() => ['JourneyBookMcp', 'journey']),
);
expect(bookTools.filter((name) => isOfferedTool(name))).toEqual([]);
expect(ASSISTANT_DENIED_TOOLS.restore_book_page).toMatch(/undo target only/);
expect(bookTools.slice(0, -1).map((name) => ASSISTANT_DENIED_TOOLS[name])).toEqual(
bookTools.slice(0, -1).map(() => expect.stringMatching(/Studio chat only/)),
);
});
it('ASTTOOL-021: the book photo picker reads in the journey group and waits for the Studio chat like the other book tools', () => {
const entry = registry.list().find((e) => e.kind === 'tool' && e.name === 'suggest_book_photos');
expect(entry && [entry.className, groupOf(entry)]).toEqual(['JourneyBookPhotosMcp', 'journey']);
expect(isOfferedTool('suggest_book_photos')).toBe(false);
expect(ASSISTANT_DENIED_TOOLS.suggest_book_photos).toMatch(/Studio chat only/);
});
it('ASTTOOL-017: the hike tools come with the tours, the proposal runs at once and the writes are cards of a tour', () => {
const hikeTools = ['propose_hike', 'create_hike', 'update_tour', 'import_tour_gpx'];
const entries = hikeTools.map((name) => registry.list().find((e) => e.kind === 'tool' && e.name === name));
server/tests/unit/nest/assistant/cards/registry.test.ts
+1 -1
View File
@@ -62,7 +62,7 @@ describe('mergeDomains', () => {
expect(ASSISTANT_UNDO_MAP.create_city_walk?.tool).toBe('delete_place');
expect(ASSISTANT_UNDO_MAP.create_city_walk?.args({}, { tour: { place_id: 9 } }, null)).toEqual({ placeId: 9 });
expect(TOOL_CARDS.update_tour?.undo).toBeUndefined();
expect(CARD_PROMPT_LINES).toEqual([]);
expect(CARD_PROMPT_LINES).toEqual(DOMAINS.flatMap((d) => d.prompt ?? []));
});
it('ASTREG-002: two packages may fill different fields of one tool, never the same one', () => {
server/tests/unit/nest/assistant/tool-call-preview.helpers.test.ts
+31 -33
View File
@@ -221,23 +221,23 @@ describe('describeToolCall', () => {
const gone = describeToolCall('delete_day_note', 'tc-8', { dayId: 31, noteId: 41 }, hinted(true, false, null));
expect(gone).toMatchObject({ verbKey: 'genericRemove', subject: 'Rail pass', dayId: 31 });
expect(gone.rows).toEqual([{ op: 'add', labelKey: 'day', before: null, after: 'Arrival' }]);
const vacay = describeToolCall(
'toggle_vacay_entry',
'tc-9',
{ date: '2026-07-01', half: true },
hinted(false, false, 'vacay'),
);
expect(vacay).toMatchObject({ subject: 'toggle vacay entry', domain: 'vacay', undoable: false });
expect(vacay.rows).toEqual([
{ op: 'add', labelKey: 'day', before: null, after: '2026-07-01' },
{ op: 'add', labelKey: 'field', field: 'half', before: null, after: '✓' },
]);
// A tool of an addon without a card of its own: named by its words, its arguments as rows, its part of TREK.
const year = describeToolCall('add_vacay_year', 'tc-9', { year: 2027 }, hinted(false, true, 'vacay'));
expect(year).toMatchObject({ verbKey: 'genericCreate', domain: 'vacay', undoable: false });
// A vacation day has a card of its own, even before its lookup ran: the day, in the vacation planner.
const vacay = describeToolCall('toggle_vacay_entry', 'tc-10', { date: '2026-07-01', half: true }, ctx);
expect(vacay).toMatchObject({ verbKey: 'addVacationDay', subject: 'Wed 1 Jul', domain: 'vacay', undoable: false });
expect(vacay.rows).toEqual([]);
// Without hints the name still tells a removal from an addition.
expect(describe_('create_collab_poll', { question: 'Where?' }).verbKey).toBe('genericCreate');
expect(describe_('unmark_country_visited', {}).verbKey).toBe('genericRemove');
expect(appliedChange('toggle_vacay_entry', 'tc-9', {}, { ok: true }, null, null)).toMatchObject({
expect(appliedChange('add_vacay_year', 'tc-9', {}, { years: [2026, 2027] }, null, null)).toMatchObject({
entity: 'other',
});
expect(appliedChange('toggle_vacay_entry', 'tc-10', {}, { action: 'added' }, null, null)).toMatchObject({
entity: 'vacay',
ids: [],
});
});
it('ASTPRV-018: a change to the day plan says what it does to which day; anything else has no effect', () => {
@@ -483,7 +483,8 @@ describe('the cards of tours', () => {
verbKey: 'importTour',
subject: 'ridge.gpx',
rows: [{ op: 'add', labelKey: 'type', before: null, after: 'bike' }],
undoable: false,
// A file of one track can be taken back once it is in; the receipt says whether this one was.
undoable: true,
});
expect(describe_('import_tour_gpx', { gpx }).subject).toBe('Ridge walk');
expect(describe_('import_tour_gpx', { gpx: '<gpx><name>Open' }).subject).toBe('GPX');
@@ -596,25 +597,22 @@ describe('the cards of tours', () => {
});
it('ASTPRV-031: a package names its ids first; a place id of a tool outside the trip is no trip place', () => {
const groups = FOREIGN_ID_GROUPS as Set<string>;
const saved = { ...ctx, hintOf: () => ({ destructive: false, creates: true, group: 'collections' }) };
const add = () => describeToolCall('add_collection_place', 'tc-31', { placeId: 12 }, saved);
// Place 12 is the trip's Nishiki Market until the collections say their ids are their own.
expect(add()).toMatchObject({ subject: 'Nishiki Market', placeIds: [12], domain: 'collections' });
groups.add('collections');
try {
const outside = add();
expect(outside).toMatchObject({ subject: 'add collection place', placeIds: [] });
expect(outside.rows).toEqual([{ op: 'add', labelKey: 'field', field: 'placeId', before: null, after: '12' }]);
const named = withCards(
'add_collection_place',
{ nameArg: (key, value) => (key === 'placeId' ? `Saved place ${value}` : null) },
null,
add,
);
expect(named).toMatchObject({ subject: 'Saved place 12', rows: [], placeIds: [] });
} finally {
groups.delete('collections');
}
const hinted = (group: string) => ({ ...ctx, hintOf: () => ({ destructive: false, creates: true, group }) });
const add = (group: string) => describeToolCall('add_collection_place', 'tc-31', { placeId: 12 }, hinted(group));
// Place 12 is the trip's Nishiki Market for a tool of a group whose ids are the trip's.
expect(FOREIGN_ID_GROUPS.has('tours')).toBe(false);
expect(add('tours')).toMatchObject({ subject: 'Nishiki Market', placeIds: [12], domain: 'tours' });
// The collections say their place ids are their own.
expect(FOREIGN_ID_GROUPS.has('collections')).toBe(true);
const outside = add('collections');
expect(outside).toMatchObject({ subject: 'add collection place', placeIds: [] });
expect(outside.rows).toEqual([{ op: 'add', labelKey: 'field', field: 'placeId', before: null, after: '12' }]);
const named = withCards(
'add_collection_place',
{ nameArg: (key, value) => (key === 'placeId' ? `Saved place ${value}` : null) },
null,
() => add('collections'),
);
expect(named).toMatchObject({ subject: 'Saved place 12', rows: [], placeIds: [] });
});
});