test(db): the key rotation on Postgres, and its refusals before a key is asked

This commit is contained in:
Maurice
2026-11-17 13:54:25 +01:00
parent 7065f87dc0
commit f311fed5c9
2 changed files with 249 additions and 14 deletions
@@ -1,10 +1,11 @@
/**
* reset-admin.js and migrate-encryption.ts on an install whose database is
* Postgres (TREK_DB_URL): neither opens or creates a SQLite file there. The
* key rotation refuses outright, since it cannot re-encrypt the secrets in
* Postgres yet; the reset refuses a TREK_DB_FILE beside the URL, as the server
* does. The reset itself on Postgres goes through the built server's engine,
* which these SQLite-lane tests do not have.
* Postgres (TREK_DB_URL): neither opens or creates a SQLite file there, and
* both refuse a SQLite path beside the URL. The key rotation checks that it
* reaches the database before it asks for a key. The rotation itself on
* Postgres is tests/postgres/migrate-encryption.test.ts; the reset on Postgres
* goes through the built server's engine, which these SQLite-lane tests do
* not have.
*/
import { execFileSync } from 'child_process';
import fs from 'fs';
@@ -13,7 +14,7 @@ import path from 'path';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
const SERVER_ROOT = path.resolve(__dirname, '../../..');
/** Never reached: both scripts stop before they connect. */
/** Nothing listens there: the scripts stop before they connect, or fail to. */
const PG_URL = 'postgres://trek:secret@127.0.0.1:1/trek?sslmode=disable';
let tmpDir: string;
@@ -26,24 +27,28 @@ afterEach(() => {
fs.rmSync(tmpDir, { recursive: true, force: true });
});
function run(args: string[], env: Record<string, string>, input = ''): { status: number; stderr: string } {
function run(
args: string[],
env: Record<string, string>,
input = '',
): { status: number; stdout: string; stderr: string } {
try {
execFileSync(process.execPath, args, {
const stdout = execFileSync(process.execPath, args, {
cwd: SERVER_ROOT,
env: { ...process.env, ...env },
input,
stdio: 'pipe',
encoding: 'utf8',
});
return { status: 0, stderr: '' };
return { status: 0, stdout, stderr: '' };
} catch (err) {
const e = err as { status: number; stderr: string };
return { status: e.status, stderr: e.stderr };
const e = err as { status: number; stdout: string; stderr: string };
return { status: e.status, stdout: e.stdout, stderr: e.stderr };
}
}
describe('maintenance scripts with TREK_DB_URL', () => {
it('PGSCRIPTS-001: migrate-encryption.ts refuses before it asks for a key, and touches no file', () => {
it('PGSCRIPTS-001: migrate-encryption.ts refuses DB_PATH beside TREK_DB_URL before it asks for a key, and touches no file', () => {
const dbPath = path.join(tmpDir, 'travel.db');
const r = run(
['--import', 'tsx', 'scripts/migrate-encryption.ts'],
@@ -51,11 +56,24 @@ describe('maintenance scripts with TREK_DB_URL', () => {
'old-key\nnew-key\nyes\n',
);
expect(r.status).toBe(1);
expect(r.stderr).toContain('TREK_DB_URL is set');
expect(r.stderr).toContain('Nothing was changed');
expect(r.stdout).not.toContain('Old ENCRYPTION_KEY');
expect(r.stderr).toContain('TREK_DB_URL and DB_PATH are both set');
expect(r.stderr).toContain('nothing was changed');
expect(fs.readdirSync(tmpDir)).toEqual([]);
}, 60000);
it('PGSCRIPTS-003: migrate-encryption.ts stops before it asks for a key when the database cannot be reached', () => {
const r = run(
['--import', 'tsx', 'scripts/migrate-encryption.ts'],
{ TREK_DB_URL: PG_URL, DB_PATH: '', TREK_DB_FILE: '' },
'old-key\nnew-key\nyes\n',
);
expect(r.status).toBe(1);
expect(r.stdout).not.toContain('Old ENCRYPTION_KEY');
expect(r.stderr).toMatch(/Could not reach the database TREK_DB_URL names|Cannot write to/);
expect(r.stdout).not.toContain('Backup created');
}, 60000);
it('PGSCRIPTS-002: reset-admin.js refuses TREK_DB_FILE beside TREK_DB_URL and creates no SQLite file', () => {
const dbPath = path.join(tmpDir, 'travel.db');
const r = run(['reset-admin.js'], { TREK_DB_URL: PG_URL, TREK_DB_FILE: dbPath, RESET_ADMIN_PASSWORD: 'x' });