k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-20 05:56:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

build(server): lint:boundaries counts the RPC and MCP layers as domains and sees getRepository calls

Browse Source 
src/nest-rpc, src/nest-mcp and src/mcp import domains and are imported by them, but the domain map only knew src/nest, so their edges dropped out of domainCycles and their repository injections out of foreignRepositories. Each layer now counts as one domain. The repository rule reads the syntax tree for @InjectRepository(X) and for getRepository(X) on an EntityManager, so a comment no longer counts and a foreign read through the EntityManager no longer passes. The baseline takes the cycles and the repository reaches the wider view finds; settings -> Users goes, it was a comment.
This commit is contained in:
Maurice
2026-10-10 19:46:25 +02:00
parent 0f6ae8b928
commit ebd8a4f8c9
5 changed files with 230 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/tests/unit/scripts/import-boundaries.test.ts
+50
View File
@@ -291,6 +291,56 @@ describe('import-boundaries.mjs', () => {
expect(res.out).toContain('no owner for injected entity Mystery (nest/a/a.service.ts)');
});
it('BOUND-015: getRepository calls count like injections, a comment naming one does not', () => {
const owners = JSON.stringify({ Trips: 'trips', Users: 'auth' });
const dir = serverRoot({
'nest/perm/perm.guard.ts': [
'// em.getRepository(Users) would be foreign too',
'class G { run(em: any) { return em.getRepository(Trips).findAccessible(1, 2); } }',
'export { G };',
'',
].join('\n'),
});
writeFileSync(path.join(dir, 'scripts/repository-owners.json'), owners);
const res = run(dir);
expect(res.status).toBe(1);
expect(res.out).toContain('FAIL foreignRepositories: perm -> Trips (owned by trips)');
expect(res.out).not.toContain('Users');
});
it('BOUND-016: src/nest-rpc, src/nest-mcp and src/mcp are domains of their own for cycles and repositories', () => {
const owners = JSON.stringify({ Trips: 'trips' });
const dir = serverRoot({
'nest/addons/addons.service.ts': [
"import { kit } from '../../nest-rpc/rpc-kit/kit';",
'export class AddonsService { k = kit; }',
'',
].join('\n'),
'nest-rpc/rpc-kit/kit.ts': 'export const kit = 1;\n',
'nest-rpc/plugin-guards.service.ts': [
"import { AddonsService } from '../nest/addons/addons.service';",
'@InjectRepository(Trips) class PluginGuardsService { a = AddonsService; }',
'export { PluginGuardsService };',
'',
].join('\n'),
'nest/weather/weather.rpc.ts': [
"import { PluginGuardsService } from '../../nest-rpc/plugin-guards.service';",
'export const r = PluginGuardsService;',
'',
].join('\n'),
});
writeFileSync(path.join(dir, 'scripts/repository-owners.json'), owners);
const res = run(dir);
expect(res.status).toBe(1);
expect(res.out).toContain('FAIL domainCycles: addons -> nest-rpc');
expect(res.out).toContain('FAIL domainCycles: nest-rpc -> addons');
expect(res.out).toContain('FAIL foreignRepositories: nest-rpc -> Trips (owned by trips)');
// The layers are toolkits: a domain using one reaches no internals, and
// weather, which nothing imports back, is on no cycle.
expect(res.out).not.toContain('FAIL domainInternals');
expect(res.out).not.toContain('weather -> nest-rpc');
});
it('BOUND-010: resolves .js specifiers and index files', () => {
const dir = serverRoot({
'x/a.ts': "import { b } from './b.js';\nimport { c } from './c';\nexport const a = [b, c];\n",