From e078a9d9e1ca1353e99a65b3a398e528422161fb Mon Sep 17 00:00:00 2001 From: jubnl Date: Thu, 16 Apr 2026 23:36:33 +0200 Subject: [PATCH] fix: getAppVersion now getting 1st from environment, fallback to package.json, fallback to 0.0.0 if all failed --- server/src/systemNotices/service.ts | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/server/src/systemNotices/service.ts b/server/src/systemNotices/service.ts index d962ed90..13c16b1b 100644 --- a/server/src/systemNotices/service.ts +++ b/server/src/systemNotices/service.ts @@ -1,10 +1,19 @@ +import { createRequire } from 'module'; +import semver from 'semver'; import { db } from '../db/database.js'; import { SYSTEM_NOTICES } from './registry.js'; import { evaluate } from './conditions.js'; import type { SystemNoticeDTO } from './types.js'; function getCurrentAppVersion(): string { - return process.env.APP_VERSION || '0.0.0'; + const fromEnv = semver.valid(process.env.APP_VERSION ?? ''); + if (fromEnv) return fromEnv; + try { + const pkg = require('../../package.json') as { version?: string }; + return semver.valid(pkg.version ?? '') ?? '0.0.0'; + } catch { + return '0.0.0'; + } } function severityWeight(s: string): number {