mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-18 21:16:47 +00:00
feat(mcp): uneven expense splits, and the fields update was missing
Historical costs are rarely split evenly, and every budget tool took only a list of member ids, which the service stores as a null amount, meaning an equal share. members[] carries what each person owes instead. A custom split has to reconcile before it is persisted, so the tool refuses one whose shares do not add up in whole cents. Two ways round that check needed closing with it: the write path drops a payer who is not on the trip and then derives the total from what survived, and an empty payer list means a total of zero rather than the previous one. Both would have certified a split the stored row does not satisfy. Also on update, which had none of them: currency (so the FX freeze is no longer a no-op), expense_date, and a settlement currency, plus place_id on create so a museum ticket can point at the museum.
This commit is contained in:
Maurice
@@ -1,5 +1,8 @@
|
||||
/**
|
||||
* Unit tests for MCP budget tools: create_budget_item, update_budget_item, delete_budget_item.
|
||||
* Unit tests for MCP budget tools: create_budget_item, update_budget_item,
|
||||
* delete_budget_item, plus the settlement cases that turn on the currency the
|
||||
* payment was made in (the rest of the settlement surface lives in
|
||||
* tools-budget-advanced.test.ts).
|
||||
*/
|
||||
import { describe, it, expect, vi, beforeAll, beforeEach, afterAll } from 'vitest';
|
||||
|
||||
@@ -35,7 +38,7 @@ vi.mock('../../../src/websocket', () => ({ broadcast: broadcastMock }));
|
||||
import { createTables } from '../../../src/db/schema';
|
||||
import { runMigrations } from '../../../src/db/migrations';
|
||||
import { resetTestDb } from '../../helpers/test-db';
|
||||
import { createUser, createTrip, createBudgetItem, addTripMember } from '../../helpers/factories';
|
||||
import { createUser, createTrip, createBudgetItem, createPlace, addTripMember } from '../../helpers/factories';
|
||||
import { createMcpHarness, parseToolResult, parseResourceResult, type McpHarness } from '../../helpers/mcp-harness';
|
||||
|
||||
beforeAll(() => {
|
||||
@@ -47,9 +50,14 @@ beforeEach(() => {
|
||||
resetTestDb(testDb);
|
||||
broadcastMock.mockClear();
|
||||
delete process.env.DEMO_MODE;
|
||||
// Freezing the FX rate of a foreign currency is a real fetch to
|
||||
// api.frankfurter.dev with a 10 s abort. Fail closed by default; the cases
|
||||
// that assert a frozen rate install their own rate stub.
|
||||
vi.stubGlobal('fetch', vi.fn(async () => { throw new Error('offline'); }));
|
||||
});
|
||||
|
||||
afterAll(() => {
|
||||
vi.unstubAllGlobals();
|
||||
testDb.close();
|
||||
});
|
||||
|
||||
@@ -58,6 +66,57 @@ async function withHarness(userId: number, fn: (h: McpHarness) => Promise<void>)
|
||||
try { await fn(h); } finally { await h.cleanup(); }
|
||||
}
|
||||
|
||||
function errorText(result: Awaited<ReturnType<McpHarness['client']['callTool']>>): string {
|
||||
const text = (result.content as { type: string; text?: string }[]).find((c) => c.type === 'text');
|
||||
return text?.text ?? '';
|
||||
}
|
||||
|
||||
function tripWithTwo() {
|
||||
const { user } = createUser(testDb);
|
||||
const { user: other } = createUser(testDb);
|
||||
const trip = createTrip(testDb, user.id);
|
||||
addTripMember(testDb, trip.id, other.id);
|
||||
return { user, other, trip };
|
||||
}
|
||||
|
||||
function memberRows(itemId: number) {
|
||||
return testDb.prepare('SELECT user_id, amount FROM budget_item_members WHERE budget_item_id = ? ORDER BY user_id')
|
||||
.all(itemId) as { user_id: number; amount: number | null }[];
|
||||
}
|
||||
|
||||
function itemRow(itemId: number) {
|
||||
return testDb.prepare('SELECT total_price, currency, exchange_rate, persons, expense_date, place_id FROM budget_items WHERE id = ?')
|
||||
.get(itemId) as {
|
||||
total_price: number; currency: string | null; exchange_rate: number | null;
|
||||
persons: number | null; expense_date: string | null; place_id: number | null;
|
||||
};
|
||||
}
|
||||
|
||||
function itemCount(tripId: number): number {
|
||||
return (testDb.prepare('SELECT COUNT(*) AS count FROM budget_items WHERE trip_id = ?').get(tripId) as { count: number }).count;
|
||||
}
|
||||
|
||||
function settlementRow(id: number) {
|
||||
return testDb.prepare('SELECT amount, currency, exchange_rate FROM budget_settlements WHERE id = ?')
|
||||
.get(id) as { amount: number; currency: string | null; exchange_rate: number | null };
|
||||
}
|
||||
|
||||
// budget_settlements is not one of the tables the reset clears, and trip ids are
|
||||
// reused, so a count is only ever compared against the count taken in the same test.
|
||||
function settlementCount(tripId: number): number {
|
||||
return (testDb.prepare('SELECT COUNT(*) AS count FROM budget_settlements WHERE trip_id = ?').get(tripId) as { count: number }).count;
|
||||
}
|
||||
|
||||
/** Frankfurter's shape: one entry per quote, the base's own rate omitted. */
|
||||
function stubRates(rates: Record<string, number>): void {
|
||||
vi.stubGlobal('fetch', vi.fn(async () => ({
|
||||
ok: true,
|
||||
text: async () => JSON.stringify(
|
||||
Object.entries(rates).map(([quote, rate]) => ({ date: '2026-08-28', base: 'EUR', quote, rate })),
|
||||
),
|
||||
})));
|
||||
}
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// create_budget_item
|
||||
// ---------------------------------------------------------------------------
|
||||
@@ -336,3 +395,561 @@ describe('Resource: trek://trips/{tripId}/budget', () => {
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Uneven splits: members carries what each participant owes, the way the REST
|
||||
// body has since the Costs rework. member_ids alone always meant an equal share.
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
describe('Tool: create_budget_item (uneven split)', () => {
|
||||
it('persists what each member owes', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_budget_item',
|
||||
arguments: {
|
||||
tripId: trip.id, name: 'Dinner', total_price: 100,
|
||||
members: [{ user_id: user.id, amount: 70 }, { user_id: other.id, amount: 30 }],
|
||||
},
|
||||
});
|
||||
const data = parseToolResult(result) as any;
|
||||
expect(memberRows(data.item.id)).toEqual([
|
||||
{ user_id: user.id, amount: 70 },
|
||||
{ user_id: other.id, amount: 30 },
|
||||
]);
|
||||
expect(itemRow(data.item.id).persons).toBe(2);
|
||||
});
|
||||
});
|
||||
|
||||
it('refuses a split that does not add up to the total', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_budget_item',
|
||||
arguments: {
|
||||
tripId: trip.id, name: 'Dinner', total_price: 100,
|
||||
members: [{ user_id: user.id, amount: 60 }, { user_id: other.id, amount: 30 }],
|
||||
},
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(errorText(result)).toContain('does not add up');
|
||||
expect(itemCount(trip.id)).toBe(0);
|
||||
});
|
||||
});
|
||||
|
||||
it('measures the split against the payer sum, not the stated total', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_budget_item',
|
||||
arguments: {
|
||||
tripId: trip.id, name: 'Groceries', total_price: 100,
|
||||
payers: [{ user_id: user.id, amount: 90 }],
|
||||
members: [{ user_id: user.id, amount: 60 }, { user_id: other.id, amount: 30 }],
|
||||
},
|
||||
});
|
||||
const data = parseToolResult(result) as any;
|
||||
expect(itemRow(data.item.id).total_price).toBe(90);
|
||||
expect(memberRows(data.item.id).map(m => m.amount)).toEqual([60, 30]);
|
||||
});
|
||||
});
|
||||
|
||||
it('refuses a split that matches the stated total but not what the payers paid', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_budget_item',
|
||||
arguments: {
|
||||
tripId: trip.id, name: 'Groceries', total_price: 100,
|
||||
payers: [{ user_id: user.id, amount: 90 }],
|
||||
members: [{ user_id: user.id, amount: 70 }, { user_id: other.id, amount: 30 }],
|
||||
},
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(itemCount(trip.id)).toBe(0);
|
||||
});
|
||||
});
|
||||
|
||||
it('refuses a member who is not on the trip', async () => {
|
||||
const { user, trip } = tripWithTwo();
|
||||
const { user: stranger } = createUser(testDb);
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_budget_item',
|
||||
arguments: {
|
||||
tripId: trip.id, name: 'Dinner', total_price: 100,
|
||||
members: [{ user_id: user.id, amount: 50 }, { user_id: stranger.id, amount: 50 }],
|
||||
},
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(errorText(result)).toContain('not on this trip');
|
||||
expect(itemCount(trip.id)).toBe(0);
|
||||
});
|
||||
});
|
||||
|
||||
it('refuses members alongside member_ids', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_budget_item',
|
||||
arguments: {
|
||||
tripId: trip.id, name: 'Dinner', total_price: 100,
|
||||
member_ids: [user.id, other.id],
|
||||
members: [{ user_id: user.id, amount: 50 }, { user_id: other.id, amount: 50 }],
|
||||
},
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(errorText(result)).toContain('not both');
|
||||
expect(itemCount(trip.id)).toBe(0);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('Tool: update_budget_item (uneven split)', () => {
|
||||
function itemWithEqualSplit(tripId: number, userIds: number[]) {
|
||||
const item = createBudgetItem(testDb, tripId, { name: 'Dinner', total_price: 100 });
|
||||
const insert = testDb.prepare('INSERT INTO budget_item_members (budget_item_id, user_id, paid, amount) VALUES (?, ?, 0, NULL)');
|
||||
for (const id of userIds) insert.run(item.id, id);
|
||||
testDb.prepare('UPDATE budget_items SET persons = ? WHERE id = ?').run(userIds.length, item.id);
|
||||
return item;
|
||||
}
|
||||
|
||||
it('replaces the equal split with per-member amounts', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
const item = itemWithEqualSplit(trip.id, [user.id, other.id]);
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_budget_item',
|
||||
arguments: {
|
||||
tripId: trip.id, itemId: item.id,
|
||||
members: [{ user_id: user.id, amount: 40 }, { user_id: other.id, amount: 60 }],
|
||||
},
|
||||
});
|
||||
expect(result.isError).toBeFalsy();
|
||||
expect(memberRows(item.id)).toEqual([
|
||||
{ user_id: user.id, amount: 40 },
|
||||
{ user_id: other.id, amount: 60 },
|
||||
]);
|
||||
expect(itemRow(item.id).persons).toBe(2);
|
||||
});
|
||||
});
|
||||
|
||||
it('measures the split against the stored total when the call does not restate it', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
const item = itemWithEqualSplit(trip.id, [user.id, other.id]);
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_budget_item',
|
||||
arguments: {
|
||||
tripId: trip.id, itemId: item.id,
|
||||
members: [{ user_id: user.id, amount: 40 }, { user_id: other.id, amount: 50 }],
|
||||
},
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(errorText(result)).toContain('100.00');
|
||||
expect(memberRows(item.id)).toEqual([
|
||||
{ user_id: user.id, amount: null },
|
||||
{ user_id: other.id, amount: null },
|
||||
]);
|
||||
});
|
||||
});
|
||||
|
||||
it('refuses the same member twice', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
const item = itemWithEqualSplit(trip.id, [user.id, other.id]);
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_budget_item',
|
||||
arguments: {
|
||||
tripId: trip.id, itemId: item.id,
|
||||
members: [{ user_id: user.id, amount: 50 }, { user_id: user.id, amount: 50 }],
|
||||
},
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(errorText(result)).toContain('twice');
|
||||
expect(memberRows(item.id).map(m => m.amount)).toEqual([null, null]);
|
||||
});
|
||||
});
|
||||
|
||||
it('refuses members alongside member_ids', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
const item = itemWithEqualSplit(trip.id, [user.id, other.id]);
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_budget_item',
|
||||
arguments: {
|
||||
tripId: trip.id, itemId: item.id,
|
||||
member_ids: [user.id],
|
||||
members: [{ user_id: user.id, amount: 100 }],
|
||||
},
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(errorText(result)).toContain('not both');
|
||||
expect(memberRows(item.id)).toHaveLength(2);
|
||||
});
|
||||
});
|
||||
|
||||
it('reports a missing item before it looks at the split', async () => {
|
||||
const { user, trip } = tripWithTwo();
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_budget_item',
|
||||
arguments: { tripId: trip.id, itemId: 99999, members: [{ user_id: user.id, amount: 10 }] },
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(errorText(result)).toBe('Budget item not found.');
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Currency and date on an existing expense
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
describe('Tool: update_budget_item (currency)', () => {
|
||||
it('changes the currency and freezes the rate at entry time', async () => {
|
||||
const { user } = createUser(testDb);
|
||||
const trip = createTrip(testDb, user.id);
|
||||
const item = createBudgetItem(testDb, trip.id, { total_price: 100 });
|
||||
stubRates({ USD: 1.1 });
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_budget_item',
|
||||
arguments: { tripId: trip.id, itemId: item.id, currency: 'USD' },
|
||||
});
|
||||
expect(result.isError).toBeFalsy();
|
||||
const row = itemRow(item.id);
|
||||
expect(row.currency).toBe('USD');
|
||||
expect(row.exchange_rate).toBe(1.1);
|
||||
});
|
||||
});
|
||||
|
||||
it('clears the currency back to the trip currency', async () => {
|
||||
const { user } = createUser(testDb);
|
||||
const trip = createTrip(testDb, user.id);
|
||||
const item = createBudgetItem(testDb, trip.id, { total_price: 100 });
|
||||
testDb.prepare('UPDATE budget_items SET currency = ?, exchange_rate = ? WHERE id = ?').run('USD', 1.1, item.id);
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_budget_item',
|
||||
arguments: { tripId: trip.id, itemId: item.id, currency: null },
|
||||
});
|
||||
expect(result.isError).toBeFalsy();
|
||||
expect(itemRow(item.id).currency).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
it('refuses a currency that is not a code', async () => {
|
||||
const { user } = createUser(testDb);
|
||||
const trip = createTrip(testDb, user.id);
|
||||
const item = createBudgetItem(testDb, trip.id, { total_price: 100 });
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_budget_item',
|
||||
arguments: { tripId: trip.id, itemId: item.id, currency: 'United States Dollars' },
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(itemRow(item.id).currency).toBeNull();
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('Tool: update_budget_item (expense date)', () => {
|
||||
it('moves the expense to another date', async () => {
|
||||
const { user } = createUser(testDb);
|
||||
const trip = createTrip(testDb, user.id);
|
||||
const item = createBudgetItem(testDb, trip.id);
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_budget_item',
|
||||
arguments: { tripId: trip.id, itemId: item.id, expense_date: '2026-09-14' },
|
||||
});
|
||||
expect(result.isError).toBeFalsy();
|
||||
expect(itemRow(item.id).expense_date).toBe('2026-09-14');
|
||||
});
|
||||
});
|
||||
|
||||
it('clears the expense date', async () => {
|
||||
const { user } = createUser(testDb);
|
||||
const trip = createTrip(testDb, user.id);
|
||||
const item = createBudgetItem(testDb, trip.id);
|
||||
testDb.prepare('UPDATE budget_items SET expense_date = ? WHERE id = ?').run('2026-09-14', item.id);
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_budget_item',
|
||||
arguments: { tripId: trip.id, itemId: item.id, expense_date: null },
|
||||
});
|
||||
expect(result.isError).toBeFalsy();
|
||||
expect(itemRow(item.id).expense_date).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
it('refuses a date that is not a string', async () => {
|
||||
const { user } = createUser(testDb);
|
||||
const trip = createTrip(testDb, user.id);
|
||||
const item = createBudgetItem(testDb, trip.id);
|
||||
testDb.prepare('UPDATE budget_items SET expense_date = ? WHERE id = ?').run('2026-09-14', item.id);
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_budget_item',
|
||||
arguments: { tripId: trip.id, itemId: item.id, expense_date: 20260915 },
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(itemRow(item.id).expense_date).toBe('2026-09-14');
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Expenses linked to a place (#1298), the place-side twin of reservation_id
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
describe('Budget tools: place link', () => {
|
||||
it('create_budget_item links the expense to a place on the trip', async () => {
|
||||
const { user } = createUser(testDb);
|
||||
const trip = createTrip(testDb, user.id);
|
||||
const place = createPlace(testDb, trip.id, { name: 'Louvre' });
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_budget_item',
|
||||
arguments: { tripId: trip.id, name: 'Louvre tickets', total_price: 34, place_id: place.id },
|
||||
});
|
||||
const data = parseToolResult(result) as any;
|
||||
expect(itemRow(data.item.id).place_id).toBe(place.id);
|
||||
});
|
||||
});
|
||||
|
||||
it('create_budget_item refuses a place from another trip', async () => {
|
||||
const { user } = createUser(testDb);
|
||||
const trip = createTrip(testDb, user.id);
|
||||
const elsewhere = createTrip(testDb, user.id);
|
||||
const place = createPlace(testDb, elsewhere.id);
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_budget_item',
|
||||
arguments: { tripId: trip.id, name: 'Tickets', total_price: 34, place_id: place.id },
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(errorText(result)).toBe('place_id does not belong to this trip.');
|
||||
expect(itemCount(trip.id)).toBe(0);
|
||||
});
|
||||
});
|
||||
|
||||
it('create_budget_item_with_members links the expense to a place on the trip', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
const place = createPlace(testDb, trip.id, { name: 'Louvre' });
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_budget_item_with_members',
|
||||
arguments: { tripId: trip.id, name: 'Louvre tickets', total_price: 68, userIds: [user.id, other.id], place_id: place.id },
|
||||
});
|
||||
const data = parseToolResult(result) as any;
|
||||
expect(itemRow(data.item.id).place_id).toBe(place.id);
|
||||
});
|
||||
});
|
||||
|
||||
it('create_budget_item_with_members refuses a place from another trip', async () => {
|
||||
const { user, trip } = tripWithTwo();
|
||||
const elsewhere = createTrip(testDb, user.id);
|
||||
const place = createPlace(testDb, elsewhere.id);
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_budget_item_with_members',
|
||||
arguments: { tripId: trip.id, name: 'Tickets', total_price: 68, place_id: place.id },
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(errorText(result)).toBe('place_id does not belong to this trip.');
|
||||
expect(itemCount(trip.id)).toBe(0);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Settle-up payments made in another currency (the #1445 freeze)
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
describe('Tool: create_settlement (currency)', () => {
|
||||
it('records the payment in the currency it was made in and freezes its rate', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
stubRates({ USD: 1.1 });
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_settlement',
|
||||
arguments: { tripId: trip.id, from_user_id: other.id, to_user_id: user.id, amount: 20, currency: 'USD' },
|
||||
});
|
||||
const data = parseToolResult(result) as any;
|
||||
const row = settlementRow(data.settlement.id);
|
||||
expect(row.currency).toBe('USD');
|
||||
expect(row.exchange_rate).toBe(1.1);
|
||||
expect(row.amount).toBe(20);
|
||||
});
|
||||
});
|
||||
|
||||
it('books the payment in the trip currency when none is given', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_settlement',
|
||||
arguments: { tripId: trip.id, from_user_id: other.id, to_user_id: user.id, amount: 20 },
|
||||
});
|
||||
const data = parseToolResult(result) as any;
|
||||
const row = settlementRow(data.settlement.id);
|
||||
expect(row.currency).toBeNull();
|
||||
expect(row.exchange_rate).toBe(1);
|
||||
});
|
||||
});
|
||||
|
||||
it('refuses a currency that is not a code', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
const before = settlementCount(trip.id);
|
||||
await withHarness(user.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_settlement',
|
||||
arguments: { tripId: trip.id, from_user_id: other.id, to_user_id: user.id, amount: 20, currency: 'United States Dollars' },
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(settlementCount(trip.id)).toBe(before);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('Tool: update_settlement (currency)', () => {
|
||||
it('changes the currency the payment was made in and freezes its rate', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
await withHarness(user.id, async (h) => {
|
||||
const created = parseToolResult(await h.client.callTool({
|
||||
name: 'create_settlement',
|
||||
arguments: { tripId: trip.id, from_user_id: other.id, to_user_id: user.id, amount: 20 },
|
||||
})) as any;
|
||||
stubRates({ USD: 1.1 });
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_settlement',
|
||||
arguments: { tripId: trip.id, settlementId: created.settlement.id, from_user_id: other.id, to_user_id: user.id, amount: 20, currency: 'USD' },
|
||||
});
|
||||
expect(result.isError).toBeFalsy();
|
||||
const row = settlementRow(created.settlement.id);
|
||||
expect(row.currency).toBe('USD');
|
||||
expect(row.exchange_rate).toBe(1.1);
|
||||
});
|
||||
});
|
||||
|
||||
it('clears the currency back to the trip currency', async () => {
|
||||
const { user, other, trip } = tripWithTwo();
|
||||
stubRates({ USD: 1.1 });
|
||||
await withHarness(user.id, async (h) => {
|
||||
const created = parseToolResult(await h.client.callTool({
|
||||
name: 'create_settlement',
|
||||
arguments: { tripId: trip.id, from_user_id: other.id, to_user_id: user.id, amount: 20, currency: 'USD' },
|
||||
})) as any;
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_settlement',
|
||||
arguments: { tripId: trip.id, settlementId: created.settlement.id, from_user_id: other.id, to_user_id: user.id, amount: 20, currency: null },
|
||||
});
|
||||
expect(result.isError).toBeFalsy();
|
||||
expect(settlementRow(created.settlement.id).currency).toBeNull();
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// The split has to reconcile against the total that is actually stored
|
||||
//
|
||||
// writeItemPayers drops a payer who is not on the trip and then derives
|
||||
// total_price from what survived, so certifying a split against the payers as
|
||||
// GIVEN would pass a check the stored row fails. An empty payer list is the
|
||||
// same trap from the other side: it means "no payers", so the derived total is
|
||||
// zero, not the previous one.
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
describe('Budget tools: a custom split cannot be certified against a total the row will not get', () => {
|
||||
it('refuses a payer who is not on the trip rather than storing an unbalanced split', async () => {
|
||||
const { user: owner } = createUser(testDb);
|
||||
const { user: stranger } = createUser(testDb);
|
||||
const trip = createTrip(testDb, owner.id);
|
||||
await withHarness(owner.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_budget_item',
|
||||
arguments: {
|
||||
tripId: trip.id, name: 'Dinner', total_price: 100,
|
||||
members: [{ user_id: owner.id, amount: 100 }],
|
||||
payers: [{ user_id: stranger.id, amount: 50 }, { user_id: owner.id, amount: 50 }],
|
||||
},
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(errorText(result)).toContain('not on this trip');
|
||||
expect(testDb.prepare('SELECT COUNT(*) AS n FROM budget_items WHERE trip_id = ?').get(trip.id)).toEqual({ n: 0 });
|
||||
});
|
||||
});
|
||||
|
||||
it('refuses an empty payer list under a non-zero split, because the stored total becomes zero', async () => {
|
||||
const { user: owner } = createUser(testDb);
|
||||
const { user: friend } = createUser(testDb);
|
||||
const trip = createTrip(testDb, owner.id);
|
||||
addTripMember(testDb, trip.id, friend.id);
|
||||
await withHarness(owner.id, async (h) => {
|
||||
const created = await h.client.callTool({
|
||||
name: 'create_budget_item',
|
||||
arguments: { tripId: trip.id, name: 'Taxi', total_price: 100, member_ids: [owner.id, friend.id] },
|
||||
});
|
||||
const { item } = parseToolResult(created) as { item: { id: number } };
|
||||
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_budget_item',
|
||||
arguments: {
|
||||
tripId: trip.id, itemId: item.id,
|
||||
payers: [],
|
||||
members: [{ user_id: owner.id, amount: 60 }, { user_id: friend.id, amount: 40 }],
|
||||
},
|
||||
});
|
||||
expect(result.isError).toBe(true);
|
||||
expect(errorText(result)).toContain('does not add up');
|
||||
// The item is untouched: the refusal happens before the write.
|
||||
const row = testDb.prepare('SELECT total_price FROM budget_items WHERE id = ?').get(item.id) as any;
|
||||
expect(row.total_price).toBe(100);
|
||||
});
|
||||
});
|
||||
|
||||
it('accepts an empty payer list when the split is empty too', async () => {
|
||||
const { user: owner } = createUser(testDb);
|
||||
const trip = createTrip(testDb, owner.id);
|
||||
await withHarness(owner.id, async (h) => {
|
||||
const created = await h.client.callTool({
|
||||
name: 'create_budget_item',
|
||||
arguments: { tripId: trip.id, name: 'Placeholder', total_price: 50, member_ids: [] },
|
||||
});
|
||||
const { item } = parseToolResult(created) as { item: { id: number } };
|
||||
|
||||
const result = await h.client.callTool({
|
||||
name: 'update_budget_item',
|
||||
arguments: { tripId: trip.id, itemId: item.id, payers: [], members: [] },
|
||||
});
|
||||
expect(result.isError).toBeFalsy();
|
||||
const row = testDb.prepare('SELECT total_price FROM budget_items WHERE id = ?').get(item.id) as any;
|
||||
expect(row.total_price).toBe(0);
|
||||
});
|
||||
});
|
||||
|
||||
it('still certifies a split against the payer sum when every payer is on the trip', async () => {
|
||||
const { user: owner } = createUser(testDb);
|
||||
const { user: friend } = createUser(testDb);
|
||||
const trip = createTrip(testDb, owner.id);
|
||||
addTripMember(testDb, trip.id, friend.id);
|
||||
await withHarness(owner.id, async (h) => {
|
||||
const result = await h.client.callTool({
|
||||
name: 'create_budget_item',
|
||||
arguments: {
|
||||
tripId: trip.id, name: 'Hotel', total_price: 999,
|
||||
payers: [{ user_id: owner.id, amount: 70 }, { user_id: friend.id, amount: 30 }],
|
||||
members: [{ user_id: owner.id, amount: 60 }, { user_id: friend.id, amount: 40 }],
|
||||
},
|
||||
});
|
||||
expect(result.isError).toBeFalsy();
|
||||
const data = parseToolResult(result) as any;
|
||||
// total_price came from the payers, not from the stated 999.
|
||||
const row = testDb.prepare('SELECT total_price FROM budget_items WHERE id = ?').get(data.item.id) as any;
|
||||
expect(row.total_price).toBe(100);
|
||||
const shares = testDb.prepare('SELECT user_id, amount FROM budget_item_members WHERE budget_item_id = ? ORDER BY user_id').all(data.item.id) as any[];
|
||||
expect(shares.map(s => s.amount)).toEqual([60, 40]);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user