fix(storage): stop deleting covers, place images and journey photos another row may still show

Replacing a trip or list cover, changing or deleting a place or saved-place
image and deleting a journey photo removed the bytes at once, without asking
whether a trip copy, a journey, a saved place or another photo row still
named them (#2924). Those paths now leave the object in place and the reclaim
job removes it once no row names it. A journey photo the user deletes takes
its local photo row with it when nothing else links it, so its bytes become
reclaimable instead of being kept by a row nobody sees.

A place image copied from a trip file is still dropped at once when the
update that would name it fails: that copy was never anyone else's.

Size and warning baselines follow the shrunk files.
This commit is contained in:
Maurice
2026-11-01 13:59:28 +01:00
parent 095bed2db8
commit db0fbc1ccd
19 changed files with 101 additions and 317 deletions
@@ -147,6 +147,11 @@ export class TrekPhotosRepository extends TrekRepository<TrekPhotos> {
return await this.nativeDelete({ id, provider: { $ne: 'local' } });
}
/** `DELETE FROM trek_photos WHERE id = ?`, whatever the provider: a photo the user deleted. */
async deleteById(id: number): Promise<number> {
return await this.nativeDelete({ id });
}
/**
* TH1 — `SELECT file_path FROM trek_photos WHERE file_path LIKE 'journey/%'`.
* The caller (`ThumbnailService.sweepOrphanThumbs`) always passes the