fix(plugins): hold plugin data on Postgres to its own schema and to one contract on both engines

The plugin SQL guard now refuses what still reached outside a plugin's
schema or depended on the server:
- reads of the system columns (xmin, xmax, cmin, cmax, ctid, tableoid),
  which show transaction ids and storage layout and do not exist on
  SQLite; a value of the plugin's own may still be named xmin with AS
- the xid and xid8 types wherever the word stands for the type, since
  age() of an xid is the cluster's transaction counter
- the text search functions that coerce a text argument to regconfig, a
  catalog lookup by name, which leave the allowlist
- collations and access methods outside the set every server has, which
  could tell whether a locale or an extension exists

Every plugin transaction pins, with SET LOCAL, the settings that decide
how values print and parse (TimeZone UTC, DateStyle, the C locales, float,
bytea and xml output, the text search configuration), so a plugin's output
neither depends on nor reveals the server's configuration.

Both stores now keep one contract. Its texts and caps live once, in
plugin-data-contract.ts, and both stores throw only those: NUL in SQL,
an argument or a migration id is refused on SQLite as on Postgres,
transaction control is refused in every call on both engines (tx() is
how a batch becomes atomic), a closed store refuses every call, and the
Postgres store answers the cases better-sqlite3 names with its words.
The SQLite store moves beside the Postgres one as SqlitePluginDataStore
in db/engine/sqlite, takes its file from the backend so src/db never
imports src/nest, and no longer needs the driver exemption. A contract
test runs every violation on both stores and fails when they answer
differently. The Postgres lane holds the allowlist, the pinned settings
and the SQL plugins commonly write against a real database.
This commit is contained in:
Maurice
2026-11-18 13:20:07 +01:00
parent cc0fe6ce2b
commit c970245e0d
26 changed files with 1932 additions and 513 deletions
+8 -9
View File
@@ -399,25 +399,24 @@ netmask
network
set_masklen
# Full text search. ts_stat and ts_rewrite run SQL handed to them as text and stay refused.
# Full text search on vectors and queries a plugin builds itself (array_to_tsvector,
# 'a & b'::tsquery). The functions that parse text into them (to_tsvector, to_tsquery,
# plainto_tsquery, phraseto_tsquery, websearch_to_tsquery, json_to_tsvector,
# jsonb_to_tsvector, ts_headline) take a text search configuration, a regconfig looked up
# by a name in a string, so to_tsvector('schema.cfg', ...) tells whether a schema or a
# configuration exists; they stay refused, as do ts_stat and ts_rewrite, which run SQL
# handed to them as text. No function here may take or return a type that looks an object
# up by name (the Postgres lane checks every overload).
array_to_tsvector
json_to_tsvector
jsonb_to_tsvector
numnode
phraseto_tsquery
plainto_tsquery
querytree
setweight
strip
to_tsquery
to_tsvector
ts_delete
ts_filter
ts_headline
ts_rank
ts_rank_cd
tsvector_to_array
websearch_to_tsquery
# The TABLESAMPLE methods (`TABLESAMPLE SYSTEM (10)`).
bernoulli