k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-24 07:53:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(reservations): link a cost created on a booking update on its insert

Browse Source 
syncBudgetOnUpdate created the expense and then set its reservation_id in a
second statement, inside a try that logs and swallows the failure. Running
inside updateWithCost, a failed back-link committed an expense that was not
linked to its booking. The expense is now created through
linkBudgetItemToReservation, which writes the link on the insert, the same
way syncBudgetOnCreate does.
This commit is contained in:
Maurice
2026-10-08 15:56:18 +02:00
parent b84867b4c2
commit c7feaf0a65
3 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/nest/reservations/reservations.service.ts
+2 -3
View File
@@ -1192,9 +1192,8 @@ export class ReservationsService {
const updated = await this.budget.updateBudgetItem(existing.id, tripId, { name: itemName, category, total_price: entry.total_price });
this.sendCost(tripId, { event: 'budget:updated', payload: { item: updated } }, socketId, collect);
} else {
const item = await this.budget.createBudgetItem(tripId, { name: itemName, category, total_price: entry.total_price });
await this.budgetItemsRepo.setReservationId(item.id, id);
item.reservation_id = Number(id);
// The link travels on the insert, so a cost is never written without its booking.
const item = await this.budget.linkBudgetItemToReservation(tripId, Number(id), { name: itemName, category, total_price: entry.total_price! });
this.sendCost(tripId, { event: 'budget:created', payload: { item } }, socketId, collect);
}
} catch (err) {