mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-11-20 19:16:08 +00:00
fix(plugins): pause and suspend plugin frames when they leave the screen
A tester reported that their own plugin, fine on the web, slowed the app down badly on a phone. A sandboxed plugin iframe keeps running its timers, polling and animation even off screen, and on a phone it shares the WebView's main thread with the whole app, so a heavy one janks everything. The frame now watches whether it is on screen and the app in the foreground (IntersectionObserver + page visibility) and forwards it as trek:visibility, so a plugin can pause its work while hidden; the design kit exposes trek.onVisibility / trek.isVisible and pauses its own CSS animations via data-hidden. On a phone a dashboard-widget plugin scrolled well out of view is suspended outright: its iframe is unmounted and a placeholder holds the widget's height, so an offscreen widget costs nothing and remounts when it scrolls back.
This commit is contained in:
@@ -475,6 +475,8 @@ export const TREK_THEME_JS = `(function () {
|
||||
var docEl = document.documentElement;
|
||||
var ctxHandlers = [];
|
||||
var evtHandlers = [];
|
||||
var visHandlers = [];
|
||||
var visible = true;
|
||||
var lastCtx = null;
|
||||
var pending = {};
|
||||
var pendingConfirms = {};
|
||||
@@ -555,6 +557,14 @@ export const TREK_THEME_JS = `(function () {
|
||||
for (var w = 0; w < geoWatchers.length; w++) { try { geoWatchers[w](m.position || null, m.error || null); } catch (e) {} }
|
||||
} else if (m.type === 'trek:event') {
|
||||
for (var j = 0; j < evtHandlers.length; j++) { try { evtHandlers[j](m.event, m.tripId); } catch (e) {} }
|
||||
} else if (m.type === 'trek:visibility') {
|
||||
// The host tells us when this frame leaves the screen or the app goes to the
|
||||
// background. Pause your timers, polling and animation here: a widget that keeps
|
||||
// working off screen bogs down the shared WebView on a phone. data-hidden lets the
|
||||
// kit CSS pause its own animations; onVisibility gets the plugin's own work.
|
||||
visible = m.visible !== false;
|
||||
setFlag('data-hidden', !visible);
|
||||
for (var v = 0; v < visHandlers.length; v++) { try { visHandlers[v](visible); } catch (e) {} }
|
||||
}
|
||||
});
|
||||
|
||||
@@ -635,6 +645,14 @@ export const TREK_THEME_JS = `(function () {
|
||||
if (lastCtx) { try { cb(lastCtx); } catch (e) {} }
|
||||
return function () { var i = ctxHandlers.indexOf(cb); if (i >= 0) { ctxHandlers.splice(i, 1); } };
|
||||
},
|
||||
// Whether the frame is on screen and the app is in the foreground, and a hook for
|
||||
// the changes. Use it to pause heavy work while hidden; isVisible() seeds the first
|
||||
// run. Returns an unsubscribe.
|
||||
isVisible: function () { return visible; },
|
||||
onVisibility: function (cb) {
|
||||
visHandlers.push(cb);
|
||||
return function () { var i = visHandlers.indexOf(cb); if (i >= 0) { visHandlers.splice(i, 1); } };
|
||||
},
|
||||
notify: function (level, message, duration) { send({ type: 'trek:notify', level: level, message: message, duration: duration }); },
|
||||
navigate: function (to) { send({ type: 'trek:navigate', to: to }); },
|
||||
openExternal: function (url) { send({ type: 'trek:openExternal', url: url }); },
|
||||
|
||||
Reference in New Issue
Block a user