k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-24 16:03:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(server): say why the admin domain does not import DatabaseBackupModule

Browse Source 
DatabaseBackupModule stays @Global, but its comment gave a vague reason.
The real one is concrete: the backup domain already reaches admin through
auth and settings, so importing the module from AdminModule would add a
domain cycle that lint:boundaries rejects. The module comment now says
that and points at the e2e harness that imports it by hand, and
AdminModule notes where its DATABASE_BACKUP comes from.
This commit is contained in:
Maurice
2026-10-08 15:40:22 +02:00
parent 175f5d96da
commit b658b5e68d
2 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/nest/admin/admin.module.ts
+4
View File
@@ -24,6 +24,10 @@ import { PackingModule } from '../packing/packing.module';
// not @Global, so the import must be explicit.
import { PermissionsModule } from '../permissions/permissions.module';
import { AppConfigModule } from '../app-config/app-config.module';
// AdminService and DemoResetJob inject DATABASE_BACKUP, which the @Global
// DatabaseBackupModule (nest/backup/) provides once BackupModule is in the
// graph. It is not imported here on purpose: see that module for the cycle an
// import would close.
import { Users } from '../../db/entities/Users.entity';
import { AuditLog } from '../../db/entities/AuditLog.entity';
import { AppSettings } from '../../db/entities/AppSettings.entity';