test: expand test suite to 87.3% backend coverage

Add new integration test files covering previously untested routes:
- categories.test.ts — GET /api/categories
- oidc.test.ts — full OIDC login flow (callback, state, errors)
- settings.test.ts — GET/PUT /api/settings, bulk save
- tags.test.ts — CRUD for trip tags
- todo.test.ts — todo items CRUD and reorder

Add new unit test files covering service-layer logic:
- adminService.test.ts — user/invite management, packing templates, OIDC settings
- atlasService.test.ts — atlas search and place enrichment
- authServiceDb.test.ts — DB-backed auth helpers (login, register, MFA)
- backupService.test.ts — export/import/restore logic
- categoryService.test.ts — category CRUD
- dayService.test.ts — day management and accommodation helpers
- mapsService.test.ts — route/directions helpers
- oidcService.test.ts — OIDC state, auth code, role resolution, user upsert
- packingService.test.ts — packing item/bag/template operations
- placeService.test.ts — place CRUD and tag attachment
- settingsService.test.ts — settings get/set/bulk
- tagService.test.ts — tag CRUD
- todoService.test.ts — todo CRUD and reorder
- tripService.test.ts — trip CRUD, member management, archiving
- vacayService.test.ts — vacay integration helpers
- tripAccess.test.ts (middleware) — requireTripAccess middleware

Expand existing integration and unit test files with additional cases
across admin, atlas, auth, backup, collab, days, files, maps, memories
(Immich/Synology), notifications, places, reservations, share, vacay,
weather, auth middleware, ephemeral tokens, notification preferences,
permissions, SSRF guard, and WebSocket connection tests.

Update test helpers (factories.ts, test-db.ts) with new factory
functions and seed data required by the expanded suite.

Fix minor issues in server/src/routes/reservations.ts and
server/src/services/atlasService.ts surfaced by new test coverage.

Update sonar-project.properties to reflect new coverage thresholds.
This commit is contained in:
jubnl
2026-04-06 20:06:46 +02:00
parent 5bcadb3cc6
commit b4922322ae
49 changed files with 12177 additions and 36 deletions
@@ -68,4 +68,49 @@ describe('ephemeralTokens', () => {
expect(result).toBeNull();
});
});
describe('startTokenCleanup / stopTokenCleanup', () => {
it('startTokenCleanup starts the interval (second call is no-op)', async () => {
vi.useFakeTimers();
const { createEphemeralToken, consumeEphemeralToken, startTokenCleanup, stopTokenCleanup } = await getModule();
startTokenCleanup();
startTokenCleanup(); // should be no-op, not throw
// Token created while cleanup is running should still be consumable (interval hasn't fired)
const token = createEphemeralToken(1, 'ws')!;
expect(consumeEphemeralToken(token, 'ws')).toBe(1);
stopTokenCleanup();
vi.useRealTimers();
});
it('stopTokenCleanup clears the interval and allows restart', async () => {
vi.useFakeTimers();
const { createEphemeralToken, consumeEphemeralToken, startTokenCleanup, stopTokenCleanup } = await getModule();
startTokenCleanup();
stopTokenCleanup();
stopTokenCleanup(); // calling stop twice should not throw
startTokenCleanup(); // should be able to start again after stop
stopTokenCleanup();
// After stop, tokens should still be consumable (cleanup didn't run)
const token = createEphemeralToken(2, 'download')!;
expect(consumeEphemeralToken(token, 'download')).toBe(2);
vi.useRealTimers();
});
it('cleanup interval removes expired tokens', async () => {
vi.useFakeTimers();
const { createEphemeralToken, consumeEphemeralToken, startTokenCleanup, stopTokenCleanup } = await getModule();
startTokenCleanup();
const token = createEphemeralToken(1, 'ws')!; // 30s TTL
// Advance past TTL AND past cleanup interval (60s)
vi.advanceTimersByTime(65_000);
// Token should have been cleaned up by the interval
const result = consumeEphemeralToken(token, 'ws');
expect(result).toBeNull();
stopTokenCleanup();
vi.useRealTimers();
});
});
});