mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-11-20 11:06:06 +00:00
feat(db): keep a plugin's own data in a Postgres schema of its own
A plugin with db:own got a SQLite WAL file in the data volume whatever the engine, so a Postgres install still needed a local disk (discussion #386). This adds the plugin data port (db/engine/plugin-data.ts) and its Postgres side: one schema per plugin, trek_plugin_<id>, reached through TREK's pool. Every call runs in a transaction that creates the schema if missing, puts only it on the search_path and sets statement_timeout to the call's budget. Reads stream through a cursor and stop at the row cap, a write that grows the schema past the quota rolls back, and the calls of one plugin run one at a time on at most half of the pool. TREK's role may read every table, and a role per plugin would need CREATEROLE, so plugin-sql-guard.ts checks each statement first: it lexes the SQL as Postgres does and refuses another schema as a qualifier, the pg_ catalogs and functions, functions that run SQL from a string or reach an object by a name in one, temporary tables, and every statement but DML and DDL on tables, indexes, views, sequences and types.
This commit is contained in:
@@ -0,0 +1,400 @@
|
||||
import { PLUGIN_SCHEMA_PREFIX } from './plugin-schema';
|
||||
|
||||
/**
|
||||
* What keeps a plugin's own SQL on Postgres inside its own schema.
|
||||
*
|
||||
* On SQLite a plugin's database is a file of its own, so it cannot name
|
||||
* TREK's tables at all. On Postgres its schema sits in TREK's database and
|
||||
* its statements run as TREK's role, which may read every table TREK has: a
|
||||
* role per plugin would need CREATEROLE, which TREK's role is not given. So
|
||||
* the statement itself is held to what cannot leave the schema, before it
|
||||
* runs, and the transaction it runs in names only that schema on its
|
||||
* `search_path`, so an unqualified name finds nothing else.
|
||||
*
|
||||
* The SQL is split into tokens the way Postgres's own lexer splits it (string
|
||||
* and identifier quoting, comments, dollar signs), and refused when it holds:
|
||||
*
|
||||
* - a statement other than SELECT, INSERT, UPDATE, DELETE, MERGE, WITH,
|
||||
* VALUES, TABLE, TRUNCATE, REFRESH, or a CREATE, ALTER or DROP of a table,
|
||||
* index, view, materialized view, sequence or type. No function, schema,
|
||||
* role, setting, transaction control, COPY, LOCK, prepared statement or
|
||||
* notification. Several statements are split at their semicolons and each
|
||||
* is checked;
|
||||
* - a qualified name whose qualifier is another schema of the database
|
||||
* (`public.users`, another plugin's schema), or any name starting with
|
||||
* `pg_` or naming `information_schema`: the catalogs, the server functions
|
||||
* and the temporary schema;
|
||||
* - a function that runs SQL handed to it as text (`query_to_xml`, `ts_stat`,
|
||||
* `ts_rewrite`), reads or changes settings (`set_config`,
|
||||
* `current_setting`), reaches objects by a name in a string (`nextval`,
|
||||
* `setval`, the `reg*` casts), large objects (`lo_*`) or `dblink`;
|
||||
* - a temporary table (`CREATE TEMP`, `SELECT ... INTO`), which would outlive
|
||||
* the call on a pooled connection another plugin uses next, and
|
||||
* `WITH RECURSIVE`, refused on SQLite too;
|
||||
* - in an ALTER, a change of a table's schema, owner or tablespace;
|
||||
* - escape strings (`E'...'`), Unicode escapes (`U&'...'`), dollar-quoted
|
||||
* strings and a number running straight into a name, whose reading
|
||||
* differs between Postgres versions and settings.
|
||||
*
|
||||
* An alias that happens to share a schema's name (`auth.id` on a database
|
||||
* that has an `auth` schema) is refused too; the plugin renames the alias.
|
||||
*/
|
||||
|
||||
/** Why a plugin's SQL is refused. The message is the plugin's to read, so it says what to change. */
|
||||
export class PluginSqlRefused extends Error {
|
||||
constructor(reason: string) {
|
||||
super(`statement type not allowed for plugin databases: ${reason}`);
|
||||
this.name = 'PluginSqlRefused';
|
||||
}
|
||||
}
|
||||
|
||||
/** One token of plugin SQL. A word is a name or a keyword: `value` is folded to lower case unless it was quoted. */
|
||||
type Token = (
|
||||
| { kind: 'word'; value: string; quoted: boolean }
|
||||
| { kind: 'string' }
|
||||
| { kind: 'number' }
|
||||
| { kind: 'param' }
|
||||
| { kind: 'punct'; value: string }
|
||||
) & {
|
||||
/** Where the token starts in the SQL text. */
|
||||
at: number;
|
||||
};
|
||||
|
||||
/** One statement of plugin SQL: its tokens, without the semicolon that ended it. */
|
||||
export interface PluginStatement {
|
||||
/** The statement's own text, as Postgres is handed it. */
|
||||
readonly text: string;
|
||||
readonly tokens: readonly Token[];
|
||||
/** Whether it returns rows: a SELECT, VALUES or TABLE, or anything with a RETURNING clause. */
|
||||
readonly returnsRows: boolean;
|
||||
/** Whether it may change data or schema, which is what the disk quota is checked after. */
|
||||
readonly mayWrite: boolean;
|
||||
/** Whether it names a qualified object (`x.y`), which needs the database's schema names to check. */
|
||||
readonly qualifies: boolean;
|
||||
/** How many `$n` placeholders it holds. */
|
||||
readonly params: number;
|
||||
}
|
||||
|
||||
/** Postgres keeps the first 63 bytes of a name (NAMEDATALEN - 1) and drops the rest. */
|
||||
const MAX_NAME_BYTES = 63;
|
||||
|
||||
/** The first word of each statement a plugin may run. */
|
||||
const STATEMENTS = new Set([
|
||||
'select',
|
||||
'insert',
|
||||
'update',
|
||||
'delete',
|
||||
'merge',
|
||||
'with',
|
||||
'values',
|
||||
'table',
|
||||
'truncate',
|
||||
'refresh',
|
||||
'create',
|
||||
'alter',
|
||||
'drop',
|
||||
]);
|
||||
|
||||
/** Transaction control: every call already runs in a transaction of the host's. */
|
||||
const TRANSACTION_CONTROL = new Set(['begin', 'start', 'commit', 'end', 'rollback', 'abort', 'savepoint', 'release']);
|
||||
|
||||
/** What a CREATE, ALTER or DROP may act on. */
|
||||
const OBJECTS = new Set(['table', 'index', 'view', 'materialized', 'sequence', 'type']);
|
||||
|
||||
/** The words that make up a statement's main verb, after a WITH clause. */
|
||||
const VERBS = new Set(['select', 'insert', 'update', 'delete', 'merge', 'values', 'table']);
|
||||
|
||||
/** The verbs of a statement that only reads. */
|
||||
const READ_VERBS = new Set(['select', 'values', 'table']);
|
||||
|
||||
/** Functions and types refused under any spelling, quoted or not. */
|
||||
const REFUSED_NAMES = new Set([
|
||||
'set_config',
|
||||
'current_setting',
|
||||
'ts_stat',
|
||||
'ts_rewrite',
|
||||
'nextval',
|
||||
'setval',
|
||||
'currval',
|
||||
'lastval',
|
||||
'loread',
|
||||
'lowrite',
|
||||
'regclass',
|
||||
'regproc',
|
||||
'regprocedure',
|
||||
'regoper',
|
||||
'regoperator',
|
||||
'regnamespace',
|
||||
'regrole',
|
||||
'regcollation',
|
||||
'information_schema',
|
||||
]);
|
||||
|
||||
/** Name prefixes refused under any spelling. */
|
||||
const REFUSED_PREFIXES = ['pg_', 'lo_', 'dblink', 'to_reg', 'binary_upgrade_'];
|
||||
|
||||
/** A name refused wherever it appears: the XML exports of a query, a table, a schema or the database. */
|
||||
const XML_EXPORT = /_to_xml/;
|
||||
|
||||
/** Starts a name: a letter, an underscore or any character past ASCII, as Postgres reads it. */
|
||||
const NAME_START = /[A-Za-z_\u0080-]/;
|
||||
/** Continues a name; a dollar sign is part of one. */
|
||||
const NAME_PART = /[A-Za-z0-9_$\u0080-]/;
|
||||
/** The single-character punctuation and operator characters. */
|
||||
const PUNCT = new Set([...'.,()[];+-*/<>=~!@#%^&|?']);
|
||||
|
||||
/** `name` lower-cased the way Postgres folds an unquoted name: ASCII letters only. */
|
||||
function fold(name: string): string {
|
||||
return name.replace(/[A-Z]/g, (c) => c.toLowerCase());
|
||||
}
|
||||
|
||||
/** `name` cut to the bytes Postgres keeps of it, never in the middle of a character. */
|
||||
function truncateName(name: string): string {
|
||||
if (Buffer.byteLength(name, 'utf8') <= MAX_NAME_BYTES) return name;
|
||||
let out = '';
|
||||
for (const ch of name) {
|
||||
if (Buffer.byteLength(out + ch, 'utf8') > MAX_NAME_BYTES) break;
|
||||
out += ch;
|
||||
}
|
||||
return out;
|
||||
}
|
||||
|
||||
/** Splits `sql` into tokens, or refuses what this guard does not read the way Postgres would. */
|
||||
export function tokenize(sql: string): Token[] {
|
||||
const tokens: Token[] = [];
|
||||
let i = 0;
|
||||
const n = sql.length;
|
||||
while (i < n) {
|
||||
const at = i;
|
||||
const c = sql[i];
|
||||
const next = sql[i + 1];
|
||||
if (/\s/.test(c)) {
|
||||
i++;
|
||||
} else if (c === '-' && next === '-') {
|
||||
while (i < n && sql[i] !== '\n') i++;
|
||||
} else if (c === '/' && next === '*') {
|
||||
i = skipBlockComment(sql, i);
|
||||
} else if (c === "'") {
|
||||
i = skipQuoted(sql, i, "'", 'a string');
|
||||
tokens.push({ kind: 'string', at });
|
||||
} else if (c === '"') {
|
||||
const end = skipQuoted(sql, i, '"', 'a quoted name');
|
||||
const value = sql.slice(i + 1, end - 1).replaceAll('""', '"');
|
||||
if (value === '') throw new PluginSqlRefused('a quoted name may not be empty');
|
||||
tokens.push({ kind: 'word', value: truncateName(value), quoted: true, at });
|
||||
i = end;
|
||||
} else if (c === '$') {
|
||||
if (!/[0-9]/.test(next ?? '')) {
|
||||
throw new PluginSqlRefused('dollar-quoted strings are not accepted; write the string in single quotes');
|
||||
}
|
||||
i++;
|
||||
while (i < n && /[0-9]/.test(sql[i])) i++;
|
||||
tokens.push({ kind: 'param', at });
|
||||
} else if (/[0-9]/.test(c) || (c === '.' && /[0-9]/.test(next ?? ''))) {
|
||||
i = skipNumber(sql, i);
|
||||
if (i < n && NAME_PART.test(sql[i])) {
|
||||
throw new PluginSqlRefused('a number may not run straight into a name; put a space between them');
|
||||
}
|
||||
tokens.push({ kind: 'number', at });
|
||||
} else if (NAME_START.test(c)) {
|
||||
if ((c === 'e' || c === 'E') && next === "'") {
|
||||
throw new PluginSqlRefused("escape strings (E'...') are not accepted; write the string in single quotes");
|
||||
}
|
||||
if ((c === 'u' || c === 'U') && next === '&' && (sql[i + 2] === "'" || sql[i + 2] === '"')) {
|
||||
throw new PluginSqlRefused('Unicode escapes (U&) are not accepted');
|
||||
}
|
||||
while (i < n && NAME_PART.test(sql[i])) i++;
|
||||
tokens.push({ kind: 'word', value: truncateName(fold(sql.slice(at, i))), quoted: false, at });
|
||||
} else if (c === ':' && next === ':') {
|
||||
tokens.push({ kind: 'punct', value: '::', at });
|
||||
i += 2;
|
||||
} else if (c === ':' || PUNCT.has(c)) {
|
||||
tokens.push({ kind: 'punct', value: c, at });
|
||||
i++;
|
||||
} else {
|
||||
throw new PluginSqlRefused(`unexpected character ${JSON.stringify(c)}`);
|
||||
}
|
||||
}
|
||||
return tokens;
|
||||
}
|
||||
|
||||
/** The index past a block comment starting at `start`; Postgres nests them. */
|
||||
function skipBlockComment(sql: string, start: number): number {
|
||||
let depth = 0;
|
||||
let i = start;
|
||||
while (i < sql.length) {
|
||||
if (sql[i] === '/' && sql[i + 1] === '*') {
|
||||
depth++;
|
||||
i += 2;
|
||||
} else if (sql[i] === '*' && sql[i + 1] === '/') {
|
||||
depth--;
|
||||
i += 2;
|
||||
if (depth === 0) return i;
|
||||
} else {
|
||||
i++;
|
||||
}
|
||||
}
|
||||
throw new PluginSqlRefused('a comment is not closed');
|
||||
}
|
||||
|
||||
/** The index past a quoted string or name starting at `start`; a doubled quote stands for one. */
|
||||
function skipQuoted(sql: string, start: number, quote: string, what: string): number {
|
||||
let i = start + 1;
|
||||
while (i < sql.length) {
|
||||
if (sql[i] === quote) {
|
||||
if (sql[i + 1] === quote) {
|
||||
i += 2;
|
||||
continue;
|
||||
}
|
||||
return i + 1;
|
||||
}
|
||||
i++;
|
||||
}
|
||||
throw new PluginSqlRefused(`${what} is not closed`);
|
||||
}
|
||||
|
||||
/** The index past a numeric constant starting at `start`: decimal, with a fraction and an exponent, or 0x/0o/0b. */
|
||||
function skipNumber(sql: string, start: number): number {
|
||||
const rest = sql.slice(start);
|
||||
const match =
|
||||
/^0[xX][0-9a-fA-F_]+|^0[oO][0-7_]+|^0[bB][01_]+|^(?:[0-9][0-9_]*(?:\.[0-9_]*)?|\.[0-9][0-9_]*)(?:[eE][+-]?[0-9]+)?/.exec(
|
||||
rest,
|
||||
);
|
||||
return start + (match ? match[0].length : 1);
|
||||
}
|
||||
|
||||
/** Splits `sql` into its statements, each checked on its own; empty ones (`;;`, a comment) are dropped. */
|
||||
export function parsePluginSql(sql: string): PluginStatement[] {
|
||||
const statements: PluginStatement[] = [];
|
||||
let current: Token[] = [];
|
||||
const flush = (end: number) => {
|
||||
if (current.length > 0) statements.push(describe(sql.slice(current[0].at, end).trimEnd(), current));
|
||||
current = [];
|
||||
};
|
||||
for (const token of tokenize(sql)) {
|
||||
if (token.kind === 'punct' && token.value === ';') flush(token.at);
|
||||
else current.push(token);
|
||||
}
|
||||
flush(sql.length);
|
||||
return statements;
|
||||
}
|
||||
|
||||
/** The unquoted keyword at `token`, or null for anything else. */
|
||||
function keyword(token: Token | undefined): string | null {
|
||||
return token?.kind === 'word' && !token.quoted ? token.value : null;
|
||||
}
|
||||
|
||||
/** Reads what a statement's caller needs to know about it, and refuses one this guard does not allow. */
|
||||
function describe(text: string, tokens: Token[]): PluginStatement {
|
||||
const first = tokens[0];
|
||||
const opensWithParen = first.kind === 'punct' && first.value === '(';
|
||||
const verb = opensWithParen ? 'select' : keyword(first);
|
||||
if (verb !== null && TRANSACTION_CONTROL.has(verb)) {
|
||||
throw new PluginSqlRefused(
|
||||
'transaction-control statements are not allowed: each call runs in its own transaction, and tx() makes a batch atomic',
|
||||
);
|
||||
}
|
||||
if (verb === null || !STATEMENTS.has(verb)) {
|
||||
throw new PluginSqlRefused(`a statement may not start with ${describeToken(first)}`);
|
||||
}
|
||||
if (verb === 'create' || verb === 'alter' || verb === 'drop' || verb === 'refresh') checkObject(verb, tokens);
|
||||
|
||||
let depth = 0;
|
||||
let main: string | null = verb === 'with' ? null : verb;
|
||||
let returning = false;
|
||||
let selectInto = false;
|
||||
let params = 0;
|
||||
let qualifies = false;
|
||||
for (const [index, token] of tokens.entries()) {
|
||||
if (token.kind === 'param') params++;
|
||||
if (token.kind === 'punct' && token.value === '(') depth++;
|
||||
if (token.kind === 'punct' && token.value === ')') depth--;
|
||||
if (token.kind !== 'word') continue;
|
||||
checkName(token.value);
|
||||
const after = tokens[index + 1];
|
||||
if (after?.kind === 'punct' && after.value === '.') qualifies = true;
|
||||
if (token.quoted) continue;
|
||||
if (token.value === 'recursive') throw new PluginSqlRefused('WITH RECURSIVE is not allowed');
|
||||
if (token.value === 'tablespace') throw new PluginSqlRefused('a tablespace may not be named');
|
||||
if (verb === 'alter' && (token.value === 'schema' || token.value === 'owner')) {
|
||||
throw new PluginSqlRefused(`an ALTER may not change the ${token.value}`);
|
||||
}
|
||||
if (depth !== 0) continue;
|
||||
if (main === null && VERBS.has(token.value)) main = token.value;
|
||||
if (token.value === 'returning') returning = true;
|
||||
if (token.value === 'into' && main === 'select') selectInto = true;
|
||||
}
|
||||
if (selectInto) throw new PluginSqlRefused('SELECT ... INTO is not allowed; use CREATE TABLE ... AS');
|
||||
|
||||
const reads = main !== null && READ_VERBS.has(main);
|
||||
const writesInside = tokens.some((t) => {
|
||||
const word = keyword(t);
|
||||
return word !== null && ['insert', 'update', 'delete', 'merge'].includes(word);
|
||||
});
|
||||
return {
|
||||
text,
|
||||
tokens,
|
||||
returnsRows: reads || returning,
|
||||
mayWrite: !reads || writesInside,
|
||||
qualifies,
|
||||
params,
|
||||
};
|
||||
}
|
||||
|
||||
/** Refuses a CREATE, ALTER, DROP or REFRESH of anything but the objects a plugin keeps in its schema. */
|
||||
function checkObject(verb: string, tokens: readonly Token[]): void {
|
||||
let at = 1;
|
||||
if (verb === 'create') {
|
||||
if (keyword(tokens[at]) === 'or' && keyword(tokens[at + 1]) === 'replace') at += 2;
|
||||
while (keyword(tokens[at]) === 'unique' || keyword(tokens[at]) === 'unlogged') at++;
|
||||
}
|
||||
const object = keyword(tokens[at]);
|
||||
const allowed = verb === 'refresh' ? object === 'materialized' : object !== null && OBJECTS.has(object);
|
||||
if (!allowed) {
|
||||
throw new PluginSqlRefused(`${verb.toUpperCase()} ${describeToken(tokens[at])} is not allowed`);
|
||||
}
|
||||
}
|
||||
|
||||
/** Refuses a name that reaches past the plugin's schema whatever qualifies it. */
|
||||
function checkName(name: string): void {
|
||||
if (REFUSED_NAMES.has(name) || REFUSED_PREFIXES.some((p) => name.startsWith(p)) || XML_EXPORT.test(name)) {
|
||||
throw new PluginSqlRefused(`"${name}" may not be named in a plugin's SQL`);
|
||||
}
|
||||
}
|
||||
|
||||
/** A token as an error message shows it. */
|
||||
function describeToken(token: Token | undefined): string {
|
||||
if (token === undefined) return 'nothing';
|
||||
if (token.kind === 'word') return token.quoted ? `"${token.value}"` : token.value.toUpperCase();
|
||||
if (token.kind === 'punct') return `"${token.value}"`;
|
||||
return `a ${token.kind}`;
|
||||
}
|
||||
|
||||
/**
|
||||
* Refuses a qualified name in `statement` whose qualifier is a schema other
|
||||
* than `ownSchema`: one of `schemas` (every schema of the database), or one
|
||||
* named like a plugin schema even before it exists.
|
||||
*/
|
||||
export function checkQualifiers(statement: PluginStatement, ownSchema: string, schemas: ReadonlySet<string>): void {
|
||||
const { tokens } = statement;
|
||||
for (const [index, token] of tokens.entries()) {
|
||||
const after = tokens[index + 1];
|
||||
if (token.kind !== 'word' || after?.kind !== 'punct' || after.value !== '.') continue;
|
||||
if (token.value === ownSchema) continue;
|
||||
if (schemas.has(token.value) || token.value.startsWith(PLUGIN_SCHEMA_PREFIX) || token.value === 'public') {
|
||||
throw new PluginSqlRefused(`"${token.value}" is another schema; a plugin reaches its own tables only`);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Refuses `?` placeholders where bound args were given: Postgres numbers its
|
||||
* placeholders `$1`, `$2`, ..., and reads a `?` as an operator.
|
||||
*/
|
||||
export function checkPlaceholders(statement: PluginStatement, args: readonly unknown[]): void {
|
||||
if (args.length === 0 || statement.params > 0) return;
|
||||
const questionMark = statement.tokens.some((t) => t.kind === 'punct' && t.value === '?');
|
||||
if (questionMark) {
|
||||
throw new PluginSqlRefused('this TREK runs on Postgres, which numbers its placeholders $1, $2, ... instead of ?');
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user