k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-20 22:16:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sdk): allow empty egress if and only if operatorEgress is true

Browse Source
This commit is contained in:
jubnl
2026-07-11 20:06:54 +02:00
parent a4972f8f13
commit ac201deb35
9 changed files with 127 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/nest/plugins/install/manifest.ts
+10 -2
View File
@@ -167,8 +167,16 @@ export function parseManifest(raw: unknown): PluginManifest {
if (m.operatorEgress === true && !permissions.some((p) => p === 'http:outbound' || p.startsWith('http:outbound:'))) {
throw new ManifestError('operatorEgress requires an http:outbound permission');
}
if (permissions.some((p) => p === 'http:outbound' || p.startsWith('http:outbound:')) && egress.length === 0) {
throw new ManifestError('http:outbound declared but egress[] is empty');
// An empty egress[] is only legal for an operatorEgress plugin: its hosts are
// admin-supplied post-install, so the manifest has nothing to declare. It is NOT
// an allow-all — the child's guard is built from the (still empty) union, so every
// outbound call is refused until an admin adds a host.
if (
permissions.some((p) => p === 'http:outbound' || p.startsWith('http:outbound:')) &&
egress.length === 0 &&
m.operatorEgress !== true
) {
throw new ManifestError('http:outbound declared but egress[] is empty (set operatorEgress: true if the hosts are admin-supplied)');
}
if (egress.includes('*')) throw new ManifestError('egress[] must not contain a bare "*"');
const badEgress = egress.find((h) => !HOST_RE.test(h));