k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-11-14 00:01:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(wanderer): say so when wanderer names no author for the token's account

Browse Source 
A token whose account has no local ActivityPub author was reported as
invalid_response, which the settings show as 'The answer did not come from
wanderer', although wanderer had answered fine. It now has its own code,
no_author, with a message in every language that says what is missing.
This commit is contained in:
Maurice
2026-10-25 17:57:32 +01:00
parent 217a576e16
commit a48dd7645f
30 changed files with 64 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/nest/wanderer/wanderer.client.ts
+7 -1
View File
@@ -259,7 +259,13 @@ export class WandererClient {
const actors = (user.expand?.activitypub_actors_via_user ?? [])
.filter((actor) => actor.is_local !== false && isTrailId(actor.id))
.map((actor) => actor.id);
if (actors.length === 0) throw new WandererError('invalid_response', 'wanderer named no author for the token');
if (actors.length === 0) {
throw new WandererError(
'no_author',
'wanderer named no author for the token',
'no local actor in activitypub_actors_via_user',
);
}
return actors;
}
server/tests/unit/nest/wanderer.client.test.ts
+5 -2
View File
@@ -131,14 +131,17 @@ describe('WandererClient', () => {
expect((await failure(() => client.check(CREDS))).code).toBe('unauthorized');
});
it('RS-03: an owner without a local author, or with an odd id, is an answer TREK does not trust', async () => {
it('RS-03: an owner without a local author is told as such; an odd id is an answer TREK does not trust', async () => {
answer({
...OWNER,
'/api/v1/user/gixauk8ukjpqabm': reply({
expand: { activitypub_actors_via_user: [{ id: 'remote1', is_local: false }] },
}),
});
expect((await failure(() => client.ownActors(CREDS))).code).toBe('invalid_response');
// wanderer did answer, so the reason is the missing author, not an answer from somewhere else.
expect((await failure(() => client.ownActors(CREDS))).code).toBe('no_author');
answer({ ...OWNER, '/api/v1/user/gixauk8ukjpqabm': reply({}) });
expect((await failure(() => client.ownActors(CREDS))).code).toBe('no_author');
answer({ '/api/v1/api-token': reply({ items: [{ user: 'Not-An-Id!' }] }) });
expect((await failure(() => client.ownActors(CREDS))).code).toBe('invalid_response');