k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-18 21:16:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

revert(collections): a saved place carries no price, website or phone again

Browse Source 
Takes back the editable price, currency, website and phone on collection
places from 0df82185b and its review follow-up in a910c2a83. Costs are kept
inside a trip only; a collection does not carry them, and #2471 is a
feature request rather than a bug. The collection files are back to how
they were before, including the dimmed save button from f16698bdb, which
only mattered for the price field.
This commit is contained in:
Maurice
2026-09-23 20:32:41 +02:00
parent f16698bdb1
commit a1d6348c5f
40 changed files with 25 additions and 937 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/tests/unit/mcp/tools-collections.test.ts
-58
View File
@@ -380,64 +380,6 @@ describe('Tool: update_collection_place / set_collection_place_status / rate_col
expect(cleared.place.rating_count).toBe(0);
});
});
// #2471: the tool spreads the REST update contract, so the four fields the
// contract gained arrive here too; the strict shape still refuses the rest.
it('sets price, currency, website and phone, refuses a bad price and still refuses an unknown key', async () => {
const { user } = createUser(testDb);
const col = seedCollection(user.id, 'P');
const pid = seedPlace(col, user.id, 'Pergamon');
await withHarness(user.id, async (h) => {
const upd = parseToolResult(await h.client.callTool({
name: 'update_collection_place',
arguments: { placeId: pid, price: 14, currency: 'eur', website: 'https://pergamon.example', phone: '+49 30 266 42 42 42' },
})) as { place: { price: number; currency: string; website: string; phone: string } };
expect(upd.place).toMatchObject({ price: 14, currency: 'EUR', website: 'https://pergamon.example', phone: '+49 30 266 42 42 42' });
const negative = await h.client.callTool({ name: 'update_collection_place', arguments: { placeId: pid, price: -3 } });
expect(negative.isError).toBe(true);
const unknown = await h.client.callTool({ name: 'update_collection_place', arguments: { placeId: pid, entry_fee: 14 } });
expect(unknown.isError).toBe(true);
expect(errorText(unknown)).toMatch(/Unrecognized key.*entry_fee/);
const stored = testDb.prepare('SELECT price, currency FROM collection_places WHERE id = ?').get(pid);
expect(stored).toEqual({ price: 14, currency: 'EUR' });
});
});
// The contract takes price and currency as separate fields; the service holds
// them together, so an agent cannot leave a bare amount on a place without one.
it('refuses a price without a currency on a place that has none', async () => {
const { user } = createUser(testDb);
const col = seedCollection(user.id, 'P');
const pid = seedPlace(col, user.id, 'Pergamon');
await withHarness(user.id, async (h) => {
const bare = await h.client.callTool({ name: 'update_collection_place', arguments: { placeId: pid, price: 14 } });
expect(bare.isError).toBe(true);
expect(errorText(bare)).toMatch(/currency/);
expect(testDb.prepare('SELECT price, currency FROM collection_places WHERE id = ?').get(pid)).toEqual({ price: null, currency: null });
const paired = parseToolResult(await h.client.callTool({
name: 'update_collection_place', arguments: { placeId: pid, price: 14, currency: 'EUR' },
})) as { place: { price: number; currency: string } };
expect(paired.place).toMatchObject({ price: 14, currency: 'EUR' });
});
});
it('describes the price as a rough cost that needs its currency', async () => {
const { user } = createUser(testDb);
const h = await createMcpHarness({ userId: user.id, withResources: false });
try {
const tool = (await h.client.listTools()).tools.find((t) => t.name === 'update_collection_place');
expect(tool?.description).toMatch(/price with currency/);
expect(Object.keys((tool?.inputSchema as { properties: Record<string, unknown> }).properties)).toEqual(
expect.arrayContaining(['price', 'currency', 'website', 'phone']),
);
} finally {
await h.cleanup();
}
});
});
// ---------------------------------------------------------------------------