fix(db): count every spelling of an engine check in lint:engine-dispatch

The gate matched only isSqlite(/isPostgres(, instanceof on a platform class
and a comparison on a property named engine or id. A destructured engine name,
the literal on the left, a switch over the engine, instanceof on a driver class
and a comparison with a driver class all passed with an empty baseline, and
standalone-orm.ts already held one such check. The regex now matches every one
of them, the guard in standalone-orm.ts moves into the engine port as
assertSqliteOrmConfig, and the advice names where a check belongs.
This commit is contained in:
Maurice
2026-11-17 21:27:41 +01:00
parent 8179d7d707
commit 9eeb59997e
5 changed files with 66 additions and 16 deletions
@@ -63,6 +63,26 @@ describe('lint:engine-dispatch', () => {
expect(countEngineDispatch(`// ${IS_SQLITE}\n/* ${INSTANCE} */\nconst ok = 1;`)).toBe(0);
});
it.each([
['a destructured name', ["const { engine } = readEnv().db; if (engine === 'post", "gres') a();"].join('')],
['the literal on the left', ["if ('sql", "ite' !== kind) a();"].join('')],
['a switch', ["switch (readEnv().db.engine) { case 'post", "gres': a(); }"].join('')],
['instanceof on a driver', ['if (em.getDriver() instanceof PostgreSql', 'Driver) a();'].join('')],
['instanceof on our own driver', ['if (d instanceof TrekPostgreSql', 'Driver) a();'].join('')],
['a comparison with a driver class', ['if (config.driver !== SharedSqlite', 'Driver) a();'].join('')],
])('ENGDISP-005: counts an engine check spelled as %s', (_what, code) => {
expect(countEngineDispatch(code)).toBe(1);
const domain = run(serverRoot({ 'src/nest/trips/trips.service.ts': `${code}\n` }));
expect(domain.status).toBe(1);
expect(domain.out).toContain('src/nest/trips/trips.service.ts');
expect(domain.out).toContain('src/db/engine/');
});
it('ENGDISP-006: leaves names that only look like an engine alone', () => {
expect(countEngineDispatch("if (format === 'sqlite3') a(); const label = 'postgres';")).toBe(0);
expect(countEngineDispatch('if (driver === LocalDriver) a(); if (x instanceof S3Driver) b();')).toBe(0);
});
it('ENGDISP-002: the dialect layer and the engine port may dispatch, any other file may not', () => {
const text = `export const x = ${IS_SQLITE};\n`;
expect(run(serverRoot({ 'src/db/dialect/a.ts': text, 'src/db/engine/sqlite/b.ts': text })).status).toBe(0);