fix(storage): release a deleted journey's photos and a deleted list's images, and keep one bad key from stopping a category

Deleting a journey left its uploaded photos behind for good, and deleting
a list queued neither its cover nor its place images. An object with a key
the store refuses no longer fails every night's pass, and the admin view
keeps the counts of a category skipped for a running backup.
This commit is contained in:
Maurice
2026-11-05 13:02:26 +01:00
parent 402a02a302
commit 9dd58fe32f
26 changed files with 350 additions and 17 deletions
@@ -145,6 +145,17 @@ export class CollectionPlacesRepository extends TrekRepository<CollectionPlaces>
return row?.image_url;
}
/** `deleteCollection`'s pre-delete read: every saved place's image, released once the list and its places are gone. */
async imageUrlsOf(collectionId: number): Promise<Array<string | null>> {
const rows = await this.db_()
.selectFrom('collection_places')
.select('image_url')
.where('collection_id', '=', collectionId)
.where('image_url', 'is not', null)
.execute();
return rows.map((row) => row.image_url);
}
/**
* CL48 (`updatePlace`, TX) — the allow-listed dynamic `UPDATE
* collection_places SET ... WHERE id=?`, including the cross-list move
@@ -52,6 +52,19 @@ type JourneyListKyselyDB = Pick<
/** The `journeys`/`journey_contributors` tables {@link JourneysRepository.listRecipientUserIds} reads. */
type JourneyRecipientsKyselyDB = Pick<DB, 'journeys' | 'journey_contributors'>;
/** The tables {@link JourneysRepository.listGalleryPhotos} and {@link JourneysRepository.deleteUnlinkedPhotos} touch. */
type JourneyPhotoFilesKyselyDB = Pick<DB, 'journeys' | 'journey_photos' | 'trek_photos' | 'trip_photos'>;
/** A photo behind a journey's gallery, with the stored paths its row names. */
export interface JourneyGalleryPhotoFiles {
photo_id: number;
file_path: string | null;
thumbnail_path: string | null;
}
/** Ids per DELETE, well under SQLite's bound-parameter limit. */
const PHOTO_DELETE_BATCH = 500;
/**
* `journeys` — the root of the journey cluster (Plan 3g Task 1, R9's Part A).
* Every method here is a Part-A-owned statement (JG1-JG29 group) or a shared
@@ -261,4 +274,49 @@ export class JourneysRepository extends TrekRepository<Journeys> {
async deleteOwnedByUser(userId: number): Promise<void> {
await this.nativeDelete({ user: userId });
}
/**
* The photos in the gallery of one journey, or of every journey a user owns,
* with the paths their `trek_photos` rows store. Read before the journey is
* deleted: the cascade takes the gallery rows, and with them the only way
* back to the photos.
*/
async listGalleryPhotos(scope: { journeyId: number } | { ownerId: number }): Promise<JourneyGalleryPhotoFiles[]> {
const [column, value] =
'journeyId' in scope ? (['j.id', scope.journeyId] as const) : (['j.user_id', scope.ownerId] as const);
return await this.kysely<JourneyPhotoFilesKyselyDB>()
.selectFrom('journey_photos as jp')
.innerJoin('journeys as j', 'j.id', 'jp.journey_id')
.innerJoin('trek_photos as tp', 'tp.id', 'jp.photo_id')
.select(['jp.photo_id', 'tp.file_path', 'tp.thumbnail_path'])
.distinct()
.where(column, '=', value)
.execute();
}
/**
* Deletes the `trek_photos` rows among `photoIds` that no trip and no journey
* links any more, after their journeys went: the same rule as
* `TrekPhotoRegistrationService.deleteIfOrphan` with `local`, for a whole
* gallery at once. A row left behind would keep naming its file, and the
* storage reclaim counts every row with a path as live (#2924). A photo still
* in another journey's gallery, or in a trip's, keeps its row. Answers how
* many rows went.
*/
async deleteUnlinkedPhotos(photoIds: readonly number[]): Promise<number> {
const pages = Array.from({ length: Math.ceil(photoIds.length / PHOTO_DELETE_BATCH) }, (_unused, i) =>
photoIds.slice(i * PHOTO_DELETE_BATCH, (i + 1) * PHOTO_DELETE_BATCH),
);
// One page after the other: they share the caller's transaction.
return await pages.reduce<Promise<number>>(async (previous, page) => {
const deleted = await previous;
const result = await this.kysely<JourneyPhotoFilesKyselyDB>()
.deleteFrom('trek_photos')
.where('id', 'in', page)
.where('id', 'not in', (eb) => eb.selectFrom('trip_photos').select('photo_id'))
.where('id', 'not in', (eb) => eb.selectFrom('journey_photos').select('photo_id'))
.executeTakeFirst();
return deleted + Number(result.numDeletedRows);
}, Promise.resolve(0));
}
}
+13 -4
View File
@@ -191,14 +191,23 @@ export class UserCleanupService {
*/
async deleteUserCompletely(userId: number): Promise<void> {
const avatar = await this.usersRepo.getAvatar(userId);
await this.uow.transactional(async () => {
const photos = await this.uow.transactional(async () => {
// The galleries of the journeys the user owns go with the cascade below, so
// their photos are read first. A photo row none of the remaining trips and
// journeys links goes too, as when one journey is deleted: left behind, it
// would keep naming its file for the storage reclaim forever (#2924).
const gallery = await this.journeysRepo.listGalleryPhotos({ ownerId: userId });
await this.cleanupUserReferences(userId);
await this.journeysRepo.deleteUnlinkedPhotos(gallery.map((photo) => photo.photo_id));
await this.erasePluginUserData(userId);
await this.usersRepo.deleteById(userId);
return gallery;
});
// After the commit, the uploaded avatar goes unless another row names it.
// What the user's trips and journeys named is the nightly reclaim pass's:
// those rows are other domains' and went with the cascade.
// After the commit, the uploaded avatar and those photos' files go unless
// another row names them. What the user's trips named is the nightly
// reclaim pass's: those rows are other domains' and went with the cascade.
await this.release.releaseValues([avatar], { bare: 'avatars' });
const photoFiles = photos.flatMap((photo) => [photo.file_path, photo.thumbnail_path]);
await this.release.releaseValues(photoFiles, { bare: 'journey' });
}
}
@@ -614,8 +614,13 @@ export class CollectionsService {
// Snapshot recipients BEFORE the cascade wipes collection_members.
const accepted = await this.members.acceptedUserIds(id);
const pending = await this.members.pendingUserIds(id);
// The cover and the saved places' images, read before the cascade takes their rows:
// they go like a single place's do, unless a trip place or a copy still names them (#2924).
const cover = (await this.collectionsRepo.coverImage(id)) ?? null;
const images = await this.collectionPlaces.imageUrlsOf(id);
await this.collectionsRepo.deleteById(id); // CASCADE drops members + places + tags
await this.release.releaseValues([cover, ...images]);
[...new Set([userId, ...accepted, ...pending])] // the owner's tabs too, all but the one that asked
.forEach(uid => this.realtime.broadcastToUser(uid, { type: 'collections:deleted', collectionId: id }, socketId));
@@ -8,6 +8,7 @@ import { RealtimeService } from '../realtime/realtime.service';
import type { JourneyStats, JourneyTrack, TrekWsUserEventName } from '@trek/shared';
import { todayUtc } from '@trek/shared';
import { TrekPhotoRegistrationService } from '../photos/trek-photo-registration.service';
import { StorageReleaseService } from '../storage/storage-release.service';
import { getCountryFromCoords } from '../atlas/atlas-geo';
import { computeJourneyStats, countryNamesFor, type StatsInputPoint } from './journey-stats';
import { newEntrySortOrder, placeMovedEntry } from './journey-entry-order';
@@ -101,6 +102,8 @@ export class JourneyDomainService {
// finished via `PlacesRepository.findRaw` (this task's ONE append to
// `Places.repository.ts`, per the task brief — nobody else holds it).
@InjectRepository(Places) private readonly placesRepo: PlacesRepository,
// Deleting a journey releases the files of the photos only it held.
private readonly release: StorageReleaseService,
) {}
private ts(): number {
@@ -368,7 +371,19 @@ export class JourneyDomainService {
if (!(await this.isOwner(journeyId, userId))) return false;
// Read first: the delete takes the contributor rows with it.
const audience = await this.journeysRepo.listRecipientUserIds(journeyId);
await this.journeysRepo.deleteById(journeyId);
// The gallery goes with the cascade, so its photos are read first. A photo
// row only this journey linked goes too: left behind, it would keep naming
// its file and the storage reclaim would never free it (#2924). One still
// in a trip or another journey keeps its row, and with it its file.
const photos = await this.uow.transactional(async () => {
const gallery = await this.journeysRepo.listGalleryPhotos({ journeyId });
await this.journeysRepo.deleteById(journeyId);
await this.journeysRepo.deleteUnlinkedPhotos(gallery.map((photo) => photo.photo_id));
return gallery;
});
// After the commit; the release asks every source again, so a file another row names stays.
const photoFiles = photos.flatMap((photo) => [photo.file_path, photo.thumbnail_path]);
await this.release.releaseValues(photoFiles, { bare: 'journey' });
await this.broadcastJourneyEvent(journeyId, 'journey:deleted', {}, sid, audience);
return true;
}
@@ -14,6 +14,7 @@ import { DatabaseLifecycle } from '../database/database-lifecycle.service';
import { withRequestContext } from '../database/request-context';
import { StorageInstallService } from './storage-install.service';
import { StorageJobsService } from './storage-jobs.service';
import { isValidKey } from './storage-keys';
import { StorageReclaimGuardService } from './storage-reclaim-guard.service';
import { StorageReclaimRegistryService } from './storage-reclaim-registry.service';
import { inReclaimScope, RECLAIM_LEDGER, reclaimableCategories, sharedLocationsOf } from './storage-reclaim.ledger';
@@ -435,7 +436,10 @@ export class StorageReclaimService implements OnModuleInit {
for await (const stat of this.storage.list(category, '', { shallow: true })) {
seen += 1;
if (seen % LIST_CHECK_EVERY === 0) this.assertSameDatabase(ctx);
if (!inReclaimScope(stat.key)) continue;
// A name the storage layer refuses (a backslash or a control character in a
// local file put there by hand) can never be stat'ed or deleted: judging it
// would fail its whole delete batch every night, so it is left alone.
if (!inReclaimScope(stat.key) || !isValidKey(stat.key)) continue;
const owner = storageOwnerMarkerInstall(stat.key);
if (owner !== null) {
owners.add(owner);
@@ -78,7 +78,9 @@ class ReleaseStopped extends Error {}
/**
* What a user's change left unnamed: a replaced or removed cover, place image
* or avatar, a deleted journey photo or trip file. The owner hands the values
* or avatar, a deleted journey photo or trip file, and what a deleted list
* (its cover and saved places' images) or journey (its gallery's photos) held;
* a deleted trip hands on only its cover. The owner hands the values
* its rows held to `releaseValues` once its transaction committed, and every
* object they name is queued, which is all the request pays. Nothing goes
* before RELEASE_DELAY_MS, so an undo or a late write that brings the value
@@ -93,6 +93,7 @@ export async function accommodationsOver(
await createTestJourneyPhotosRepo(conn),
await createTestJourneyEntryPhotosRepo(conn),
await createTestPlacesRepo(conn),
{ releaseValues: async () => 0 } as never, // StorageReleaseService
),
await createTestUnitOfWork(conn),
await createTestDayAssignmentsRepo(conn),
+1
View File
@@ -361,6 +361,7 @@ export async function createPluginRpcHostParts(
await createTestJourneyPhotosRepo(db),
await createTestJourneyEntryPhotosRepo(db),
await createTestPlacesRepo(db),
{ releaseValues: async () => 0 } as never, // StorageReleaseService
);
const atlas = new AtlasService(
await createTestBucketListRepo(db),
@@ -109,6 +109,7 @@ beforeAll(async () => {
await createTestJourneyPhotosRepo(testDb),
await createTestJourneyEntryPhotosRepo(testDb),
await createTestPlacesRepo(testDb),
{ releaseValues: async () => 0 } as never, // StorageReleaseService
),
await createTestUnitOfWork(testDb),
await createTestDayAssignmentsRepo(testDb),
@@ -700,6 +700,24 @@ describe('deleteCollection', () => {
expect(await placesIn(col.id)).toEqual({ n: 0 });
expect(await membersOf(col.id)).toEqual({ n: 0 });
});
it('COLLECTIONS-SVC-040b: deleting a list releases its cover and the images of its saved places (#2924)', async () => {
const owner = createUser(testDb).user;
const col = await svc.createCollection(owner.id, { name: 'Doomed' });
const files = ['list-cover.jpg', 'list-place-a.jpg', 'list-place-b.jpg'].map((name) => {
const filePath = path.join(storageFx.root, name);
fs.writeFileSync(filePath, 'jpeg-bytes');
return filePath;
});
await svc.setCollectionCover(owner.id, col.id, '/uploads/covers/list-cover.jpg');
await svc.savePlace(owner.id, { collection_id: col.id, name: 'A', image_url: '/uploads/places/list-place-a.jpg' });
await svc.savePlace(owner.id, { collection_id: col.id, name: 'B', image_url: '/uploads/places/list-place-b.jpg' });
await svc.savePlace(owner.id, { collection_id: col.id, name: 'No image' });
await svc.deleteCollection(owner.id, col.id);
expect(files.map((file) => fs.existsSync(file))).toEqual([false, false, false]);
});
});
// ── owner_id semantics: member account deletion keeps shared content ─────────
@@ -153,6 +153,7 @@ beforeAll(async () => {
await createTestJourneyPhotosRepo(testDb),
await createTestJourneyEntryPhotosRepo(testDb),
await createTestPlacesRepo(testDb),
{ releaseValues: async () => 0 } as never, // StorageReleaseService
),
makeStorageFixture('').storage,
await accommodationsOver(testDb),
@@ -77,6 +77,7 @@ beforeAll(async () => {
await createTestJourneyPhotosRepo(testDb),
await createTestJourneyEntryPhotosRepo(testDb),
await createTestPlacesRepo(testDb),
{ releaseValues: async () => 0 } as never, // StorageReleaseService
);
// Plan 3g Task 3: JourneyBooksRepository (JB1-JB7), not `dbs` any more.
// task-5-fix-brief constructor-ripple (M1): `UnitOfWork`, so `saveBook`'s
@@ -52,6 +52,7 @@ import {
// ported from the reviewer's probe (scratchpad r3g/probe/zz-r3g-parity-probe.test.ts).
import { todayUtc } from '@trek/shared';
import { GALLERY_CHRONOLOGICAL_ORDER } from '../../helpers/legacy-gallery-order';
import { releaseNothing } from '../../helpers/storage-release';
import type { EntityClass, EntityDTO, FilterQuery, FindOptions, RequiredEntityData } from '@mikro-orm/core';
import { countRows, deleteRows, findRows, insertRow, updateRows } from '../../helpers/factories/rows';
import { DayAssignments } from '../../../src/db/entities/DayAssignments.entity';
@@ -98,6 +99,7 @@ async function pickAll<T extends object, K extends keyof EntityDTO<T>>(
}
let svc: JourneyDomainService;
const release = releaseNothing();
// Plan 3g Task 1's own additions (below, "repositories (R9's parity + mutation
// proofs)" describe block) reach the repositories directly — held here so
// that block doesn't need its own second construction.
@@ -145,6 +147,7 @@ beforeAll(async () => {
// R9, Task 2 only appends to what Task 1's construction already
// established, never re-touches the wrapping mechanism itself.
photosRepoDirect, entryPhotosRepoDirect, placesRepoDirect,
release,
);
});
@@ -540,6 +543,49 @@ describe('deleteJourney', () => {
const row = await one(Journeys, { id: journey.id });
expect(row).toBeDefined();
});
it('JOURNEY-SVC-022b: deleting a journey drops the photo rows only it held and releases their files', async () => {
const { user } = createUser(testDb);
const journey = await svc.createJourney(user.id, { title: 'J' });
const [photo, video] = await svc.uploadGalleryPhotos(journey.id, user.id, [
{ path: 'journey/a.jpg' },
{ path: 'journey/b.mp4', thumbnail: 'journey/b-poster.jpg', mediaType: 'video' },
]);
release.releaseValues.mockClear();
expect(await svc.deleteJourney(journey.id, user.id)).toBe(true);
expect(await one(TrekPhotos, { id: { $in: [photo.photo_id, video.photo_id] } })).toBeUndefined();
expect(release.releaseValues).toHaveBeenCalledTimes(1);
const [values, options] = release.releaseValues.mock.calls[0] as unknown as [Array<string | null>, unknown];
expect(values.filter(Boolean).sort()).toEqual(['journey/a.jpg', 'journey/b-poster.jpg', 'journey/b.mp4']);
expect(options).toEqual({ bare: 'journey' });
});
it('JOURNEY-SVC-022c: a photo another journey or a trip still links keeps its row through the delete', async () => {
const { user } = createUser(testDb);
const journey = await svc.createJourney(user.id, { title: 'J' });
const other = await svc.createJourney(user.id, { title: 'Other' });
const trip = createTrip(testDb, user.id);
const [shared, inTrip, alone] = await svc.uploadGalleryPhotos(journey.id, user.id, [
{ path: 'journey/shared.jpg' },
{ path: 'journey/trip.jpg' },
{ path: 'journey/alone.jpg' },
]);
// The same file uploaded to a second journey reuses its photo row.
const [again] = await svc.uploadGalleryPhotos(other.id, user.id, [{ path: 'journey/shared.jpg' }]);
expect(again.photo_id).toBe(shared.photo_id);
testDb
.prepare('INSERT INTO trip_photos (trip_id, user_id, photo_id) VALUES (?, ?, ?)')
.run(trip.id, user.id, inTrip.photo_id);
expect(await svc.deleteJourney(journey.id, user.id)).toBe(true);
expect(await one(TrekPhotos, { id: shared.photo_id })).toBeDefined();
expect(await one(TrekPhotos, { id: inTrip.photo_id })).toBeDefined();
expect(await one(TrekPhotos, { id: alone.photo_id })).toBeUndefined();
expect(await one(JourneyPhotos, { journey: other.id, photo: shared.photo_id })).toBeDefined();
});
});
// -- Trip management ----------------------------------------------------------
@@ -101,6 +101,7 @@ beforeAll(async () => {
await createTestJourneyPhotosRepo(testDb),
await createTestJourneyEntryPhotosRepo(testDb),
await createTestPlacesRepo(testDb),
{ releaseValues: async () => 0 } as never, // StorageReleaseService
),
new SettingsService(
uow,
@@ -108,6 +108,7 @@ beforeAll(async () => {
await createTestJourneyPhotosRepo(testDb),
await createTestJourneyEntryPhotosRepo(testDb),
await createTestPlacesRepo(testDb),
{ releaseValues: async () => 0 } as never, // StorageReleaseService
);
});
@@ -137,6 +137,7 @@ async function svc(searchNominatim: OsmClient['searchNominatim']): Promise<Place
await createTestJourneyPhotosRepo(testDb),
await createTestJourneyEntryPhotosRepo(testDb),
await createTestPlacesRepo(testDb),
{ releaseValues: async () => 0 } as never, // StorageReleaseService
),
storageFx.storage,
await accommodationsOver(testDb),
@@ -145,7 +145,7 @@ async function makePlacesService(
await createTestJourneysRepo(testDb), await createTestJourneyContributorsRepo(testDb),
await createTestJourneyTripsRepo(testDb), await createTestJourneyEntriesRepo(testDb), await createTestTripsRepo(testDb),
// Plan 3g Task 2 constructor-ripple: JourneyPhotosRepository/JourneyEntryPhotosRepository/PlacesRepository.
await createTestJourneyPhotosRepo(testDb), await createTestJourneyEntryPhotosRepo(testDb), await createTestPlacesRepo(testDb),
await createTestJourneyPhotosRepo(testDb), await createTestJourneyEntryPhotosRepo(testDb), await createTestPlacesRepo(testDb), { releaseValues: async () => 0 } as never,
),
placesStorageFx.storage,
await accommodationsOver(testDb), await createTestUnitOfWork(testDb),
@@ -10,7 +10,7 @@
* an owner marker of another install keeps its hands off; a restore, or a
* database naming another install, resets the switch, the marks, the queue
* and the reports but keeps this install's id, and so does a restore's reset
* file whatever id the database names. RCLS-001 to RCLS-046.
* file whatever id the database names. RCLS-001 to RCLS-047.
*/
import { AppSettings } from '../../../../src/db/entities/AppSettings.entity';
import { AuditLog } from '../../../../src/db/entities/AuditLog.entity';
@@ -342,6 +342,22 @@ describe('StorageReclaimService: mark, then sweep', () => {
expect(again.categories.covers.objects).toBe(5);
expect((await marksOf('covers')).map((mark) => mark.key)).toEqual(['orphan.jpg']);
});
it('RCLS-047: a listed name the storage layer refuses is never judged, so it cannot fail the batch it would sit in', async () => {
// A file put into the folder by hand with a backslash in its name: a Linux
// local backend lists it, but stat and delete refuse the key.
const listOf = storage.list.bind(storage);
vi.spyOn(storage, 'list').mockImplementation(async function* (category, prefix, opts) {
yield* listOf(category, prefix, opts);
if (category === 'covers') yield { key: 'trip\\photo.jpg', size: 5, mtimeMs: 1 };
});
await markedWeekOld(['orphan.jpg']);
expect((await marksOf('covers')).map((mark) => mark.key)).toEqual(['orphan.jpg']);
const report = await reclaim.run({ now: WEEK_LATER });
expect(report.categories.covers).toMatchObject({ objects: 5, deleted: { objects: 1, bytes: 5 }, skipped: null });
expect(fs.existsSync(objectPath('covers', 'orphan.jpg'))).toBe(false);
});
});
describe('StorageReclaimService: a large unreferenced share waits for the admin', () => {
@@ -126,6 +126,7 @@ async function makePlacesService(): Promise<PlacesService> {
await createTestJourneyPhotosRepo(testDb),
await createTestJourneyEntryPhotosRepo(testDb),
await createTestPlacesRepo(testDb),
{ releaseValues: async () => 0 } as never, // StorageReleaseService
),
storage,
await accommodationsOver(testDb),
@@ -222,6 +222,7 @@ beforeAll(async () => {
await createTestJourneyPhotosRepo(testDb),
await createTestJourneyEntryPhotosRepo(testDb),
await createTestPlacesRepo(testDb),
{ releaseValues: async () => 0 } as never, // StorageReleaseService
),
makeStorageFixture('').storage,
await accommodationsOver(testDb, realtime),
@@ -265,6 +265,7 @@ beforeAll(async () => {
await createTestJourneyTripsRepo(testDb), await createTestJourneyEntriesRepo(testDb), await createTestTripsRepo(testDb),
// Plan 3g Task 2 constructor-ripple: JourneyPhotosRepository/JourneyEntryPhotosRepository/PlacesRepository.
await createTestJourneyPhotosRepo(testDb), await createTestJourneyEntryPhotosRepo(testDb), await createTestPlacesRepo(testDb),
{ releaseValues: async () => 0 } as never, // StorageReleaseService
),
makeStorageFixture('').storage,
await accommodationsOver(testDb, realtime), await createTestUnitOfWork(testDb),
@@ -23,6 +23,7 @@ import { Plugins } from '../../../src/db/entities/Plugins.entity';
import { ShareTokens } from '../../../src/db/entities/ShareTokens.entity';
import { TrekPhotos } from '../../../src/db/entities/TrekPhotos.entity';
import { TripMembers } from '../../../src/db/entities/TripMembers.entity';
import { TripPhotos } from '../../../src/db/entities/TripPhotos.entity';
import { Users } from '../../../src/db/entities/Users.entity';
import type { BudgetItemsRepository } from '../../../src/db/repositories/BudgetItems.repository';
import type { BudgetSettlementsRepository } from '../../../src/db/repositories/BudgetSettlements.repository';
@@ -459,4 +460,39 @@ describe('deleteUserCompletely', () => {
await svc.deleteUserCompletely(user.id);
expect(cleanupRelease.releaseValues).toHaveBeenCalledWith(['face.png'], { bare: 'avatars' });
});
it('USER-CLEANUP-012: drops the photo rows only their own journeys held and releases those files', async () => {
const { user: victim } = createUser(testDb, { username: 'photo-victim' });
const { user: other } = createUser(testDb, { username: 'photo-other' });
const ownJourney = await createJourney(victim.id, 'Mine');
const otherJourney = await createJourney(other.id, 'Theirs');
const trip = createTrip(testDb, other.id);
const photo = async (file: string, thumb: string | null = null) => {
const row = { provider: 'local', owner: victim.id, file_path: file, thumbnail_path: thumb };
const id = await insertRow(orm, TrekPhotos, row);
await insertRow(orm, JourneyPhotos, { journey: ownJourney, photo: id, created_at: 0 });
return id;
};
const alone = await photo('journey/alone.jpg', 'journey/alone-poster.jpg');
const inOtherJourney = await photo('journey/shared.jpg');
const inTrip = await photo('journey/trip.jpg');
await insertRow(orm, JourneyPhotos, { journey: otherJourney, photo: inOtherJourney, created_at: 0 });
await insertRow(orm, TripPhotos, { trip: trip.id, user: other.id, photo: inTrip });
await svc.deleteUserCompletely(victim.id);
expect(await findRow(orm, TrekPhotos, { id: alone })).toBeNull();
expect(await findRow(orm, TrekPhotos, { id: inOtherJourney })).not.toBeNull();
expect(await findRow(orm, TrekPhotos, { id: inTrip })).not.toBeNull();
// Every file the gallery named is handed on: the release keeps what another row still names.
type Released = [Array<string | null>, { bare?: string }];
const calls = cleanupRelease.releaseValues.mock.calls as unknown as Released[];
const handed = calls.find(([, options]) => options.bare === 'journey')?.[0] ?? [];
expect(handed.filter(Boolean).sort()).toEqual([
'journey/alone-poster.jpg',
'journey/alone.jpg',
'journey/shared.jpg',
'journey/trip.jpg',
]);
});
});