k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-20 22:16:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci(client): lint:size measures the Playwright specs and fixtures too

Browse Source 
The size check walked src/ and tests/ only, while lint:format and
lint:skips already cover e2e/. The help center fixtures under
e2e/help/fixtures.ts hold 2291 wrapped lines, past the 2000 a test may
reach, and could grow without bound. e2e/ is now measured with the test
limit; fixtures.ts enters the baseline at its current size, every other
file there is within the limit.
This commit is contained in:
Maurice
2026-10-08 12:52:18 +02:00
parent 3e37dcfb45
commit 9d596d9916
5 changed files with 25 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/tests/unit/scripts/size-lint.test.ts
+16 -2
View File
@@ -10,7 +10,12 @@ afterEach(() => tree?.remove());
const BASELINE = 'scripts/size-baseline.json';
function run(baseline: Record<string, number>, files: Record<string, string>, update = false) {
tree = ratchetTree({ [BASELINE]: JSON.stringify(baseline), 'tests/keep.test.ts': lines(1), ...files });
tree = ratchetTree({
[BASELINE]: JSON.stringify(baseline),
'tests/keep.test.ts': lines(1),
'e2e/keep.spec.ts': lines(1),
...files,
});
return check({ root: tree.root, baselinePath: tree.path(BASELINE), update, ...tree.out });
}
@@ -31,6 +36,8 @@ describe('lint:size', () => {
expect(groupOf('src/index.css')).toMatchObject({ name: 'stylesheet', limit: 1000 });
expect(groupOf('src/a/B.test.tsx')).toMatchObject({ name: 'test', limit: 2000 });
expect(groupOf('tests/unit/x.ts')).toMatchObject({ name: 'test', limit: 2000 });
expect(groupOf('e2e/help/fixtures.ts')).toMatchObject({ name: 'test', limit: 2000 });
expect(groupOf('e2e/server-launch.mjs')).toBeNull();
expect(groupOf('src/a/notes.md')).toBeNull();
});
@@ -56,6 +63,13 @@ describe('lint:size', () => {
expect(tree.error.join('\n')).toMatch(/src\/A\.test\.tsx: 2001 lines .*test file is 2000/);
});
it('SIZE-010: covers the Playwright specs and fixtures under e2e/', () => {
const files = { 'src/a.ts': lines(1), 'e2e/help/fixtures.ts': lines(2001), 'e2e/a.spec.ts': lines(2000) };
expect(run({}, files)).toBe(1);
expect(tree.error.join('\n')).toMatch(/e2e\/help\/fixtures\.ts: 2001 lines .*test file is 2000/);
expect(tree.error.join('\n')).not.toMatch(/e2e\/a\.spec\.ts/);
});
it('SIZE-007: holds a baselined file at its entry and fails it once it grows', () => {
expect(run({ 'src/big.ts': 1200 }, { 'src/big.ts': lines(1200) })).toBe(0);
tree.remove();
@@ -81,7 +95,7 @@ describe('lint:size', () => {
});
it('SIZE-009: a broken baseline stops the check', () => {
tree = ratchetTree({ [BASELINE]: '{', 'src/a.ts': lines(1), 'tests/a.ts': lines(1) });
tree = ratchetTree({ [BASELINE]: '{', 'src/a.ts': lines(1), 'tests/a.ts': lines(1), 'e2e/a.ts': lines(1) });
expect(() => check({ root: tree.root, baselinePath: tree.path(BASELINE), ...tree.out })).toThrow(RatchetError);
});
});