feat(storage): confirm the count shown, and say a backup or a missing install id held the cleanup

Confirm sends the count the admin saw and waits for its answer; a stale
count reloads the state. A running backup is named as a skip reason, a
missing installation id and a stale count as errors, and the switch's
hint no longer promises removal right away: deleted files go a day
later, once no undo can bring them back. Strings in all 28 languages.
This commit is contained in:
Maurice
2026-11-01 18:14:49 +01:00
parent 10ad64d170
commit 9d2ffc91af
40 changed files with 250 additions and 81 deletions
@@ -81,7 +81,7 @@ export interface StorageAdmin {
/** Starts a check that only reports, in the background; the state polls until it is done. Null on success. */
checkReclaim: () => Promise<ReclaimFailure | null>
/** Lets the nightly run delete in a category where an unusually large share looks unused. Null on success. */
confirmReclaim: (category: StorageReclaimConfirmRequest['category']) => Promise<ReclaimFailure | null>
confirmReclaim: (request: StorageReclaimConfirmRequest) => Promise<ReclaimFailure | null>
/** Re-GETs admin state (poll-safe — see the implementation comment below). Exposed for the panel's failed-queue recovery path. */
refreshState: () => Promise<void>
/**
@@ -425,15 +425,18 @@ export function useStorageAdmin(genericError: string, conflictError: string): St
}, [genericError, setReclaim])
const confirmReclaim = useCallback(
async (category: StorageReclaimConfirmRequest['category']): Promise<ReclaimFailure | null> => {
async (request: StorageReclaimConfirmRequest): Promise<ReclaimFailure | null> => {
try {
setReclaim(await storageReclaimApi.confirm(category))
setReclaim(await storageReclaimApi.confirm(request))
return null
} catch (err: unknown) {
return reclaimFailureOf(err, genericError)
const failure = reclaimFailureOf(err, genericError)
// The count moved on since it was shown: show the current one before the admin confirms again.
if ('code' in failure && failure.code === 'reclaim_confirm_stale') void refreshState().catch(() => {})
return failure
}
},
[genericError, setReclaim],
[genericError, setReclaim, refreshState],
)
return {