k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-21 22:46:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(memories): save the Immich connection and auto_upload in one transaction

Browse Source 
PUT /api/integrations/memories/immich/settings saved the connection through
one service call and then wrote auto_upload through a second one from
the controller, each committed on its own. A failure between them left
a new connection with the old upload choice.

saveImmichSettings takes the auto_upload flag and writes it with the
connection (or the disconnect) inside one transaction, after the SSRF
check that does the DNS lookup. An absent or non-boolean flag still
keeps the stored choice, a refused URL still writes nothing, and the
response is unchanged. The controller's write sequence leaves the
lint:tx baseline, and the MemoriesService facade loses the
immichSetAutoUpload pass-through it no longer needs. No MCP tool writes
these settings.
This commit is contained in:
Maurice
2026-10-08 16:17:57 +02:00
parent f40d92a69e
commit 9cebadf67c
9 changed files with 82 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/scripts/tx-writes-baseline.json
-1
View File
@@ -40,7 +40,6 @@
"src/nest/maps/maps.service.ts#MapsService.getPlaceDetails": 2,
"src/nest/maps/maps.service.ts#MapsService.getPlaceDetailsExpanded": 2,
"src/nest/maps/maps.service.ts#MapsService.getPlacePhoto": 7,
"src/nest/memories/immich.controller.ts#ImmichMemoriesController.putSettings": 2,
"src/nest/memories/photo-resolver.service.ts#PhotoResolverService.streamCachedThumbnail": 3,
"src/nest/memories/photo-resolver.service.ts#PhotoResolverService.streamPhoto": 2,
"src/nest/memories/synology.service.ts#SynologyService._fetchAllSynologyAlbums": 2,