mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-11-20 11:06:06 +00:00
fix(db): refuse restores for CREATEROLE members, server file grants and parameter grants
The privileged-role check missed three ways a role can reach the database host from SQL. Before PostgreSQL 16 a member of a CREATEROLE role sets its role to it and grants itself pg_execute_server_program, since role attributes are not inherited but the grant checks the role in effect. A role granted EXECUTE on lo_export, lo_import, pg_read_file, pg_ls_dir and their siblings reads or writes server files, and lo_export keeps the file after the transaction rolls back. From PostgreSQL 15 on a role can be granted ALTER SYSTEM on a setting or SET on a superuser-only one. PRIVILEGED_ROLE_SQL now counts all three. The parameter grants are read through query_to_xml inside a CASE taken only on 15 or later, because a statement naming pg_parameter_acl does not parse on 14. A SET grant on a setting every role may change anyway, and pg_monitor, stay ordinary. The lane test creates each kind of role and shows the escalation the check is for on the server it runs against.
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
/**
|
||||
* PGROLE-001..003 — the check that refuses a restore (and warns at boot) for a
|
||||
* PGROLE-001..006 — the check that refuses a restore (and warns at boot) for a
|
||||
* role that could reach the database host from SQL
|
||||
* (src/db/engine/postgres/server-checks.ts), evaluated by the real server as
|
||||
* each kind of role. Roles belong to the whole server, so this suite creates
|
||||
@@ -15,7 +15,18 @@ import { afterAll, beforeAll, describe, expect, it } from 'vitest';
|
||||
const adminUrl = process.env.TREK_TEST_DB_URL as string;
|
||||
const PREFIX = `trek_test_role_${process.pid}_`;
|
||||
const role = (name: string) => `${PREFIX}${name}`;
|
||||
const ROLES = ['plain', 'super', 'member', 'program', 'reader', 'writer', 'creator', 'granter'];
|
||||
|
||||
/**
|
||||
* Drops every role this suite created, whatever it was granted. DROP OWNED
|
||||
* revokes what a role holds in this database and on shared objects, its
|
||||
* function and parameter grants included, which DROP ROLE alone refuses to
|
||||
* leave behind.
|
||||
*/
|
||||
const DROP_ROLES =
|
||||
'do $drop$ declare name text; begin' +
|
||||
` for name in select rolname from pg_roles where left(rolname, ${PREFIX.length}) = '${PREFIX}' loop` +
|
||||
" execute format('drop owned by %I', name); execute format('drop role %I', name);" +
|
||||
' end loop; end $drop$';
|
||||
|
||||
/** The statements run as the admin, one after the other on its one connection. */
|
||||
function asAdmin(statements: string[]): Promise<unknown[]> {
|
||||
@@ -38,7 +49,7 @@ async function privileged(name: string): Promise<boolean> {
|
||||
let major = 0;
|
||||
|
||||
beforeAll(async () => {
|
||||
await asAdmin(ROLES.map((name) => `drop role if exists ${role(name)}`));
|
||||
await asAdmin([DROP_ROLES]);
|
||||
await asAdmin([
|
||||
`create role ${role('plain')} nologin`,
|
||||
`create role ${role('super')} nologin superuser`,
|
||||
@@ -52,15 +63,44 @@ beforeAll(async () => {
|
||||
`grant pg_write_server_files to ${role('writer')}`,
|
||||
`create role ${role('creator')} nologin createrole`,
|
||||
`create role ${role('granter')} nologin createrole`,
|
||||
// A login role that holds no CREATEROLE itself but belongs to a group that does.
|
||||
`create role ${role('admins')} nologin createrole`,
|
||||
`create role ${role('in_admins')} nologin in role ${role('admins')}`,
|
||||
// Server file functions, granted one by one as a DBA would for a maintenance tool.
|
||||
`create role ${role('lo_export')} nologin`,
|
||||
`grant execute on function lo_export(oid, text) to ${role('lo_export')}`,
|
||||
`create role ${role('lo_import')} nologin`,
|
||||
`grant execute on function lo_import(text) to ${role('lo_import')}`,
|
||||
`create role ${role('read_file')} nologin`,
|
||||
`grant execute on function pg_read_file(text) to ${role('read_file')}`,
|
||||
`create role ${role('ls_dir')} nologin`,
|
||||
`grant execute on function pg_ls_dir(text) to ${role('ls_dir')}`,
|
||||
// pg_monitor lists fixed directories only, and stays an ordinary role.
|
||||
`create role ${role('monitor')} nologin`,
|
||||
`grant pg_monitor to ${role('monitor')}`,
|
||||
`create role ${role('set_suset')} nologin`,
|
||||
`create role ${role('alter_system')} nologin`,
|
||||
`create role ${role('set_userset')} nologin`,
|
||||
`create role ${role('setters')} nologin`,
|
||||
`create role ${role('in_setters')} nologin in role ${role('setters')}`,
|
||||
]);
|
||||
const [rows] = (await asAdmin(["select current_setting('server_version_num')::int / 10000 as major"])) as Array<
|
||||
Array<{ major: number }>
|
||||
>;
|
||||
major = rows[0].major;
|
||||
// Privileges on parameters exist from PostgreSQL 15 on; the statements do not parse before.
|
||||
if (major >= 15) {
|
||||
await asAdmin([
|
||||
`grant set on parameter lo_compat_privileges to ${role('set_suset')}`,
|
||||
`grant alter system on parameter archive_command to ${role('alter_system')}`,
|
||||
`grant set on parameter work_mem to ${role('set_userset')}`,
|
||||
`grant set on parameter log_statement to ${role('setters')}`,
|
||||
]);
|
||||
}
|
||||
});
|
||||
|
||||
afterAll(async () => {
|
||||
await asAdmin(ROLES.map((name) => `drop role if exists ${role(name)}`));
|
||||
await asAdmin([DROP_ROLES]);
|
||||
});
|
||||
|
||||
describe('the privileged-role check', () => {
|
||||
@@ -106,4 +146,50 @@ describe('the privileged-role check', () => {
|
||||
if (major < 16) await expect(grant).resolves.toBeUndefined();
|
||||
else await expect(grant).rejects.toThrow(/permission denied|must have admin option/);
|
||||
});
|
||||
|
||||
it('PGROLE-004: refuses before PostgreSQL 16 a role that is only a member of a CREATEROLE role, and not from 16 on', async () => {
|
||||
const [states] = (await asAdmin([
|
||||
`select rolcreaterole from pg_roles where rolname = '${role('in_admins')}'`,
|
||||
])) as Array<Array<{ rolcreaterole: boolean }>>;
|
||||
expect(states[0].rolcreaterole).toBe(false);
|
||||
expect(await privileged('in_admins')).toBe(major < 16);
|
||||
// The reason: the member sets its role to the group and grants itself what reaches the host.
|
||||
const grant = withAdmin(adminUrl, async (run) => {
|
||||
await run(`set role ${role('in_admins')}`);
|
||||
try {
|
||||
await run(`set role ${role('admins')}`);
|
||||
await run(`grant pg_execute_server_program to ${role('in_admins')}`);
|
||||
} finally {
|
||||
await run('reset role');
|
||||
}
|
||||
});
|
||||
if (major < 16) await expect(grant).resolves.toBeUndefined();
|
||||
else await expect(grant).rejects.toThrow(/permission denied|must have admin option/);
|
||||
});
|
||||
|
||||
it('PGROLE-005: refuses a role granted a server file function, and passes pg_monitor', async () => {
|
||||
expect(await privileged('lo_export')).toBe(true);
|
||||
expect(await privileged('lo_import')).toBe(true);
|
||||
expect(await privileged('read_file')).toBe(true);
|
||||
expect(await privileged('ls_dir')).toBe(true);
|
||||
expect(await privileged('monitor')).toBe(false);
|
||||
// The reason, as this server answers it: the grant alone lets the role read the host's file system.
|
||||
const listed = await withAdmin(adminUrl, async (run) => {
|
||||
await run(`set role ${role('ls_dir')}`);
|
||||
try {
|
||||
return await run<{ name: string }>("select pg_ls_dir('.') as name");
|
||||
} finally {
|
||||
await run('reset role');
|
||||
}
|
||||
});
|
||||
expect(listed.map((row) => row.name)).toContain('PG_VERSION');
|
||||
});
|
||||
|
||||
it('PGROLE-006: refuses from PostgreSQL 15 on a role granted ALTER SYSTEM or a superuser-only setting, directly or through a group', async () => {
|
||||
expect(await privileged('set_suset')).toBe(major >= 15);
|
||||
expect(await privileged('alter_system')).toBe(major >= 15);
|
||||
expect(await privileged('in_setters')).toBe(major >= 15);
|
||||
// SET on a setting every role may set anyway gives nothing.
|
||||
expect(await privileged('set_userset')).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user