v3.4.1 (#1606)

* fix(transit): lead arrive-by results with the latest arrival (#1479)

MOTIS returns arrive-by itineraries ascending with the deadline-adjacent
connection last, so the visible top of the list arrived ~2h before the
requested time — misread as a timezone bug. Sort arrive-by results by
endTime descending so the connection closest to the requested arrival
leads, mirroring depart-by.

Claude-Session: https://claude.ai/code/session_01BCrZUoPzHZF6H4C6avMXoz

* fix(transit): lead arrive-by results with the latest arrival (#1479)

MOTIS returns arrive-by itineraries ascending with the deadline-adjacent
connection last, so the visible top of the list arrived ~2h before the
requested time — misread as a timezone bug. Sort arrive-by results by
endTime descending so the connection closest to the requested arrival
leads, mirroring depart-by.

* fix(reservations): run AirTrail modal hooks before the isOpen early return (#1602)

The sectionItems useMemo added by #1535 sat below 'if (!isOpen) return null'.
The modal mounts closed, so the first open render executed one more hook
than the previous render and React unmounted the whole tree (error #310),
blanking the page. Move the memo above the early return and cover the
closed-then-open transition with a regression test.

* fix(planner): only draw the check-in-day hotel morning leg when provably at/after check-in (#1597) (#1607)

On an accommodation's check-in day the hotel -> first-stop leg was drawn
by default for any PLACE first stop, suppressed only when that place was
explicitly timed before check-in. An un-timed first place (e.g. "Home"
on day 1 of a driving holiday) therefore always produced a phantom
hotel -> Home leg, regardless of the check-in time.

Flip the default to mirror shouldDrawEveningLeg: the morning leg is now
drawn only when the first place is provably timed at/after check-in
(you dropped your bags first). The drawn map route, the sidebar hotel
connectors, and the Google Maps export all share this helper and
inherit the fix. The optimizer anchors (#1321) are unchanged.

* fix(notifications): never fall back to the admin ntfy topic for per-user sends (#1608)

* chore: correct shields.io url

* chore: correct shields.io url

* chore: update helm repo link

* chore: document new helm chart url

* chore: document new helm chart url

* fix(atlas): make Kosovo selectable on the Atlas map (#1609)

Kosovo's user-assigned ISO code (XK/XKX) was missing from both code
tables in the atlas pipeline: the geo builder's A3_TO_A2 map (so the
shipped admin0 bundle carried ISO_A2: null) and the client's A2_TO_A3
map. With neither resolvable, onEachFeature attached no hover/click
handlers to Kosovo's polygon and the country search dropped it, making
Kosovo impossible to select.

- add XK<->XKX to the client A2_TO_A3 table and the builder A3_TO_A2 map
- stamp ISO_A2: "XK" on the Kosovo feature in the shipped admin0 bundle
- guard both with tests (atlasModel resolution + ATLAS-BUNDLE-003)

* chore: normalize docker image references to mauriceboe/trek (lowercase)

* fix(memories): honor Synology skip-SSL on photo streaming (#1611)

The synology_skip_ssl setting was forwarded on the JSON API path
(login/browse/test-connection) but not on the image-byte fetches, so a
NAS with a self-signed certificate passed Test Connection while
/api/photos/:id/thumbnail and /original failed with 500
"Failed to fetch asset" — and the TLS error was silently swallowed.

- pipeAsset: accept fetchOptions and forward to safeFetch; log the
  underlying error on the 500 path (without the URL, which carries _sid)
- fetchSynologyThumbnailBytes / streamSynologyAsset: pass
  rejectUnauthorized derived from synology_skip_ssl; log on failure
- i18n: replace hardcoded "Immich" with {provider_name} in 7 memories
  keys across 14 locales (source of the reported "Failed to connect to
  Immich" banner on the Synology test), fix translated placeholder
  names in tr/ca/pl, and add a placeholder-parity spec to prevent
  regressions
- client: gallery provider badge matched 'synology' instead of the real
  id 'synologyphotos', showing the raw id; label is now
  "Synology Photos"

* chore: make chart.liketrek.com the canonical helm chart url

* feat(plugins): prefer the registry's resolved store screenshot (#1613)

Browse/detail use the screenshotUrl the aggregate step resolves (cover at the latest commit, or the first resolving README image), falling back to the docs/screenshot.png guess when the field is absent. Fixes blank store cards for plugins without a committed docs/screenshot.png.

---------

Co-authored-by: Maurice <61554723+mauriceboe@users.noreply.github.com>

server/src/nest/plugins/registry/registry.service.ts

@@ -76,6 +76,13 @@ export interface RegistryEntry {
   authorPublicKey?: string;
   /** Release-asset downloads across all versions, aggregated by the registry's stats cron. */
   downloadCount?: number | null;
+  /**
+   * Store cover image, resolved at build time by the registry's aggregate step:
+   * docs/screenshot.png at the latest commit, else the first README image that
+   * resolves there. Absent for entries published before this existed — browse
+   * and detail then construct the docs/screenshot.png URL themselves.
+   */
+  screenshotUrl?: string | null;
   versions: RegistryVersion[];
 }
 interface Registry {
@@ -208,7 +215,7 @@ export class PluginRegistryService {
         minTrekVersion: latest?.minTrekVersion ?? null,
         requiredAddons: latest?.requiredAddons ?? [],
         pluginDependencies: latest?.pluginDependencies ?? [],
-        screenshotUrl: latest ? rawFileUrl(p.repo, latest.commitSha, 'docs/screenshot.png') : null,
+        screenshotUrl: p.screenshotUrl ?? (latest ? rawFileUrl(p.repo, latest.commitSha, 'docs/screenshot.png') : null),
         signed: !!p.authorPublicKey && !!latest?.signature,
         authorPublicKey: p.authorPublicKey ?? null,
         ...this.hostCompat(p),
@@ -283,7 +290,7 @@ export class PluginRegistryService {
       publishedAt: latest?.publishedAt ?? null,
       requiredAddons: latest?.requiredAddons ?? [],
       pluginDependencies: latest?.pluginDependencies ?? [],
-      screenshotUrl: latest ? rawFileUrl(entry.repo, latest.commitSha, 'docs/screenshot.png') : null,
+      screenshotUrl: entry.screenshotUrl ?? (latest ? rawFileUrl(entry.repo, latest.commitSha, 'docs/screenshot.png') : null),
       signed: !!entry.authorPublicKey && !!latest?.signature,
       authorPublicKey: entry.authorPublicKey ?? null,
       ...this.hostCompat(entry),

server/src/services/memories/helpersService.ts

@@ -2,7 +2,7 @@ import { pipeline } from 'node:stream/promises';
 import { Readable } from 'node:stream';
 import { Response } from 'express';
 import { canAccessTrip, db } from "../../db/database";
-import { safeFetch, SsrfBlockedError } from '../../utils/ssrfGuard';
+import { safeFetch, SsrfBlockedError, type SafeFetchOptions } from '../../utils/ssrfGuard';
 import { decrypt_api_key } from '../apiKeyCrypto';
 
 // helpers for handling return types
@@ -251,9 +251,9 @@ export function updateSyncTimeForAlbumLink(linkId: string): void {
     db.prepare('UPDATE trip_album_links SET last_synced_at = CURRENT_TIMESTAMP WHERE id = ?').run(linkId);
 }
 
-export async function pipeAsset(url: string, response: Response, headers?: Record<string, string>, signal?: AbortSignal, defaultCacheControl?: string): Promise<void> {
+export async function pipeAsset(url: string, response: Response, headers?: Record<string, string>, signal?: AbortSignal, defaultCacheControl?: string, fetchOptions?: SafeFetchOptions): Promise<void> {
     try {
-        const resp = await safeFetch(url, { headers, signal: signal as any });
+        const resp = await safeFetch(url, { headers, signal: signal as any }, fetchOptions);
 
         response.status(resp.status);
         if (resp.headers.get('content-type')) response.set('Content-Type', resp.headers.get('content-type') as string);
@@ -284,6 +284,8 @@ export async function pipeAsset(url: string, response: Response, headers?: Recor
         if (error instanceof SsrfBlockedError) {
             response.status(400).json({ error: error.message });
         } else {
+            // Don't log the URL — it can carry a Synology _sid / passphrase.
+            console.error('pipeAsset: upstream fetch failed:', error);
             response.status(500).json({ error: 'Failed to fetch asset' });
         }
     }

server/src/services/memories/synologyService.ts

@@ -638,12 +638,13 @@ export async function fetchSynologyThumbnailBytes(
 
     const url = _buildSynologyEndpoint(synology_credentials.data.synology_url, params.toString());
     try {
-        const resp = await safeFetch(url);
+        const resp = await safeFetch(url, undefined, { rejectUnauthorized: !synology_credentials.data.synology_skip_ssl });
         if (!resp.ok) return { error: 'Upstream error', status: resp.status };
         const contentType = resp.headers.get('content-type') || 'image/jpeg';
         const bytes = Buffer.from(await resp.arrayBuffer());
         return { bytes, contentType };
-    } catch {
+    } catch (error) {
+        console.error('fetchSynologyThumbnailBytes: upstream fetch failed:', error);
         return { error: 'Proxy error', status: 502 };
     }
 }
@@ -700,6 +701,6 @@ export async function streamSynologyAsset(
     if (passphrase) params.append('passphrase', passphrase);
 
     const url = _buildSynologyEndpoint(synology_credentials.data.synology_url, params.toString());
-    await pipeAsset(url, response, undefined, undefined, 'public, max-age=86400')
+    await pipeAsset(url, response, undefined, undefined, 'public, max-age=86400', { rejectUnauthorized: !synology_credentials.data.synology_skip_ssl })
 }
 

server/src/services/notifications.ts

@@ -492,16 +492,25 @@ export function getAdminNtfyConfig(): NtfyConfig {
 }
 
 /**
- * Resolve the ntfy POST URL from admin base config + user override.
- * Returns null if topic cannot be determined.
+ * Resolve the ntfy POST URL for a per-user send. The topic must come from the
+ * user's own config — the admin topic is reserved for admin-scoped sends
+ * (see resolveAdminNtfyUrl). Only the server falls back to the admin default.
+ * Returns null if the user has no topic.
  */
 export function resolveNtfyUrl(adminCfg: NtfyConfig, userCfg: NtfyConfig | null): string | null {
-  const topic = userCfg?.topic || adminCfg.topic;
+  const topic = userCfg?.topic;
   if (!topic) return null;
   const base = (userCfg?.server || adminCfg.server || 'https://ntfy.sh').replace(/\/+$/, '');
   return `${base}/${encodeURIComponent(topic)}`;
 }
 
+/** Resolve the ntfy POST URL for admin-scoped sends. Returns null if no admin topic. */
+export function resolveAdminNtfyUrl(adminCfg: NtfyConfig): string | null {
+  if (!adminCfg.topic) return null;
+  const base = (adminCfg.server || 'https://ntfy.sh').replace(/\/+$/, '');
+  return `${base}/${encodeURIComponent(adminCfg.topic)}`;
+}
+
 function encodeHeaderValue(value: string): string {
   for (let i = 0; i < value.length; i++) {
     if (value.charCodeAt(i) > 0xff) {

server/src/services/notifications/builtins.ts

@@ -12,6 +12,7 @@ import {
   getUserNtfyConfig,
   getAdminNtfyConfig,
   resolveNtfyUrl,
+  resolveAdminNtfyUrl,
 } from '../notifications';
 import { registerChannel, type ChannelMessage, type ExternalChannel } from './channelRegistry';
 
@@ -92,7 +93,7 @@ const ntfyChannel: ExternalChannel = {
   },
   async sendGlobal(msg: ChannelMessage) {
     const adminCfg = getAdminNtfyConfig();
-    const url = resolveNtfyUrl(adminCfg, null);
+    const url = resolveAdminNtfyUrl(adminCfg);
     if (!url) return false;
     return sendNtfy(url, adminCfg.token, { event: msg.event, title: msg.title, body: msg.body, link: msg.url });
   },