v3.4.1 (#1606)

* fix(transit): lead arrive-by results with the latest arrival (#1479) MOTIS returns arrive-by itineraries ascending with the deadline-adjacent connection last, so the visible top of the list arrived ~2h before the requested time — misread as a timezone bug. Sort arrive-by results by endTime descending so the connection closest to the requested arrival leads, mirroring depart-by. Claude-Session: https://claude.ai/code/session_01BCrZUoPzHZF6H4C6avMXoz * fix(transit): lead arrive-by results with the latest arrival (#1479) MOTIS returns arrive-by itineraries ascending with the deadline-adjacent connection last, so the visible top of the list arrived ~2h before the requested time — misread as a timezone bug. Sort arrive-by results by endTime descending so the connection closest to the requested arrival leads, mirroring depart-by. * fix(reservations): run AirTrail modal hooks before the isOpen early return (#1602) The sectionItems useMemo added by #1535 sat below 'if (!isOpen) return null'. The modal mounts closed, so the first open render executed one more hook than the previous render and React unmounted the whole tree (error #310), blanking the page. Move the memo above the early return and cover the closed-then-open transition with a regression test. * fix(planner): only draw the check-in-day hotel morning leg when provably at/after check-in (#1597) (#1607) On an accommodation's check-in day the hotel -> first-stop leg was drawn by default for any PLACE first stop, suppressed only when that place was explicitly timed before check-in. An un-timed first place (e.g. "Home" on day 1 of a driving holiday) therefore always produced a phantom hotel -> Home leg, regardless of the check-in time. Flip the default to mirror shouldDrawEveningLeg: the morning leg is now drawn only when the first place is provably timed at/after check-in (you dropped your bags first). The drawn map route, the sidebar hotel connectors, and the Google Maps export all share this helper and inherit the fix. The optimizer anchors (#1321) are unchanged. * fix(notifications): never fall back to the admin ntfy topic for per-user sends (#1608) * chore: correct shields.io url * chore: correct shields.io url * chore: update helm repo link * chore: document new helm chart url * chore: document new helm chart url * fix(atlas): make Kosovo selectable on the Atlas map (#1609) Kosovo's user-assigned ISO code (XK/XKX) was missing from both code tables in the atlas pipeline: the geo builder's A3_TO_A2 map (so the shipped admin0 bundle carried ISO_A2: null) and the client's A2_TO_A3 map. With neither resolvable, onEachFeature attached no hover/click handlers to Kosovo's polygon and the country search dropped it, making Kosovo impossible to select. - add XK<->XKX to the client A2_TO_A3 table and the builder A3_TO_A2 map - stamp ISO_A2: "XK" on the Kosovo feature in the shipped admin0 bundle - guard both with tests (atlasModel resolution + ATLAS-BUNDLE-003) * chore: normalize docker image references to mauriceboe/trek (lowercase) * fix(memories): honor Synology skip-SSL on photo streaming (#1611) The synology_skip_ssl setting was forwarded on the JSON API path (login/browse/test-connection) but not on the image-byte fetches, so a NAS with a self-signed certificate passed Test Connection while /api/photos/:id/thumbnail and /original failed with 500 "Failed to fetch asset" — and the TLS error was silently swallowed. - pipeAsset: accept fetchOptions and forward to safeFetch; log the underlying error on the 500 path (without the URL, which carries _sid) - fetchSynologyThumbnailBytes / streamSynologyAsset: pass rejectUnauthorized derived from synology_skip_ssl; log on failure - i18n: replace hardcoded "Immich" with {provider_name} in 7 memories keys across 14 locales (source of the reported "Failed to connect to Immich" banner on the Synology test), fix translated placeholder names in tr/ca/pl, and add a placeholder-parity spec to prevent regressions - client: gallery provider badge matched 'synology' instead of the real id 'synologyphotos', showing the raw id; label is now "Synology Photos" * chore: make chart.liketrek.com the canonical helm chart url * feat(plugins): prefer the registry's resolved store screenshot (#1613) Browse/detail use the screenshotUrl the aggregate step resolves (cover at the latest commit, or the first resolving README image), falling back to the docs/screenshot.png guess when the field is absent. Fixes blank store cards for plugins without a committed docs/screenshot.png. --------- Co-authored-by: Maurice <61554723+mauriceboe@users.noreply.github.com>
2026-10-24 07:53:09 +00:00 · 2026-07-19 19:00:40 +02:00
parent 3ca1ef34bb
commit 91095ef96a
58 changed files with 673 additions and 223 deletions
@@ -194,7 +194,7 @@ export function GalleryView({ entries, gallery, journeyId, userId, trips, onPhot
                <div className="absolute top-1.5 left-1.5">
                  <span className="text-[8px] font-medium px-1.5 py-0.5 rounded-full bg-black/70 backdrop-blur text-white flex items-center gap-1">
                    <RefreshCw size={7} />
-                    {photo.provider === 'immich' ? 'Immich' : photo.provider === 'synology' ? 'Synology' : photo.provider}
+                    {photo.provider === 'immich' ? 'Immich' : photo.provider === 'synologyphotos' ? 'Synology Photos' : photo.provider}
                  </span>
                </div>
              )}
@@ -100,6 +100,15 @@ describe('AirTrailImportModal', () => {
    );
  });

+  it('FE-PLANNER-AIRTRAIL-011: opens after being mounted closed (#1602)', async () => {
+    // The modal stays mounted with isOpen=false until the AirTrail button is
+    // clicked — every hook must run on the closed renders too, or the open
+    // render throws "Rendered more hooks than during the previous render".
+    const { rerender } = render(<AirTrailImportModal {...defaultProps} isOpen={false} />);
+    rerender(<AirTrailImportModal {...defaultProps} isOpen={true} />);
+    expect(await screen.findByText('Import from AirTrail')).toBeInTheDocument();
+  });
+
  it('FE-PLANNER-AIRTRAIL-004: offers to join a detected connection, on by default', async () => {
    render(<AirTrailImportModal {...defaultProps} />);
    const joinRow = await screen.findByText(/one flight with a layover in HEL/i);
@@ -142,6 +142,24 @@ export default function AirTrailImportModal({ isOpen, onClose, tripId, pushUndo
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [flights, trip?.start_date, trip?.end_date])

+  // A chain renders once as a group, at the position of its first listed leg —
+  // its other legs are swallowed wherever else they would appear. Computed per
+  // section up front so a chain straddling the trip range can't leave the other
+  // section holding nothing but its header.
+  const sectionItems = useMemo(() => {
+    const rendered = new Set<string>()
+    const build = (list: AirtrailFlight[]) =>
+      list.flatMap((f): Array<{ key: string; chain?: AirtrailFlight[]; flight?: AirtrailFlight }> => {
+        const chain = chainOf.get(f.id)
+        if (!chain) return [{ key: f.id, flight: f }]
+        const key = chain.map(c => c.id).join('+')
+        if (rendered.has(key)) return []
+        rendered.add(key)
+        return [{ key, chain }]
+      })
+    return { during: build(during), others: build(others) }
+  }, [during, others, chainOf])
+
  const toggle = (id: string) => {
    setSelected(prev => {
      const next = new Set(prev)
@@ -286,24 +304,6 @@ export default function AirTrailImportModal({ isOpen, onClose, tripId, pushUndo
    )
  }

-  // A chain renders once as a group, at the position of its first listed leg —
-  // its other legs are swallowed wherever else they would appear. Computed per
-  // section up front so a chain straddling the trip range can't leave the other
-  // section holding nothing but its header.
-  const sectionItems = useMemo(() => {
-    const rendered = new Set<string>()
-    const build = (list: AirtrailFlight[]) =>
-      list.flatMap((f): Array<{ key: string; chain?: AirtrailFlight[]; flight?: AirtrailFlight }> => {
-        const chain = chainOf.get(f.id)
-        if (!chain) return [{ key: f.id, flight: f }]
-        const key = chain.map(c => c.id).join('+')
-        if (rendered.has(key)) return []
-        rendered.add(key)
-        return [{ key, chain }]
-      })
-    return { during: build(during), others: build(others) }
-  }, [during, others, chainOf])
-
  const renderItem = (item: { chain?: AirtrailFlight[]; flight?: AirtrailFlight }) =>
    item.chain ? renderChain(item.chain) : renderFlight(item.flight!)

@@ -172,6 +172,22 @@ describe('TransitSearchPanel', () => {
    expect(transitApiMock.plan.mock.calls[0][0]).toMatchObject({ arriveBy: true, time: '2025-06-01T08:00:00.000Z' })
  })

+  it('FE-PLANNER-TRANSIT-009: arrive-by lists the latest-arriving itinerary first', async () => {
+    const user = userEvent.setup()
+    // MOTIS returns arrive-by results ascending, deadline-adjacent last (#1479).
+    const later = { ...ITINERARY, startTime: '2025-06-01T07:10:00Z', endTime: '2025-06-01T07:40:00Z' }
+    transitApiMock.plan.mockResolvedValueOnce({ itineraries: [ITINERARY, later] })
+    render(<TransitSearchPanel {...makeProps()} />)
+    await pickFromAndTo(user)
+    await user.click(screen.getByRole('button', { name: 'Arrive' }))
+    await user.click(screen.getByRole('button', { name: /^Search$/ }))
+    await screen.findByText(/09:10 – 09:40/)
+    const cards = screen.getAllByText(/–/).filter(el => el.textContent?.match(/\d{2}:\d{2} – \d{2}:\d{2}/))
+    // The itinerary arriving closest to the requested arrival time leads.
+    expect(cards[0].textContent).toContain('09:40')
+    expect(cards[1].textContent).toContain('09:00')
+  })
+
  it('FE-PLANNER-TRANSIT-006: swap exchanges from and to', async () => {
    const user = userEvent.setup()
    render(<TransitSearchPanel {...makeProps()} />)
@@ -386,6 +386,10 @@ export default function TransitSearchPanel({ day, days, places, accommodations =
          to: { ...l.to, name: cleanStop(l.to.name) },
        })),
      }))
+      // MOTIS returns arrive-by results ascending with the deadline-adjacent
+      // connection last (#1479) — flip so the itinerary arriving closest to the
+      // requested time leads the list, mirroring depart-by.
+      if (arriveBy) cleaned.sort((a, b) => Date.parse(b.endTime) - Date.parse(a.endTime))
      setItineraries(cleaned)
    } catch {
      toast.error(t('transit.searchError'))
@@ -2064,15 +2064,17 @@ describe('JourneyDetailPage', () => {
  });

  // ── FE-PAGE-JOURNEYDETAIL-093 ──────────────────────────────────────────
-  describe('FE-PAGE-JOURNEYDETAIL-093: Gallery shows Synology badge for synology photos', () => {
-    it('renders "Synology" badge on photos from synology provider', async () => {
+  describe('FE-PAGE-JOURNEYDETAIL-093: Gallery shows Synology badge for synologyphotos photos', () => {
+    // The real provider id is 'synologyphotos' (see server ADDON_IDS/seeds);
+    // this previously used 'synology', which masked the raw-id badge bug (#1611).
+    it('renders "Synology Photos" badge, not the raw provider id', async () => {
      const user = userEvent.setup({ advanceTimers: vi.advanceTimersByTime });

      const synologyEntry = {
        ...mockJourneyDetail.entries[0],
        photos: [{
-          id: 201, entry_id: 10, photo_id: 201, provider: 'synology', file_path: null,
-          asset_id: 'syn-456', owner_id: 1, thumbnail_path: null,
+          id: 201, entry_id: 10, photo_id: 201, provider: 'synologyphotos', file_path: null,
+          asset_id: '456_cachekey', owner_id: 1, thumbnail_path: null,
          caption: null, sort_order: 0, width: 800, height: 600, shared: 1, created_at: now,
        }],
      };
@@ -2080,8 +2082,8 @@ describe('JourneyDetailPage', () => {
        entries: [synologyEntry, mockJourneyDetail.entries[1]],
        stats: { entries: 2, photos: 1, places: 2 },
        gallery: [{
-          id: 201, journey_id: 1, photo_id: 201, provider: 'synology', file_path: null,
-          asset_id: 'syn-456', owner_id: 1, thumbnail_path: null,
+          id: 201, journey_id: 1, photo_id: 201, provider: 'synologyphotos', file_path: null,
+          asset_id: '456_cachekey', owner_id: 1, thumbnail_path: null,
          caption: null, sort_order: 0, width: 800, height: 600, shared: 1, created_at: now,
        }],
      });
@@ -2098,7 +2100,8 @@ describe('JourneyDetailPage', () => {
        expect(screen.getByText(/1 photos/i)).toBeInTheDocument();
      });

-      expect(screen.getByText('Synology')).toBeInTheDocument();
+      expect(screen.getByText('Synology Photos')).toBeInTheDocument();
+      expect(screen.queryByText('synologyphotos')).not.toBeInTheDocument();
    });
  });

@@ -336,14 +336,14 @@ export default function AdminUserModals({ admin, t }: AdminUserModalsProps): Rea
                  }}
                  className="border border-gray-700 bg-gray-900 text-gray-100 dark:bg-gray-950"
                >
-                  {`docker pull mauriceboe/TREK:latest
+                  {`docker pull mauriceboe/trek:latest
 docker stop trek && docker rm trek
 docker run -d --name trek \\
  -p 3000:3000 \\
  -v /opt/trek/data:/app/data \\
  -v /opt/trek/uploads:/app/uploads \\
  --restart unless-stopped \\
-  mauriceboe/TREK:latest`}
+  mauriceboe/trek:latest`}
                </div>
              )}

@@ -1,5 +1,5 @@
 import { describe, it, expect } from 'vitest';
-import { normalizeRegionName } from './atlasModel';
+import { A2_TO_A3, normalizeRegionName } from './atlasModel';

 describe('normalizeRegionName', () => {
  it('matches names that only differ by diacritics (Ile-de-France vs Île-de-France)', () => {
@@ -18,3 +18,22 @@ describe('normalizeRegionName', () => {
    expect(normalizeRegionName('Bretagne')).not.toBe(normalizeRegionName('Brittany'));
  });
 });
+
+// Countries whose GeoJSON feature carries no usable ISO_A2 must be hardcoded in
+// A2_TO_A3 (see the comment above the table) or they get no map handlers at all.
+describe('A2_TO_A3 hardcoded entries (#1609)', () => {
+  it('maps Kosovo (XK → XKX)', () => {
+    expect(A2_TO_A3.XK).toBe('XKX');
+  });
+
+  it('resolves the shipped Kosovo feature (ADM0_A3=XKX, ISO_A2=null) to XK', () => {
+    // Mirrors the onEachFeature fallback in useAtlas.ts: reverse lookup by A3,
+    // then ISO_A2 — which is null for Kosovo in the bundled geoBoundaries data.
+    const feature = { properties: { ADM0_A3: 'XKX', ISO_A2: null as string | null } };
+    const a3 = feature.properties.ADM0_A3;
+    const a3ToA2Entry = Object.entries(A2_TO_A3).find(([, v]) => v === a3);
+    const isoA2 = feature.properties.ISO_A2;
+    const countryCode = a3ToA2Entry ? a3ToA2Entry[0] : (isoA2 && isoA2 !== '-99' ? isoA2 : null);
+    expect(countryCode).toBe('XK');
+  });
+});
@@ -71,10 +71,11 @@ export function countryCodeToFlag(code: string): string {
 }

 // ISO-3166-1 alpha-2 → alpha-3 mapping. Two sources feed this table:
-//   1. Hardcoded entries below — REQUIRED for any country whose Natural Earth GeoJSON record
-//      has ISO_A2='-99' (e.g. France=FRA, Norway=NOR). The runtime augmentation loop
-//      (see geoData useEffect below) skips '-99' features, so those countries MUST be
-//      listed here or the atlas_country_options A3-fallback will silently fail.
+//   1. Hardcoded entries below — REQUIRED for any country whose GeoJSON record has no
+//      usable ISO_A2: '-99' in Natural Earth data (e.g. France=FRA, Norway=NOR) or null
+//      in the geoBoundaries bundle (Kosovo=XKX, a user-assigned ISO code, #1609). The
+//      runtime augmentation loop (see geoData useEffect below) skips such features, so
+//      those countries MUST be listed here or the A3 fallbacks will silently fail.
 //   2. Runtime augmentation — the geoData load effect adds entries for every feature
 //      that has a valid ISO_A2, covering territories not present below.
-export const A2_TO_A3: Record<string, string> = {"AF":"AFG","AL":"ALB","DZ":"DZA","AD":"AND","AO":"AGO","AG":"ATG","AR":"ARG","AM":"ARM","AU":"AUS","AT":"AUT","AZ":"AZE","BS":"BHS","BH":"BHR","BD":"BGD","BB":"BRB","BY":"BLR","BE":"BEL","BZ":"BLZ","BJ":"BEN","BT":"BTN","BO":"BOL","BA":"BIH","BW":"BWA","BR":"BRA","BN":"BRN","BG":"BGR","BF":"BFA","BI":"BDI","CV":"CPV","KH":"KHM","CM":"CMR","CA":"CAN","CF":"CAF","TD":"TCD","CL":"CHL","CN":"CHN","CO":"COL","KM":"COM","CG":"COG","CD":"COD","CR":"CRI","CI":"CIV","HR":"HRV","CU":"CUB","CY":"CYP","CZ":"CZE","DK":"DNK","DJ":"DJI","DM":"DMA","DO":"DOM","EC":"ECU","EG":"EGY","SV":"SLV","GQ":"GNQ","ER":"ERI","EE":"EST","SZ":"SWZ","ET":"ETH","FJ":"FJI","FI":"FIN","FR":"FRA","GA":"GAB","GM":"GMB","GE":"GEO","DE":"DEU","GH":"GHA","GR":"GRC","GD":"GRD","GT":"GTM","GN":"GIN","GW":"GNB","GY":"GUY","HT":"HTI","HN":"HND","HU":"HUN","IS":"ISL","IN":"IND","ID":"IDN","IR":"IRN","IQ":"IRQ","IE":"IRL","IL":"ISR","IT":"ITA","JM":"JAM","JP":"JPN","JO":"JOR","KZ":"KAZ","KE":"KEN","KI":"KIR","KP":"PRK","KR":"KOR","KW":"KWT","KG":"KGZ","LA":"LAO","LV":"LVA","LB":"LBN","LS":"LSO","LR":"LBR","LY":"LBY","LI":"LIE","LT":"LTU","LU":"LUX","MG":"MDG","MW":"MWI","MY":"MYS","MV":"MDV","ML":"MLI","MT":"MLT","MR":"MRT","MU":"MUS","MX":"MEX","MD":"MDA","MN":"MNG","ME":"MNE","MA":"MAR","MZ":"MOZ","MM":"MMR","NA":"NAM","NP":"NPL","NL":"NLD","NZ":"NZL","NI":"NIC","NE":"NER","NG":"NGA","MK":"MKD","NO":"NOR","OM":"OMN","PK":"PAK","PA":"PAN","PG":"PNG","PY":"PRY","PE":"PER","PH":"PHL","PL":"POL","PT":"PRT","QA":"QAT","RO":"ROU","RU":"RUS","RW":"RWA","SA":"SAU","SN":"SEN","RS":"SRB","SL":"SLE","SG":"SGP","SK":"SVK","SI":"SVN","SB":"SLB","SO":"SOM","ZA":"ZAF","SS":"SSD","ES":"ESP","LK":"LKA","SD":"SDN","SR":"SUR","SE":"SWE","CH":"CHE","SY":"SYR","TW":"TWN","TJ":"TJK","TZ":"TZA","TH":"THA","TL":"TLS","TG":"TGO","TT":"TTO","TN":"TUN","TR":"TUR","TM":"TKM","UG":"UGA","UA":"UKR","AE":"ARE","GB":"GBR","US":"USA","UY":"URY","UZ":"UZB","VU":"VUT","VE":"VEN","VN":"VNM","YE":"YEM","ZM":"ZMB","ZW":"ZWE"}
+export const A2_TO_A3: Record<string, string> = {"AF":"AFG","AL":"ALB","DZ":"DZA","AD":"AND","AO":"AGO","AG":"ATG","AR":"ARG","AM":"ARM","AU":"AUS","AT":"AUT","AZ":"AZE","BS":"BHS","BH":"BHR","BD":"BGD","BB":"BRB","BY":"BLR","BE":"BEL","BZ":"BLZ","BJ":"BEN","BT":"BTN","BO":"BOL","BA":"BIH","BW":"BWA","BR":"BRA","BN":"BRN","BG":"BGR","BF":"BFA","BI":"BDI","CV":"CPV","KH":"KHM","CM":"CMR","CA":"CAN","CF":"CAF","TD":"TCD","CL":"CHL","CN":"CHN","CO":"COL","KM":"COM","CG":"COG","CD":"COD","CR":"CRI","CI":"CIV","HR":"HRV","CU":"CUB","CY":"CYP","CZ":"CZE","DK":"DNK","DJ":"DJI","DM":"DMA","DO":"DOM","EC":"ECU","EG":"EGY","SV":"SLV","GQ":"GNQ","ER":"ERI","EE":"EST","SZ":"SWZ","ET":"ETH","FJ":"FJI","FI":"FIN","FR":"FRA","GA":"GAB","GM":"GMB","GE":"GEO","DE":"DEU","GH":"GHA","GR":"GRC","GD":"GRD","GT":"GTM","GN":"GIN","GW":"GNB","GY":"GUY","HT":"HTI","HN":"HND","HU":"HUN","IS":"ISL","IN":"IND","ID":"IDN","IR":"IRN","IQ":"IRQ","IE":"IRL","IL":"ISR","IT":"ITA","JM":"JAM","JP":"JPN","JO":"JOR","KZ":"KAZ","KE":"KEN","KI":"KIR","XK":"XKX","KP":"PRK","KR":"KOR","KW":"KWT","KG":"KGZ","LA":"LAO","LV":"LVA","LB":"LBN","LS":"LSO","LR":"LBR","LY":"LBY","LI":"LIE","LT":"LTU","LU":"LUX","MG":"MDG","MW":"MWI","MY":"MYS","MV":"MDV","ML":"MLI","MT":"MLT","MR":"MRT","MU":"MUS","MX":"MEX","MD":"MDA","MN":"MNG","ME":"MNE","MA":"MAR","MZ":"MOZ","MM":"MMR","NA":"NAM","NP":"NPL","NL":"NLD","NZ":"NZL","NI":"NIC","NE":"NER","NG":"NGA","MK":"MKD","NO":"NOR","OM":"OMN","PK":"PAK","PA":"PAN","PG":"PNG","PY":"PRY","PE":"PER","PH":"PHL","PL":"POL","PT":"PRT","QA":"QAT","RO":"ROU","RU":"RUS","RW":"RWA","SA":"SAU","SN":"SEN","RS":"SRB","SL":"SLE","SG":"SGP","SK":"SVK","SI":"SVN","SB":"SLB","SO":"SOM","ZA":"ZAF","SS":"SSD","ES":"ESP","LK":"LKA","SD":"SDN","SR":"SUR","SE":"SWE","CH":"CHE","SY":"SYR","TW":"TWN","TJ":"TJK","TZ":"TZA","TH":"THA","TL":"TLS","TG":"TGO","TT":"TTO","TN":"TUN","TR":"TUR","TM":"TKM","UG":"UGA","UA":"UKR","AE":"ARE","GB":"GBR","US":"USA","UY":"URY","UZ":"UZB","VU":"VUT","VE":"VEN","VN":"VNM","YE":"YEM","ZM":"ZMB","ZW":"ZWE"}
@@ -178,13 +178,13 @@ describe('shouldDrawMorningLeg', () => {
    expect(shouldDrawMorningLeg(bookends, checkInDay, { isPlace: true, time: '15:00' })).toBe(true)
  })

-  it('DRAWS on a check-in day when time info is missing (home-base default, no over-suppression)', () => {
-    // Without a comparable place time or hotel check-in time, the arrival day stays a
-    // home-base loop — only a place provably before check-in suppresses the leg.
+  it('does NOT draw on a check-in day when time info is missing (#1597)', () => {
+    // An un-timed first place on an arrival day ("Home" before driving out) cannot prove
+    // you were at the hotel yet, so no hotel → first-stop leg — mirroring the evening rule.
    const bookends = { morning: into({ check_in: '15:00' }), morningIsSleptHere: false }
-    expect(shouldDrawMorningLeg(bookends, checkInDay, { isPlace: true, time: null })).toBe(true)
+    expect(shouldDrawMorningLeg(bookends, checkInDay, { isPlace: true, time: null })).toBe(false)
    const noCheckIn = { morning: into({ check_in: null }), morningIsSleptHere: false }
-    expect(shouldDrawMorningLeg(noCheckIn, checkInDay, { isPlace: true, time: '19:00' })).toBe(true)
+    expect(shouldDrawMorningLeg(noCheckIn, checkInDay, { isPlace: true, time: '19:00' })).toBe(false)
  })

  it('does NOT draw on a check-in day for a transport arrival (not a place, #1321)', () => {
@@ -58,11 +58,12 @@ export const getAccommodationAnchors = (
 }

 // Whether to draw the morning hotel → first-stop leg. It is a real drive when you slept in the
-// morning hotel (a normal home-base day). On that hotel's check-in day the hotel is your base
-// once you arrive, so the leg is still the default for a PLACE first stop — suppressed only when
-// that place is timed BEFORE check-in (an airport you reach before dropping your bags, #1465), or
-// when the first stop is a transport arrival (you flew in, weren't at the hotel yet, #1321).
-// Un-timed places keep the loop, avoiding over-suppression on ordinary arrival days.
+// morning hotel (a normal home-base day). On that hotel's check-in day you were traveling TO the
+// hotel, so the leg is drawn only when the first stop is a PLACE provably timed at/after check-in
+// (you dropped your bags first). A place before check-in (an airport you reach first, #1465), a
+// transport arrival (you flew in, weren't at the hotel yet, #1321), an un-timed place ("Home"
+// before driving out, #1597), or a missing check-in time all mean no leg — mirroring the
+// evening rule below.
 export const shouldDrawMorningLeg = (
  bookends: { morning?: Accommodation; morningIsSleptHere?: boolean },
  day: Day,
@@ -73,7 +74,7 @@ export const shouldDrawMorningLeg = (
  if (!m || m.start_day_id !== day.id || !firstStop?.isPlace) return false
  const checkIn = parseTimeToMinutes(m.check_in)
  const stop = parseTimeToMinutes(firstStop.time)
-  return !(checkIn != null && stop != null && stop < checkIn)
+  return checkIn != null && stop != null && stop >= checkIn
 }

 // Mirror of shouldDrawMorningLeg for the last-stop → hotel evening leg. It is a real drive when