moving linking album to common interface

server/src/services/immichService.ts

@@ -285,22 +285,6 @@ export async function listAlbums(
 }
 
 
-export function createAlbumLink(
-  tripId: string,
-  userId: number,
-  albumId: string,
-  albumName: string
-): { success: boolean; error?: string } {
-  try {
-    db.prepare(
-      'INSERT OR IGNORE INTO trip_album_links (trip_id, user_id, provider, album_id, album_name) VALUES (?, ?, ?, ?, ?)'
-    ).run(tripId, userId, 'immich', albumId, albumName || '');
-    return { success: true };
-  } catch {
-    return { success: false, error: 'Album already linked' };
-  }
-}
-
 export async function syncAlbumAssets(
   tripId: string,
   linkId: string,

server/src/services/memoriesService.ts

@@ -76,6 +76,37 @@ export function listTripAlbumLinks(tripId: string, userId: number): { links: any
   return { links };
 }
 
+export function createTripAlbumLink(
+  tripId: string,
+  userId: number,
+  providerRaw: unknown,
+  albumIdRaw: unknown,
+  albumNameRaw: unknown,
+): { success: true } | ServiceError {
+  const denied = accessDeniedIfMissing(tripId, userId);
+  if (denied) return denied;
+
+  const provider = String(providerRaw || '').toLowerCase();
+  const albumId = String(albumIdRaw || '').trim();
+  const albumName = String(albumNameRaw || '').trim();
+
+  if (!provider) {
+    return { error: 'provider is required', status: 400 };
+  }
+  if (!albumId) {
+    return { error: 'album_id required', status: 400 };
+  }
+
+  try {
+    db.prepare(
+      'INSERT OR IGNORE INTO trip_album_links (trip_id, user_id, provider, album_id, album_name) VALUES (?, ?, ?, ?, ?)'
+    ).run(tripId, userId, provider, albumId, albumName);
+    return { success: true };
+  } catch {
+    return { error: 'Album already linked', status: 400 };
+  }
+}
+
 export function removeAlbumLink(tripId: string, linkId: string, userId: number): { success: true } | ServiceError {
   const denied = accessDeniedIfMissing(tripId, userId);
   if (denied) return denied;

server/src/services/synologyService.ts

@@ -438,23 +438,6 @@ export async function listSynologyAlbums(userId: number): Promise<{ albums: Arra
     return { albums };
 }
 
-export function linkSynologyAlbum(userId: number, tripId: string, albumId: string | number | undefined, albumName?: string): void {
-    if (!canAccessTrip(tripId, userId)) {
-        throw new SynologyServiceError(404, 'Trip not found');
-    }
-
-    if (!albumId) {
-        throw new SynologyServiceError(400, 'album_id required');
-    }
-
-    const changes = db.prepare(
-        'INSERT OR IGNORE INTO trip_album_links (trip_id, user_id, provider, album_id, album_name) VALUES (?, ?, ?, ?, ?)'
-    ).run(tripId, userId, SYNOLOGY_PROVIDER, String(albumId), albumName || '').changes;
-
-    if (changes === 0) {
-        throw new SynologyServiceError(400, 'Album already linked');
-    }
-}
 
 export async function syncSynologyAlbumLink(userId: number, tripId: string, linkId: string): Promise<{ added: number; total: number }> {
     const link = db.prepare(`SELECT * FROM trip_album_links WHERE id = ? AND trip_id = ? AND user_id = ? AND provider = ?`)