k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-06-19 13:21:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(systemNotices): exclude v3 upgrade notices from login_count-only tests

Browse Source 
Tests that expect an empty notice list were using first_seen_version='0.0.0'
(DB default), which matches the existingUserBeforeVersion('3.0.0') condition
now that the app is at 3.0.1. Set first_seen_version='3.0.0' so only the
firstLogin condition controls visibility in these tests.
This commit is contained in:
jubnl
2026-04-22 21:19:04 +02:00
parent 2cea4d73aa
commit 9093948ff6
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/tests/integration/systemNotices.test.ts
+4 -3
View File
@@ -84,8 +84,9 @@ describe('GET /api/system-notices/active', () => {
it('returns empty array for non-first-login user with no applicable notices', async () => { it('returns empty array for non-first-login user with no applicable notices', async () => {
const { user } = createUser(testDb); const { user } = createUser(testDb);
// login_count > 1 means firstLogin condition does not match for any notice // login_count > 1 means firstLogin condition does not match for any notice;
testDb.prepare('UPDATE users SET login_count = 5 WHERE id = ?').run(user.id); // first_seen_version >= 3.0.0 means existingUserBeforeVersion('3.0.0') also does not match
testDb.prepare('UPDATE users SET login_count = 5, first_seen_version = ? WHERE id = ?').run('3.0.0', user.id);
const res = await request(app) const res = await request(app)
.get('/api/system-notices/active') .get('/api/system-notices/active')
.set('Cookie', authCookie(user.id)); .set('Cookie', authCookie(user.id));
@@ -122,7 +123,7 @@ describe('GET /api/system-notices/active', () => {
SYSTEM_NOTICES.push(TEST_NOTICE); SYSTEM_NOTICES.push(TEST_NOTICE);
try { try {
const { user } = createUser(testDb); const { user } = createUser(testDb);
testDb.prepare('UPDATE users SET login_count = 5 WHERE id = ?').run(user.id); testDb.prepare('UPDATE users SET login_count = 5, first_seen_version = ? WHERE id = ?').run('3.0.0', user.id);
const res = await request(app) const res = await request(app)
.get('/api/system-notices/active') .get('/api/system-notices/active')