fix(client): the audit round over the 4.3.1 release

Ride minutes and late marks follow an edited timetable instead of the routing
that fetched them; a landing day's join band reads as the ride it is rather
than a nine hour drive of no length; the refuel offer is there on the road
out of a terminal or a pick-up desk; the phone's stage map draws the ride;
the share page numbers its stops the way the planner does; the PDF lists a
day the way the day plan lists it, from both shells; a poster-less clip draws
its play badge everywhere, not only in the editor; the hero title has room
for its descenders and the list card keeps its badge clear; the release
notice keeps its close control in reach when it stacks; a link chip's actions
are thumb-sized and its delete asks first; the Google retry line and the
Google-only switch appear only where Google answers.

client/src/utils/placeSource.test.ts

@@ -1,8 +1,8 @@
 import { describe, expect, it } from 'vitest'
-import { offersGoogleRetry, sourceLabelFor } from './placeSource'
+import { googleHoldsSlot, offersGoogleRetry, placesGoogleOnlyHint, selectGoogleHoldsSlot, sourceLabelFor } from './placeSource'
 
 describe('offersGoogleRetry', () => {
-  it('FE-PLACESOURCE-001: offers Google for a list the index or OpenStreetMap answered, only where a key exists', () => {
+  it('FE-PLACESOURCE-001: offers Google for a list the index or OpenStreetMap answered, only where Google answers', () => {
     expect(offersGoogleRetry('trek-places+openstreetmap', true)).toBe(true)
     expect(offersGoogleRetry('openstreetmap', true)).toBe(true)
     expect(offersGoogleRetry('trek-places+plugin', true)).toBe(true)
@@ -17,6 +17,37 @@ describe('offersGoogleRetry', () => {
   })
 })
 
+describe('googleHoldsSlot', () => {
+  it('FE-PLACESOURCE-004: a key holds the slot under auto and google, not under Amap or OpenStreetMap', () => {
+    expect(googleHoldsSlot(true, 'auto')).toBe(true)
+    expect(googleHoldsSlot(true, 'google')).toBe(true)
+    // A stored key still serves photos and details here, but the server never
+    // walks the Google chain for a search, so a link that offered it would be dead.
+    expect(googleHoldsSlot(true, 'amap')).toBe(false)
+    expect(googleHoldsSlot(true, 'openstreetmap')).toBe(false)
+    expect(googleHoldsSlot(false, 'google')).toBe(false)
+    // Unrecognised reads as auto, as the server reads it.
+    expect(googleHoldsSlot(true, '')).toBe(true)
+  })
+
+  it('FE-PLACESOURCE-005: the store selector asks the same question of the auth state', () => {
+    expect(selectGoogleHoldsSlot({ hasMapsKey: true, placesProvider: 'auto' })).toBe(true)
+    expect(selectGoogleHoldsSlot({ hasMapsKey: true, placesProvider: 'openstreetmap' })).toBe(false)
+    expect(selectGoogleHoldsSlot({ hasMapsKey: false, placesProvider: 'auto' })).toBe(false)
+  })
+})
+
+describe('placesGoogleOnlyHint', () => {
+  it('FE-PLACESOURCE-006: names what the admin has to do before the switch does anything', () => {
+    expect(placesGoogleOnlyHint(false, 'auto')).toBe('admin.placesGoogleOnly.missingKey')
+    expect(placesGoogleOnlyHint(false, 'openstreetmap')).toBe('admin.placesGoogleOnly.missingKey')
+    expect(placesGoogleOnlyHint(true, 'amap')).toBe('admin.placesGoogleOnly.otherProvider')
+    expect(placesGoogleOnlyHint(true, 'openstreetmap')).toBe('admin.placesGoogleOnly.otherProvider')
+    expect(placesGoogleOnlyHint(true, 'auto')).toBe('admin.placesGoogleOnly.subtitle')
+    expect(placesGoogleOnlyHint(true, 'google')).toBe('admin.placesGoogleOnly.subtitle')
+  })
+})
+
 describe('sourceLabelFor', () => {
   it('FE-PLACESOURCE-003: a row names its own index, else the list it came from', () => {
     const t = (k: string) => k