k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-25 00:13:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(client): work through the findings from the coverage pass

Browse Source 
214 items came out of writing the tests. Real defects are corrected, dead code
is removed rather than covered, and the tests that pinned the old behaviour
move with them.

Also drops two agent coverage scratch files that slipped into the coverage PR
and adds the ignore rule that keeps them out.
This commit is contained in:
Maurice
2026-07-29 11:57:24 +02:00
committed by Maurice
parent a4bf815d24
commit 72a82b3c44
425 changed files with 3155 additions and 1968 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/components/Map/reservationsMapbox.test.ts
+3 -5
View File
@@ -264,7 +264,6 @@ describe('ReservationMapboxOverlay lifecycle', () => {
expect(glMarkers.every(m => m.remove.mock.calls.length > 0)).toBe(true)
expect(map.listeners('zoomend')).toBe(0)
expect(map.listeners('moveend')).toBe(0)
expect(map.listeners('render')).toBe(0)
expect(map.removeLayer).toHaveBeenCalledWith(RESERVATION_LINE_LAYER_ID)
expect(map.removeSource).toHaveBeenCalledWith(RESERVATION_SOURCE_ID)
})
@@ -287,20 +286,18 @@ describe('ReservationMapboxOverlay lifecycle', () => {
expect(features(map)).toHaveLength(1)
})
it('FE-COMP-RESGL-006: the redraw and rotation handlers are inert once the overlay is destroyed', () => {
it('FE-COMP-RESGL-006: the redraw handler is inert once the overlay is destroyed', () => {
const map = freshMap()
const overlay = attach(map)
const handlerFor = (event: string) =>
map.on.mock.calls.find(c => c[0] === event)?.[1] as Handler
const rerender = handlerFor('moveend')
const rotate = handlerFor('render')
overlay.update([booking()], opts)
const drawsBefore = map._sources.get(RESERVATION_SOURCE_ID)!.setData.mock.calls.length
overlay.destroy()
rerender()
rotate()
expect(map._sources.get(RESERVATION_SOURCE_ID)).toBeUndefined()
expect(drawsBefore).toBeGreaterThan(0)
})
@@ -700,7 +697,7 @@ describe('ReservationMapboxOverlay transit styling', () => {
})
describe('ReservationMapboxOverlay frame handler', () => {
it('FE-COMP-RESGL-042: a paint frame rotates only — it does not redraw the overlay', () => {
it('FE-COMP-RESGL-042: the overlay does not subscribe to paint frames — only camera events redraw it', () => {
const map = freshMap()
const overlay = attach(map)
overlay.update([booking()], opts)
@@ -708,6 +705,7 @@ describe('ReservationMapboxOverlay frame handler', () => {
map.fire('render')
expect(map.listeners('render')).toBe(0)
expect(map._sources.get(RESERVATION_SOURCE_ID)!.setData.mock.calls).toHaveLength(drawsBefore)
expect(glMarkers).toHaveLength(2)
expect(glMarkers.every(m => m.remove.mock.calls.length === 0)).toBe(true)