k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-18 21:16:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(trips): scope the offline bundle's packing items to the viewer (#858)

Browse Source
This commit is contained in:
jubnl
2026-07-26 16:57:02 +02:00
parent 934848e114
commit 7242812b27
5 changed files with 31 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/tests/unit/nest/trips.service.test.ts
+7 -4
View File
@@ -40,7 +40,8 @@ import type { PackingService } from '../../../src/nest/packing/packing.service';
import { rebaseTripCurrency } from '../../../src/services/budgetService';
const todoStub = { listItems: () => [] } as unknown as TodoService;
const packingStub = { listItems: () => [] } as unknown as PackingService;
const packingListItems = vi.fn(() => []);
const packingStub = { listItems: packingListItems } as unknown as PackingService;
function svc() { return new TripsService(new DatabaseService(dbConn), todoStub, packingStub); }
beforeEach(() => vi.clearAllMocks());
@@ -99,14 +100,16 @@ describe('TripsService (wrapper delegation + bundle/copy/notify helpers)', () =>
expect(dbMock.prepare).toHaveBeenCalledWith(expect.stringContaining('SELECT * FROM trips t'));
});
it('bundle aggregates every sub-collection + the member list', () => {
const result = svc().bundle('9', { user_id: 1 });
it('bundle aggregates every sub-collection + the member list, scoping packing to the viewer (#858)', () => {
const result = svc().bundle('9', { user_id: 1 }, 7);
expect(result).toMatchObject({ trip: { user_id: 1 }, days: [1], places: [], members: [{ id: 1 }] });
// The viewer id is forwarded so other members' private items stay out of the offline cache.
expect(packingListItems).toHaveBeenCalledWith('9', 7);
});
it('bundle tolerates a null member list', () => {
tripSvc.listMembers.mockReturnValueOnce({ owner: { id: 1 }, members: null });
const result = svc().bundle('9', { user_id: 1 });
const result = svc().bundle('9', { user_id: 1 }, 1);
expect(result).toMatchObject({ members: [{ id: 1 }] });
});