mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-11-20 19:16:08 +00:00
fix(db): check the Postgres server and tools before a dump or a restore
- The client tools are looked for newest first, from 18 down: a client handles every server up to its own major and refuses a newer one. A dump or a restore now refuses a client older than the server up front, naming both versions, and the boot refuses a server outside PostgreSQL 14 to 18. - sslrootcert=system is used only by a client from libpq 16 on; an older client is refused with a message that names sslrootcert and the bin dir. - The restore's CVE-2025-8714 table covers 18. - A restore refuses a role that is a superuser or may run programs or write files on the database host, since the archive's SQL runs as that role; the boot warns about such a role. - pg_restore's script is streamed to its work file and stopped once it passes BACKUP_MAX_DECOMPRESSED_MB, so a small dump can no longer expand without limit on the data volume. - A failed tool's error keeps only the summarized stderr; its cause names the exit code and signal instead of carrying the process error, whose message and stderr quoted row data into the log. - The migration history is looked for in the current schema, where the tables and the backups are, so a role whose search_path is not public boots a second time.
This commit is contained in:
@@ -9,6 +9,7 @@ import { DomainError } from '../common/domain-error';
|
||||
import type { DatabaseBackupStrategy } from '../database/database-backup.interface';
|
||||
import { DATABASE_ENGINE, DATABASE_SETTINGS } from '../database/database-engine.module';
|
||||
import { DatabaseLifecycle } from '../database/database-lifecycle.service';
|
||||
import { MAX_BACKUP_DECOMPRESSED_SIZE } from './backup-archive';
|
||||
import { keepRestoreCopy, replaceThenReopen } from './database-swap';
|
||||
import { Inject, Injectable } from '@nestjs/common';
|
||||
|
||||
@@ -117,7 +118,7 @@ export class PostgresDatabaseBackup implements DatabaseBackupStrategy {
|
||||
async () => {
|
||||
const { url, binDir } = this.connection;
|
||||
// A rejection with no reason still has to fail the swap, so it is never swallowed.
|
||||
await pgRestore(url, source, binDir).catch((err: unknown) => {
|
||||
await pgRestore(url, source, binDir, MAX_BACKUP_DECOMPRESSED_SIZE).catch((err: unknown) => {
|
||||
throw err ?? new Error('pg_restore failed');
|
||||
});
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user