fix(planner): let a booking's day follow its date when edited (#1237)

Preserving the old day_id on edit left a re-dated booking on its previous start
day while end_day_id followed the new date, so it spanned both. Stop sending
day_id from the edit modal entirely - the server derives both ends from the
booking's date (and keeps the current day when there is no date), so a re-dated
booking moves cleanly to the matching day.

client/src/pages/TripPlannerPage.test.tsx

@@ -1160,7 +1160,7 @@ describe('TripPlannerPage', () => {
   });
 
   describe('FE-PAGE-PLANNER-041: handleSaveReservation edit path covers update reservation', () => {
-    it('preserves the reservation day_id on edit so it stays in the Plan (#1237)', async () => {
+    it('does not force a day_id on edit so the server keeps/derives it (#1237)', async () => {
       vi.useFakeTimers();
 
       seedTripStore({ id: 42 });
@@ -1196,12 +1196,10 @@ describe('TripPlannerPage', () => {
         });
       });
 
-      // The booking must keep its own day_id (not be nulled to the selected day).
+      // The client must NOT send a day_id (no forcing to the selected day, no
-      expect(updateReservationSpy).toHaveBeenCalledWith(
+      // stale value) — the server keeps/derives it from the booking's date.
-        expect.anything(),
+      expect(updateReservationSpy).toHaveBeenCalled();
-        1,
+      expect(updateReservationSpy.mock.calls[0][2]).not.toHaveProperty('day_id');
-        expect.objectContaining({ day_id: 7 }),
-      );
     });
   });
 

client/src/pages/tripPlanner/useTripPlanner.ts

@@ -568,10 +568,12 @@ export function useTripPlanner() {
   const handleSaveReservation = async (data: Record<string, string | number | null> & { title: string }) => {
     try {
       if (editingReservation) {
-        // Keep the reservation on its own day. Forcing selectedDayId here dropped
+        // Don't force a day here. The old code pinned it to the (often empty)
-        // the booking out of the Plan when edited from the Book tab (no day
+        // selected day, which dropped the booking out of the Plan; preserving the
-        // selected -> selectedDayId null -> day_id nulled).
+        // old day_id instead left it stale when the date changed. Omitting it lets
-        const r = await tripActions.updateReservation(tripId, editingReservation.id, { ...data, day_id: editingReservation.day_id ?? null })
+        // the server derive the day from the booking's date, or keep the current
+        // one when there is no date.
+        const r = await tripActions.updateReservation(tripId, editingReservation.id, data)
         toast.success(t('trip.toast.reservationUpdated'))
         setShowReservationModal(false)
         setEditingReservation(null)

server/tests/integration/reservations.test.ts

@@ -200,6 +200,29 @@ describe('Update reservation', () => {
     expect(res.body.reservation.day_id).toBe(day2.id);
   });
 
+  it('RESV-004c — re-dating a booking moves it to the matching day (start + end) (#1237)', async () => {
+    const { user } = createUser(testDb);
+    const trip = createTrip(testDb, user.id);
+    const day1 = createDay(testDb, trip.id, { date: '2025-10-01' });
+    const day3 = createDay(testDb, trip.id, { date: '2025-10-03' });
+
+    // Booking sits on day 1 (start + end).
+    const created = await request(app)
+      .post(`/api/trips/${trip.id}/reservations`)
+      .set('Cookie', authCookie(user.id))
+      .send({ title: 'Event', type: 'event', day_id: day1.id, reservation_time: '2025-10-01T09:00', reservation_end_time: '2025-10-01T10:00' });
+    const rid = created.body.reservation.id;
+
+    // Re-date to day 3 WITHOUT sending day_id (the modal omits it) — both ends follow.
+    const res = await request(app)
+      .put(`/api/trips/${trip.id}/reservations/${rid}`)
+      .set('Cookie', authCookie(user.id))
+      .send({ title: 'Event', type: 'event', reservation_time: '2025-10-03T00:00', reservation_end_time: '2025-10-03T14:00' });
+    expect(res.status).toBe(200);
+    expect(res.body.reservation.day_id).toBe(day3.id);
+    expect(res.body.reservation.end_day_id).toBe(day3.id);
+  });
+
   it('RESV-004 — PUT on non-existent reservation returns 404', async () => {
     const { user } = createUser(testDb);
     const trip = createTrip(testDb, user.id);