fix(db): run every repository statement the Postgres probe reaches

The probe's baseline is empty now: no repository method Postgres refuses,
none it cannot measure.

- reservations.accommodation_id (TEXT) is cast where it is compared with
  day_accommodations.id (INTEGER), in the four reservation reads and the two
  stay reads; SQLite coerced the bare comparison, Postgres refuses it. The
  joined RS18/RR1 read moves to reservation-join.ts beside the repository.
- The usage counters qualify the target row's column in DO UPDATE SET, which
  Postgres reads as ambiguous with `excluded` otherwise.
- ReservationDayPositions.upsertScoped upserts on its primary key instead of
  INSERT OR REPLACE; position is the only other column and nothing references
  the table, so the row left behind is the same.
- PRAGMA wal_checkpoint and VACUUM INTO move from MaintenanceRepository to
  SqliteMaintenance under src/db/engine/sqlite/, the SQLite engine's folder,
  where lint:dialect allows PRAGMA.
- The places list takes category and tag ids as numbers: the service converts
  the query text with toRowId and answers an empty list for one that is no
  id, instead of binding the text to an integer column.
- The probe samples the `present` flag of a partial update's pair as true, so
  the four update methods that sent no SQL are measured, and it now holds
  SQLSTATE class 22 too: a value of the wrong type reaching a column is the
  code's, since the sampler sends what each parameter declares.
This commit is contained in:
Isaias Tavares
2026-11-02 12:48:08 -03:00
parent 14c767a675
commit 62912e5db1
36 changed files with 475 additions and 274 deletions
+2 -19
View File
@@ -1,21 +1,4 @@
{
"failing": {
"DayAccommodationsRepository.listForTripWithPlaceAndBooking": 1,
"DayAccommodationsRepository.listRoadtripStays": 1,
"GoogleApiUsageRepository.recordCall": 1,
"MaintenanceRepository.vacuumInto": 1,
"MaintenanceRepository.walCheckpoint": 1,
"ReservationDayPositionsRepository.upsertScoped": 1,
"ReservationsRepository.findWithJoins": 1,
"ReservationsRepository.listForCalendar": 1,
"ReservationsRepository.listForTrip": 1,
"ReservationsRepository.listPublicStaysForCalendar": 1,
"RouteUsageDailyRepository.record": 1
},
"uncovered": [
"BucketListRepository.update",
"BudgetItemsRepository.update",
"PackingBagsRepository.update",
"TodoItemsRepository.update"
]
"failing": {},
"uncovered": []
}