k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-20 05:56:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(storage): retire photos as a configurable category — served-only via the ServedCategory seam

Browse Source
This commit is contained in:
jubnl
2026-08-20 20:20:43 +02:00
parent bbede7ab98
commit 49976ab383
10 changed files with 74 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/tests/e2e/storage-admin.e2e.test.ts
+1 -1
View File
@@ -125,7 +125,7 @@ describe('Storage admin e2e (real auth + admin guard + managed guard + temp SQLi
expect(res.status).toBe(200);
const names = (res.body.backends as Array<{ name: string; source: string }>).map((b) => [b.name, b.source]);
expect(names).toEqual(expect.arrayContaining([['uploads-local', 'built-in'], ['backups-local', 'built-in']]));
expect(Object.keys(res.body.categories)).toHaveLength(9);
expect(Object.keys(res.body.categories)).toHaveLength(8);
expect(res.body.encryptionReady).toBe(true);
expect(res.body.seedFilePresent).toBe(false);
expect(res.body.health).toEqual({ replicaFailures: [] });
server/tests/unit/nest/storage/storage-registry.service.test.ts
+20
View File
@@ -193,6 +193,25 @@ describe('StorageRegistryService defaults', () => {
path.join(fs.realpathSync(relocated), 'files/x.pdf'),
);
});
it('serves the legacy photos category from uploads-local without any config (ServedCategory seam)', () => {
const relocated = makeTmpDir();
const { registry } = makeRegistry({ uploadsRoot: relocated });
const photos = registry.resolve('photos');
expect(photos.backendName).toBe('uploads-local');
expect(photos.keyPrefix).toBe('photos/');
// Override-following: relocating uploads moves the legacy photos with it.
expect(photos.driver.getLocalPath!('photos/x.jpg')).toBe(
path.join(fs.realpathSync(relocated), 'photos/x.jpg'),
);
});
it('the admin snapshot exposes only the 8 configurable categories — photos is served, not configurable', () => {
const { registry } = makeRegistry();
const keys = Object.keys(registry.snapshot().categories);
expect(keys).toHaveLength(8);
expect(keys).not.toContain('photos');
});
});
// ── settings merge + validation ───────────────────────────────────────────────
@@ -251,6 +270,7 @@ describe('StorageRegistryService settings', () => {
undefined,
],
['unknown category name', undefined, JSON.stringify({ 'not-a-category': 'uploads-local' })],
['retired photos category in settings', undefined, JSON.stringify({ photos: 'uploads-local' })],
['malformed JSON', 'not json at all', undefined],
])('falls back to built-in defaults at boot on invalid settings: %s', (_label, backendsRow, categoriesRow) => {
const { registry } = makeRegistry({ boot: false });