From 4976fe5e7f29768994d73a2b08134525e765c634 Mon Sep 17 00:00:00 2001 From: Maurice Date: Sat, 11 Apr 2026 19:30:59 +0200 Subject: [PATCH] fix: remaining Dashboard test failures for list view + duplicate elements MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - DASH-016/017: Spotlight trip not in list view — test non-spotlight trip instead - DASH-021: New trip appears in both mobile + desktop — use getAllByText --- client/src/pages/DashboardPage.test.tsx | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/client/src/pages/DashboardPage.test.tsx b/client/src/pages/DashboardPage.test.tsx index 20448828..ecc24488 100644 --- a/client/src/pages/DashboardPage.test.tsx +++ b/client/src/pages/DashboardPage.test.tsx @@ -339,20 +339,18 @@ describe('DashboardPage', () => { render(); await waitFor(() => { - expect(screen.getAllByText('Paris Adventure').length).toBeGreaterThan(0); + expect(screen.getAllByText('Tokyo Trip').length).toBeGreaterThan(0); }); // Switch to list view const viewToggle = screen.getByTitle(/list view/i); await user.click(viewToggle); - // Both trips should still be visible in list view + // Non-spotlight trips should be visible in list view await waitFor(() => { - expect(screen.getAllByText('Paris Adventure').length).toBeGreaterThan(0); expect(screen.getAllByText('Tokyo Trip').length).toBeGreaterThan(0); }); - // In list view, clicking Tokyo Trip card should work const tokyoTrip = screen.getAllByText('Tokyo Trip')[0]; await user.click(tokyoTrip); expect(tokyoTrip).toBeInTheDocument(); @@ -365,16 +363,15 @@ describe('DashboardPage', () => { render(); await waitFor(() => { - expect(screen.getAllByText('Paris Adventure').length).toBeGreaterThan(0); + expect(screen.getAllByText('Tokyo Trip').length).toBeGreaterThan(0); }); // Switch to list view const viewToggle = screen.getByTitle(/list view/i); await user.click(viewToggle); - // Both trips render in list view + // Non-spotlight trips render in list view await waitFor(() => { - expect(screen.getAllByText('Paris Adventure').length).toBeGreaterThan(0); expect(screen.getAllByText('Tokyo Trip').length).toBeGreaterThan(0); }); @@ -520,7 +517,7 @@ describe('DashboardPage', () => { if (submitBtn) { await user.click(submitBtn); await waitFor(() => { - expect(screen.getByText('New Trip Test')).toBeInTheDocument(); + expect(screen.getAllByText('New Trip Test').length).toBeGreaterThan(0); }); } });