k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-18 21:16:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(budget): let a recorded payment be edited from mobile Costs too

Browse Source 
Editing/undoing a settle-up payment was desktop-only — the mobile ledger
row rendered it read-only, with a comment explaining the gap was
deliberate for now. Give it the same edit/undo affordance the expense row
already has: edit reopens AddPaymentSheet pre-filled (now doubling as an
edit form, same as desktop's SettlementModal), undo deletes it outright
with no confirmation, mirroring CostsPanel.tsx's undoSettlement.
This commit is contained in:
RemEx
2026-09-12 06:59:24 +00:00
committed by Maurice
parent bef11c5222
commit 3dd6674d3f
2 changed files with 96 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/tests/unit/mobile/trip/MCostsTab.test.tsx
+29
View File
@@ -597,4 +597,33 @@ describe('MCostsTab', () => {
fireEvent.change(screen.getByLabelText('costs.searchPlaceholder'), { target: { value: 'ramen' } })
expect(screen.queryByText('costs.payment')).not.toBeInTheDocument()
})
it('FE-MOB-COSTT-041: editing a recorded payment opens it pre-filled and saves the change', async () => {
const payment = { id: 501, from_user_id: 1, to_user_id: 2, amount: 25, currency: 'USD', settled_at: '2026-04-28', created_at: '2026-04-30T09:00:00Z' }
serveSettlement({ ...SETTLEMENT, settlements: [payment] })
const update = vi.spyOn(budgetApi, 'updateSettlement').mockResolvedValue({})
await renderTab()
fireEvent.click(within(rowOf('costs.payment')).getByRole('button', { name: 'common.edit' }))
const dialog = screen.getByRole('dialog', { name: 'costs.editPayment' })
expect(within(dialog).getByDisplayValue('25.00')).toBeInTheDocument()
const submit = within(dialog).getByRole('button', { name: 'common.save' })
fireEvent.change(within(dialog).getByPlaceholderText('0.00'), { target: { value: '30' } })
fireEvent.click(submit)
expect(update).toHaveBeenCalledWith(7, 501, { from_user_id: 1, to_user_id: 2, amount: 30, currency: 'USD', settled_at: '2026-04-28' })
await waitFor(() => expect(settlementBases).toHaveLength(2))
})
it('FE-MOB-COSTT-042: undoing a payment deletes it outright, no confirmation', async () => {
const payment = { id: 502, from_user_id: 1, to_user_id: 2, amount: 25, currency: 'USD', created_at: '2026-04-30T09:00:00Z' }
serveSettlement({ ...SETTLEMENT, settlements: [payment] })
const del = vi.spyOn(budgetApi, 'deleteSettlement').mockResolvedValue({ success: true })
await renderTab()
fireEvent.click(within(rowOf('costs.payment')).getByRole('button', { name: 'costs.undo' }))
expect(del).toHaveBeenCalledWith(7, 502)
await waitFor(() => expect(settlementBases).toHaveLength(2))
})
})