From 3466556849fc6ec984654a2252463b9ef5504e13 Mon Sep 17 00:00:00 2001 From: Maurice Date: Fri, 6 Nov 2026 18:53:30 +0100 Subject: [PATCH] test(e2e): swipe the day pager past its middle, as a native pager needs The days are a scroll-snap pager since the native UX round: a page turns once the finger has carried it past half its width. The spec swiped 180 px on a 412 px phone and read the chip right after; it now swipes 40 % either side of the middle and polls the chip until the snap and the selection have landed. --- client/e2e/mobile-day-swipe-2051.spec.ts | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/client/e2e/mobile-day-swipe-2051.spec.ts b/client/e2e/mobile-day-swipe-2051.spec.ts index 9d3999c4b..6907ffb68 100644 --- a/client/e2e/mobile-day-swipe-2051.spec.ts +++ b/client/e2e/mobile-day-swipe-2051.spec.ts @@ -32,8 +32,8 @@ async function swipe(page: Page, from: { x: number; y: number }, to: { x: number } await cdp.send('Input.dispatchTouchEvent', { type: 'touchEnd', touchPoints: [] }) await cdp.detach() - // The out leg is 150ms and the in leg 220ms. - await page.waitForTimeout(500) + // The strip snaps natively; give the snap and the selection that follows it time to land. + await page.waitForTimeout(900) } const activeChip = (page: Page) => page.locator('button[aria-current="true"]') @@ -72,19 +72,23 @@ test('#2051 phone: the day details area swipes between days', async ({ page }) = const day1 = (await activeChip(page).textContent())!.trim() + // The days are a scroll-snap pager: like a native pager it turns once the + // finger has carried the page past its middle, so the swipe covers most of it. + const reach = Math.round(env.width * 0.4) + const chipText = async () => (await activeChip(page).textContent())!.trim() + // 1. A swipe left steps forward. - await swipe(page, { x: mid + 90, y }, { x: mid - 90, y }) - const day2 = (await activeChip(page).textContent())!.trim() - expect(day2, 'swiping left moved to the next day').not.toBe(day1) + await swipe(page, { x: mid + reach, y }, { x: mid - reach, y }) + await expect.poll(chipText, { message: 'swiping left moved to the next day' }).not.toBe(day1) // 2. A swipe right steps back to where it started. - await swipe(page, { x: mid - 90, y }, { x: mid + 90, y }) - expect((await activeChip(page).textContent())!.trim()).toBe(day1) + await swipe(page, { x: mid - reach, y }, { x: mid + reach, y }) + await expect.poll(chipText).toBe(day1) // 3. The first day has nowhere to go back to — it must stay put, and the // browser must not have been handed a page-back either. - await swipe(page, { x: mid - 90, y }, { x: mid + 90, y }) - expect((await activeChip(page).textContent())!.trim()).toBe(day1) + await swipe(page, { x: mid - reach, y }, { x: mid + reach, y }) + expect(await chipText()).toBe(day1) expect(page.url()).toContain(`/trips/${tripId}`) // 4. A vertical drag belongs to the card's own scroller, never to the day.