From 2ccdba78d6b33f1cc51ecf11ccd9aa795692df6f Mon Sep 17 00:00:00 2001 From: Maurice Date: Fri, 9 Oct 2026 11:51:13 +0200 Subject: [PATCH] chore(client): lower the ratchet baselines after sharing the feature hooks The size, layers, format and eslint baselines only go down: files that shrank, moved or lost a copied warning leave or lower their entries. The offline baseline drops from 212 to 170 entries. 102 desktop and phone views no longer import src/api/ and leave the list. 60 shared hooks take their place, because the calls those views made moved into the one hook both of them now import. Each of the 60 is imported only by views that were on the list before, and every api module it imports was imported by those views before. No call is new, and none moved behind the repo or the mutation queue, so the offline behaviour is the same as before. --- client/scripts/eslint-baseline.json | 18 +-- client/scripts/format-baseline.json | 9 -- client/scripts/layers-baseline.json | 5 +- client/scripts/offline-baseline.json | 162 ++++++++++----------------- client/scripts/size-baseline.json | 22 ++-- 5 files changed, 78 insertions(+), 138 deletions(-) diff --git a/client/scripts/eslint-baseline.json b/client/scripts/eslint-baseline.json index cce006b01..3f80499fa 100644 --- a/client/scripts/eslint-baseline.json +++ b/client/scripts/eslint-baseline.json @@ -1,19 +1,19 @@ { "src": { - "@typescript-eslint/no-explicit-any": 174, - "@typescript-eslint/no-unused-expressions": 4, - "@typescript-eslint/no-unused-vars": 194, - "no-empty": 34, + "@typescript-eslint/no-explicit-any": 155, + "@typescript-eslint/no-unused-expressions": 2, + "@typescript-eslint/no-unused-vars": 184, + "no-empty": 19, "no-useless-assignment": 7, "no-useless-escape": 1, "preserve-caught-error": 53, - "react-hooks/exhaustive-deps": 144, - "react-refresh/only-export-components": 48, - "unused-disable-directive": 7 + "react-hooks/exhaustive-deps": 124, + "react-refresh/only-export-components": 47, + "unused-disable-directive": 6 }, "suppressed": { - "@typescript-eslint/no-explicit-any": 50, - "react-hooks/exhaustive-deps": 64 + "@typescript-eslint/no-explicit-any": 44, + "react-hooks/exhaustive-deps": 47 }, "tests": { "@typescript-eslint/no-explicit-any": 492, diff --git a/client/scripts/format-baseline.json b/client/scripts/format-baseline.json index cc96c881a..fd5a2e5b1 100644 --- a/client/scripts/format-baseline.json +++ b/client/scripts/format-baseline.json @@ -1040,8 +1040,6 @@ "src/components/Todo/TodoRow.test.tsx", "src/components/Todo/TodoRow.tsx", "src/components/Todo/TodoTaskFields.tsx", - "src/components/Todo/todoListModel.test.ts", - "src/components/Todo/todoListModel.ts", "src/components/Todo/useTodoList.ts", "src/components/Tours/PlacesToursModeSwitch.tsx", "src/components/Tours/TourDetailDialog.test.tsx", @@ -1390,10 +1388,7 @@ "src/mobile/screens/trip/MTripShell.tsx", "src/mobile/screens/trip/dockTabs.test.ts", "src/mobile/screens/trip/dockTabs.ts", - "src/mobile/screens/trip/lib/collectionTarget.ts", "src/mobile/screens/trip/lib/dayNotes.ts", - "src/mobile/screens/trip/lib/dayRoute.test.ts", - "src/mobile/screens/trip/lib/dayRoute.ts", "src/mobile/screens/trip/map/MMapArea.tsx", "src/mobile/screens/trip/map/MPlacesFilterPill.tsx", "src/mobile/screens/trip/places/MPlacesBrowser.tsx", @@ -1457,7 +1452,6 @@ "src/mobile/screens/trip/sheets/PlPlaceSearch.tsx", "src/mobile/screens/trip/sheets/PlSheetChrome.tsx", "src/mobile/screens/trip/sheets/PlTimeFields.tsx", - "src/mobile/screens/trip/sheets/uploadBookingFiles.ts", "src/mobile/screens/trip/tabs/MBagsSheet.tsx", "src/mobile/screens/trip/tabs/MBookingsTab.tsx", "src/mobile/screens/trip/tabs/MCollabChat.tsx", @@ -1481,9 +1475,6 @@ "src/mobile/screens/trip/tabs/MTodoListTab.tsx", "src/mobile/screens/trip/tabs/MTransportsTab.tsx", "src/mobile/screens/trip/tabs/MTripTabPanel.tsx", - "src/mobile/screens/trip/tabs/bookingsModel.ts", - "src/mobile/screens/trip/tabs/collabModel.ts", - "src/mobile/screens/trip/tabs/costsModel.ts", "src/mobile/screens/trip/tabs/filesModel.ts", "src/mobile/screens/trip/tabs/listsModel.ts", "src/mobile/screens/trip/tabs/tabChrome.tsx", diff --git a/client/scripts/layers-baseline.json b/client/scripts/layers-baseline.json index 565fe4aee..815ce6cff 100644 --- a/client/scripts/layers-baseline.json +++ b/client/scripts/layers-baseline.json @@ -20,7 +20,7 @@ "src/components/Journey/JourneyDetailPageAddTripDialog.tsx": 1, "src/components/Journey/JourneyDetailPageChips.tsx": 1, "src/components/Journey/JourneyDetailPageEntryCard.tsx": 2, - "src/components/Journey/JourneyDetailPageEntryEditor.tsx": 3, + "src/components/Journey/JourneyDetailPageEntryEditor.tsx": 2, "src/components/Journey/JourneyDetailPageGalleryView.tsx": 1, "src/components/Journey/JourneyDetailPageMapView.tsx": 1, "src/components/Journey/JourneyDetailPagePhotoGrid.tsx": 1, @@ -30,13 +30,10 @@ "src/components/Journey/MobileEntryView.tsx": 1, "src/components/Map/MapView.tsx": 1, "src/components/Map/MapViewGL.tsx": 1, - "src/components/Packing/packingPrintDocument.ts": 1, - "src/components/Packing/usePackingExport.ts": 1, "src/components/Planner/IcsSubscribeModal.tsx": 1, "src/components/Planner/TransitJourneyModal.tsx": 1, "src/components/Planner/TransitSearchPanel.tsx": 1, "src/components/Planner/TripWarningsBanner.tsx": 1, - "src/components/Planner/bookings/bookingsModel.ts": 2, "src/components/Planner/transitDisplay.tsx": 1, "src/components/Plugins/PluginFrame.tsx": 1, "src/components/Roadtrip/RoadtripSidebarDriveBands.tsx": 1, diff --git a/client/scripts/offline-baseline.json b/client/scripts/offline-baseline.json index 41dd224bd..fd63fab1d 100644 --- a/client/scripts/offline-baseline.json +++ b/client/scripts/offline-baseline.json @@ -1,61 +1,70 @@ [ - "src/components/Admin/AddonManager.tsx", - "src/components/Admin/AdminMcpTokensPanel.tsx", - "src/components/Admin/AdminPluginsPanel.tsx", - "src/components/Admin/AuditLogPanel.tsx", - "src/components/Admin/BackupPanel.tsx", - "src/components/Admin/CategoryManager.tsx", - "src/components/Admin/DefaultUserSettingsTab.tsx", - "src/components/Admin/DevNotificationsPanel.tsx", - "src/components/Admin/GitHubPanel.tsx", - "src/components/Admin/PackingTemplateManager.tsx", - "src/components/Admin/PermissionsPanel.tsx", + "src/components/Admin/addons/useAddonManager.ts", + "src/components/Admin/addons/useLlmParsingConfig.ts", + "src/components/Admin/plugins/usePluginDetail.ts", + "src/components/Admin/plugins/usePluginsAdmin.ts", "src/components/Admin/storage/useStorageAdmin.ts", + "src/components/Admin/useAdminNotificationMatrix.ts", + "src/components/Admin/useAdminNotificationSettings.ts", + "src/components/Admin/useAdminSettingsActions.ts", + "src/components/Admin/useAdminUserActions.ts", + "src/components/Admin/useAuditLog.ts", + "src/components/Admin/useBackupAdmin.ts", + "src/components/Admin/useCategoryAdmin.ts", + "src/components/Admin/useDefaultUserSettings.ts", + "src/components/Admin/useDevNotifications.ts", + "src/components/Admin/useGithubReleases.ts", "src/components/Admin/useGoogleQuota.ts", "src/components/Admin/useInstanceSettings.ts", + "src/components/Admin/useMcpTokensAdmin.ts", "src/components/Admin/useNotificationChannels.ts", + "src/components/Admin/usePackingTemplateAdmin.ts", + "src/components/Admin/usePermissionsAdmin.ts", "src/components/BackgroundTasks/BackgroundTasksWidget.tsx", "src/components/Budget/BudgetPanelPerPersonInline.tsx", - "src/components/Budget/CostsPanel.tsx", "src/components/Budget/ReceiptPreviewModal.tsx", "src/components/Budget/receiptUploads.ts", "src/components/Budget/useBudgetPanel.ts", + "src/components/Budget/useCostsLedger.ts", + "src/components/Budget/useSettlementForm.ts", "src/components/Collab/CollabChatLinkPreview.tsx", "src/components/Collab/CollabLinks.tsx", "src/components/Collab/CollabNotes.tsx", "src/components/Collab/CollabNotesAuthedImg.tsx", "src/components/Collab/CollabNotesFilePreviewPortal.tsx", "src/components/Collab/CollabNotesWebsiteThumbnail.tsx", - "src/components/Collab/CollabPolls.tsx", - "src/components/Collab/useCollabChat.ts", - "src/components/Collections/AddPlaceToCollectionModal.tsx", + "src/components/Collab/useCollabChatData.ts", + "src/components/Collab/useCollabNotesData.ts", + "src/components/Collab/useCollabPolls.ts", "src/components/Collections/CollectionPicker.tsx", - "src/components/Collections/CollectionPlaceDetail.tsx", - "src/components/Collections/CopyToTripModal.tsx", "src/components/Collections/ImportFromTripModal.tsx", - "src/components/Collections/ListEditorModal.tsx", - "src/components/Collections/MSaveToCollectionSheet.tsx", - "src/components/Collections/SaveToCollectionModal.tsx", - "src/components/Collections/SaveTripPlacesToListModal.tsx", - "src/components/Collections/ShareCollectionModal.tsx", - "src/components/Dashboard/CollectionsWidget.tsx", + "src/components/Collections/useAddPlaceToCollection.ts", + "src/components/Collections/useCollectionPlaceForm.ts", + "src/components/Collections/useCollectionSharing.ts", + "src/components/Collections/useListEditor.ts", + "src/components/Collections/useSaveToCollection.ts", + "src/components/Collections/useSaveTripPlacesToList.ts", + "src/components/Collections/useTripCopyPicker.ts", + "src/components/Dashboard/useCollectionLists.ts", "src/components/Dawarich/DawarichAtlasDialog.tsx", - "src/components/Files/FileManagerAssignModal.tsx", "src/components/Files/FileManagerAuthedImg.tsx", "src/components/Files/FileManagerImageLightbox.tsx", "src/components/Files/docsync/useConflicts.ts", "src/components/Files/docsync/useDocSync.ts", + "src/components/Files/fileActions.ts", "src/components/Files/useFileManager.ts", + "src/components/Files/useFileTrash.ts", + "src/components/Files/useMediaLightbox.ts", "src/components/Journey/ContributorInviteDialog.tsx", - "src/components/Journey/JourneyDetailPageAddTripDialog.tsx", "src/components/Journey/JourneyDetailPageEntryCard.tsx", "src/components/Journey/JourneyDetailPageEntryEditor.tsx", "src/components/Journey/JourneyDetailPageGalleryView.tsx", "src/components/Journey/JourneyDetailPageProviderPicker.tsx", - "src/components/Journey/JourneyDetailPageSettingsDialog.tsx", - "src/components/Journey/JourneyShareSection.tsx", "src/components/Journey/useConnectedPhotoProviders.ts", "src/components/Journey/useEntryPhotoOrder.ts", + "src/components/Journey/useJourneyEntryForm.ts", + "src/components/Journey/useJourneySettings.ts", + "src/components/Journey/useJourneyShareLink.ts", "src/components/Journey/useJourneyTripSuggestion.ts", "src/components/Map/MapPluginLayers.tsx", "src/components/Map/MapPluginMarkers.tsx", @@ -64,52 +73,59 @@ "src/components/Map/RouteCalculator.ts", "src/components/Map/routeUsageCounter.ts", "src/components/Map/usePoiExplore.ts", - "src/components/OAuth/ScopeGroupPicker.tsx", + "src/components/OAuth/useScopeSelection.ts", "src/components/PDF/TripPDF.tsx", "src/components/Packing/ApplyTemplateButton.tsx", + "src/components/Packing/usePackingBags.ts", + "src/components/Packing/usePackingCategoryAssignees.ts", "src/components/Packing/usePackingExport.ts", + "src/components/Packing/usePackingImport.ts", "src/components/Packing/usePackingListPanel.ts", + "src/components/Packing/usePackingTemplates.ts", "src/components/Planner/AddressInput.tsx", "src/components/Planner/AirTrailImportModal.tsx", "src/components/Planner/AirportSelect.tsx", "src/components/Planner/BookingImportModal.tsx", "src/components/Planner/DayPlanSidebar.tsx", - "src/components/Planner/FileImportModal.tsx", "src/components/Planner/LocationSelect.tsx", "src/components/Planner/PlaceDetailsColumn.tsx", - "src/components/Planner/PlaceFormModal.tsx", "src/components/Planner/PlaceInspector.tsx", "src/components/Planner/TransitSearchPanel.tsx", "src/components/Planner/TripWarningsBanner.tsx", "src/components/Planner/useDayDetail.ts", - "src/components/Planner/usePlacesSidebar.ts", + "src/components/Planner/useLegModeActions.ts", + "src/components/Planner/useListImport.ts", + "src/components/Planner/usePlaceActions.ts", + "src/components/Planner/usePlaceSearch.ts", + "src/components/Planner/usePlacesFileImport.ts", + "src/components/Planner/usePlacesPool.ts", "src/components/Plugins/PluginContributions.tsx", "src/components/Plugins/PluginDaySchedule.tsx", "src/components/Plugins/PluginFrame.tsx", "src/components/Plugins/TripCardBadges.tsx", + "src/components/Plugins/usePluginUserSettings.ts", "src/components/Roadtrip/useDayBoundaries.ts", "src/components/Roadtrip/useRefuelSearch.ts", "src/components/Roadtrip/useRoadtripVias.ts", - "src/components/Settings/AccountTab.tsx", - "src/components/Settings/AirTrailConnectionSection.tsx", "src/components/Settings/ApiKeysSection.tsx", - "src/components/Settings/IntegrationsTab.tsx", - "src/components/Settings/NotificationsTab.tsx", - "src/components/Settings/PasskeysSection.tsx", - "src/components/Settings/PhotoProvidersSection.tsx", - "src/components/Settings/PluginActivityPanel.tsx", - "src/components/Settings/PluginSettingsTab.tsx", + "src/components/Settings/useAccountSettings.ts", + "src/components/Settings/useAirTrailSettings.ts", + "src/components/Settings/useMcpIntegration.ts", + "src/components/Settings/useNotificationSettings.ts", "src/components/Settings/useOfflineSettings.ts", + "src/components/Settings/usePasskeys.ts", + "src/components/Settings/usePhotoProviderConnections.ts", + "src/components/Settings/usePluginActivity.ts", "src/components/Studio/useBookPresence.ts", "src/components/Studio/useBookStore.ts", "src/components/Todo/useTodoList.ts", "src/components/Trips/TripFormModal.tsx", + "src/components/Trips/useTripCoverPicker.ts", "src/components/Trips/useTripShare.ts", - "src/components/Vacay/VacayCalendar.tsx", - "src/components/Vacay/VacayPersons.tsx", - "src/components/Vacay/VacaySettings.tsx", - "src/components/Vacay/VacaySharedCalendars.tsx", "src/components/Vacay/holidayRegions.ts", + "src/components/Vacay/useVacayCalendarLogic.ts", + "src/components/Vacay/useVacaySettings.ts", + "src/components/Vacay/useVacayUserPicker.ts", "src/components/shared/PlaceAvatarUpload.tsx", "src/hooks/useAirtrailConnection.ts", "src/hooks/useDawarichConnection.ts", @@ -119,76 +135,18 @@ "src/hooks/useRoadtripPreferencesSync.ts", "src/hooks/useTripWebSocket.ts", "src/hooks/useWebPush.ts", - "src/mobile/screens/admin/MAdmin.tsx", - "src/mobile/screens/admin/MAdminAddonManager.tsx", - "src/mobile/screens/admin/MAdminAuditLogPanel.tsx", - "src/mobile/screens/admin/MAdminBackupPanel.tsx", - "src/mobile/screens/admin/MAdminCategoryManager.tsx", - "src/mobile/screens/admin/MAdminDefaultUserSettings.tsx", - "src/mobile/screens/admin/MAdminDevNotificationsPanel.tsx", - "src/mobile/screens/admin/MAdminGitHubPanel.tsx", - "src/mobile/screens/admin/MAdminMcpTokensPanel.tsx", - "src/mobile/screens/admin/MAdminNotificationsSection.tsx", - "src/mobile/screens/admin/MAdminNotifyMatrix.tsx", - "src/mobile/screens/admin/MAdminPackingTemplateManager.tsx", - "src/mobile/screens/admin/MAdminPermissionsPanel.tsx", - "src/mobile/screens/admin/MAdminPluginsPanel.tsx", - "src/mobile/screens/admin/MAdminSettingsSection.tsx", - "src/mobile/screens/admin/MAdminSheets.tsx", - "src/mobile/screens/atlas/MAtlasCountryPopup.tsx", - "src/mobile/screens/collections/MCollAddSheet.tsx", - "src/mobile/screens/collections/MCollEditSheet.tsx", - "src/mobile/screens/collections/MCollPlaceSheet.tsx", - "src/mobile/screens/collections/MCollShareSheet.tsx", - "src/mobile/screens/collections/MCollTripPickerSheet.tsx", - "src/mobile/screens/dashboard/MDashWidgets.tsx", - "src/mobile/screens/dashboard/MNewTripSheet.tsx", "src/mobile/screens/journey/MJourneyDetail.tsx", - "src/mobile/screens/journey/MJourneyEntrySheet.tsx", - "src/mobile/screens/journey/MJourneySettingsSheet.tsx", - "src/mobile/screens/settings/MAirTrailConnectionSection.tsx", - "src/mobile/screens/settings/MPhotoProvidersSection.tsx", - "src/mobile/screens/settings/MScopeGroupPicker.tsx", - "src/mobile/screens/settings/MSettingsAccount.tsx", - "src/mobile/screens/settings/MSettingsMcp.tsx", - "src/mobile/screens/settings/MSettingsNotifications.tsx", - "src/mobile/screens/settings/MSettingsPlugins.tsx", - "src/mobile/screens/trip/places/MPlacesBrowser.tsx", - "src/mobile/screens/trip/places/MPlacesSaveToCollectionSheet.tsx", "src/mobile/screens/trip/plan/useMPlanTimeline.ts", - "src/mobile/screens/trip/sheets/ImpFileStep.tsx", - "src/mobile/screens/trip/sheets/ImpListStep.tsx", - "src/mobile/screens/trip/sheets/MAccommodationSheet.tsx", - "src/mobile/screens/trip/sheets/MDaySheet.tsx", - "src/mobile/screens/trip/sheets/MPlaceSheet.tsx", - "src/mobile/screens/trip/sheets/PlPlaceSearch.tsx", - "src/mobile/screens/trip/tabs/MCollabChat.tsx", "src/mobile/screens/trip/tabs/MCollabNotes.tsx", - "src/mobile/screens/trip/tabs/MCollabPolls.tsx", - "src/mobile/screens/trip/tabs/MCostsTab.tsx", - "src/mobile/screens/trip/tabs/MFileLightbox.tsx", - "src/mobile/screens/trip/tabs/MFileLinkSheet.tsx", - "src/mobile/screens/trip/tabs/MFileMenuSheet.tsx", - "src/mobile/screens/trip/tabs/MFileTrashSheet.tsx", "src/mobile/screens/trip/tabs/MFilesTab.tsx", - "src/mobile/screens/trip/tabs/MPackingImportSheet.tsx", - "src/mobile/screens/trip/tabs/MPackingListTab.tsx", - "src/mobile/screens/vacay/MVacayInviteSheet.tsx", - "src/mobile/screens/vacay/MVacaySettingsSheet.tsx", - "src/mobile/screens/vacay/MVacayShareSheet.tsx", - "src/mobile/screens/vacay/useMVacay.ts", - "src/pages/AdminPage.tsx", - "src/pages/AtlasPage.tsx", "src/pages/JourneyDetailPage.tsx", "src/pages/OAuthAuthorizePage.tsx", "src/pages/TripPlannerPage.tsx", - "src/pages/admin/AdminNotificationsPanel.tsx", - "src/pages/admin/AdminNotificationsTab.tsx", "src/pages/admin/AdminSettingsTab.tsx", - "src/pages/admin/AdminUserModals.tsx", "src/pages/admin/useAdmin.ts", "src/pages/admin/useNotificationDefaults.ts", "src/pages/atlas/useAtlas.ts", + "src/pages/atlas/useAtlasCountryActions.ts", "src/pages/collections/useCollections.ts", "src/pages/dashboard/useDashboard.ts", "src/pages/dashboard/useTripSearch.ts", diff --git a/client/scripts/size-baseline.json b/client/scripts/size-baseline.json index e62581dfe..7ec3948ff 100644 --- a/client/scripts/size-baseline.json +++ b/client/scripts/size-baseline.json @@ -2,10 +2,9 @@ "e2e/help/fixtures.ts": 2291, "src/api/client.ts": 1916, "src/components/Admin/AdminPluginsPanel.test.tsx": 2704, - "src/components/Admin/AdminPluginsPanel.tsx": 2433, + "src/components/Admin/AdminPluginsPanel.tsx": 1667, "src/components/Budget/CostsPanel.test.tsx": 2854, - "src/components/Budget/CostsPanel.tsx": 2366, - "src/components/Journey/JourneyDetailPageEntryEditor.tsx": 1014, + "src/components/Budget/CostsPanel.tsx": 1854, "src/components/Map/MapView.tsx": 1526, "src/components/Map/MapViewGL.test.tsx": 2920, "src/components/Map/MapViewGL.tsx": 2607, @@ -13,26 +12,21 @@ "src/components/PDF/TripPDF.tsx": 1097, "src/components/Planner/DayDetailPanel.test.tsx": 2333, "src/components/Planner/DayPlanSidebar.test.tsx": 5403, - "src/components/Planner/DayPlanSidebar.tsx": 3312, + "src/components/Planner/DayPlanSidebar.tsx": 3214, "src/components/Planner/PlaceFormModal.test.tsx": 2864, - "src/components/Planner/PlaceFormModal.tsx": 1669, - "src/components/Planner/PlaceInspector.tsx": 1357, - "src/components/Planner/TransportModal.tsx": 1254, + "src/components/Planner/PlaceFormModal.tsx": 1250, + "src/components/Planner/PlaceInspector.tsx": 1308, "src/components/Studio/TravelElements.tsx": 1747, "src/components/Studio/autoLayout.ts": 1691, "src/components/Studio/bookTemplates.data.ts": 1309, "src/components/Studio/countryShapes.ts": 2595, "src/index.css": 1636, - "src/mobile/screens/admin/MAdminPluginsPanel.tsx": 2264, - "src/mobile/screens/journey/MJourneyEntrySheet.tsx": 1122, - "src/mobile/screens/trip/sheets/MTransportFormSheet.tsx": 1194, - "src/mobile/screens/trip/tabs/MCostsTab.tsx": 1095, - "src/mobile/screens/trip/tabs/MPackingListTab.tsx": 1080, + "src/mobile/screens/admin/MAdminPluginsPanel.tsx": 1507, "src/pages/JourneyDetailPage.test.tsx": 4030, "src/pages/LoginPage.tsx": 1348, - "src/pages/TripPlannerPage.tsx": 1259, + "src/pages/TripPlannerPage.tsx": 1213, "src/pages/TripPlannerPage.wiring.test.tsx": 2049, - "src/pages/atlas/useAtlas.ts": 1288, + "src/pages/atlas/useAtlas.ts": 1287, "src/pages/tripPlanner/useTripPlanner.roadtrip.test.tsx": 3531, "src/pages/tripPlanner/useTripPlanner.test.tsx": 3309, "src/styles/studio.css": 2087