k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-22 23:16:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(plugins): search plugins can answer the place search as you type

Browse Source 
A searchProvider plugin can now implement an optional suggest() beside
search(). Its places then show up in the place search's typed-ahead list,
after the core suggestions and marked with the plugin's name, on desktop
and phone. An index that cannot take a request per keystroke leaves it
out and keeps answering the full search only.

The child reports which functions each hook object carries at load, so
GET /api/plugin-search/suggest only asks the plugins that implement
suggest: from the second character, three rows at most across all of
them, 800 ms to answer. The feed marks plugins holding
hook:search-provider and the client only asks the route while one is
installed. A plugin row carries its whole place, so picking it skips the
details lookup, which knows no plugin id. The phone's search results now
name their source as the desktop ones do, and the desktop dropdown
scrolls instead of running past the dialog.

Addresses discussion #2221.
This commit is contained in:
Maurice
2026-09-25 09:19:11 +02:00
parent 1727732841
commit 2a8071f642
38 changed files with 1248 additions and 96 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/tests/unit/plugins/plugins-feed.controller.test.ts
+12
View File
@@ -29,6 +29,18 @@ describe('PluginsFeedController', () => {
const c = new PluginsFeedController(new DatabaseService(dbConn));
beforeEach(() => { pluginsEnabled.mockReturnValue(true); rows.value = []; });
it('marks a plugin as a search provider only alongside the recorded hook:search-provider grant (#2221)', () => {
rows.value = [
row({ id: 'index', granted_permissions: JSON.stringify(['hook:search-provider']) }),
row({ id: 'asked-only', permissions: JSON.stringify(['hook:search-provider']) }),
row({ id: 'poi-only', granted_permissions: JSON.stringify(['hook:poi-category-provider']) }),
];
const { plugins } = c.list();
expect(plugins.find(p => p.id === 'index')?.searchProvider).toBe(true);
expect(plugins.find(p => p.id === 'asked-only')).not.toHaveProperty('searchProvider');
expect(plugins.find(p => p.id === 'poi-only')).not.toHaveProperty('searchProvider');
});
it('returns an empty feed when the runtime is disabled', () => {
pluginsEnabled.mockReturnValue(false);
rows.value = [row()];