From 1e166ab0d996b585f64222fa780b4145e9d71480 Mon Sep 17 00:00:00 2001 From: Maurice Date: Mon, 17 Aug 2026 14:33:56 +0200 Subject: [PATCH] test(server): raise the coverage floor for the four domains this branch covered Measured values with a point of slack, from scripts/coverage-thresholds.mjs: atlas, audit, settings and unsplash all gained cases here. Only those four. The script prints a block for every domain, and taking it whole would have lowered src/nest/auth lines from 96 to 95 and tightened domains this branch never touched, which would fail the open PRs for no reason. unsplash is the one that needed the work rather than just recording it: dropping the "any admin's key" fallback removed covered branches, so the parse-failure ternary that was already uncovered started dominating the ratio and the gate failed at 80.85% against a floor of 82%. Covered it instead of lowering the floor, which put branches at 89.36%. --- server/vitest.config.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/vitest.config.ts b/server/vitest.config.ts index 64d80aa49..5cecf247c 100644 --- a/server/vitest.config.ts +++ b/server/vitest.config.ts @@ -67,8 +67,8 @@ export default defineConfig({ 'src/nest/airports/**/*.ts': { statements: 68, branches: 60, functions: 93, lines: 73 }, 'src/nest/app-config/**/*.ts': { statements: 79, branches: 100, functions: 65, lines: 71 }, 'src/nest/assignments/**/*.ts': { statements: 90, branches: 80, functions: 97, lines: 96 }, - 'src/nest/atlas/**/*.ts': { statements: 91, branches: 78, functions: 96, lines: 93 }, - 'src/nest/audit/**/*.ts': { statements: 92, branches: 79, functions: 99, lines: 96 }, + 'src/nest/atlas/**/*.ts': { statements: 92, branches: 82, functions: 96, lines: 94 }, + 'src/nest/audit/**/*.ts': { statements: 93, branches: 80, functions: 99, lines: 96 }, 'src/nest/auth/**/*.ts': { statements: 93, branches: 85, functions: 95, lines: 96 }, 'src/nest/backup/**/*.ts': { statements: 96, branches: 92, functions: 99, lines: 98 }, 'src/nest/booking-import/**/*.ts': { statements: 50, branches: 28, functions: 64, lines: 53 }, @@ -110,7 +110,7 @@ export default defineConfig({ 'src/nest/realtime/**/*.ts': { statements: 99, branches: 100, functions: 99, lines: 99 }, 'src/nest/reservation-import/**/*.ts': { statements: 61, branches: 55, functions: 41, lines: 61 }, 'src/nest/reservations/**/*.ts': { statements: 92, branches: 83, functions: 96, lines: 96 }, - 'src/nest/settings/**/*.ts': { statements: 85, branches: 68, functions: 99, lines: 87 }, + 'src/nest/settings/**/*.ts': { statements: 87, branches: 71, functions: 99, lines: 88 }, 'src/nest/share/**/*.ts': { statements: 97, branches: 87, functions: 99, lines: 99 }, 'src/nest/system-notices/**/*.ts': { statements: 99, branches: 99, functions: 99, lines: 99 }, 'src/nest/tags/**/*.ts': { statements: 97, branches: 89, functions: 99, lines: 99 }, @@ -121,7 +121,7 @@ export default defineConfig({ 'src/nest/trip-members/**/*.ts': { statements: 95, branches: 91, functions: 99, lines: 95 }, 'src/nest/trip-read-model/**/*.ts': { statements: 97, branches: 96, functions: 99, lines: 97 }, 'src/nest/trips/**/*.ts': { statements: 92, branches: 82, functions: 91, lines: 94 }, - 'src/nest/unsplash/**/*.ts': { statements: 97, branches: 82, functions: 99, lines: 96 }, + 'src/nest/unsplash/**/*.ts': { statements: 99, branches: 88, functions: 99, lines: 99 }, 'src/nest/vacay/**/*.ts': { statements: 82, branches: 66, functions: 90, lines: 86 }, 'src/nest/weather/**/*.ts': { statements: 93, branches: 78, functions: 91, lines: 97 }, 'src/nest/**/*.ts': { statements: 80, branches: 80, functions: 80, lines: 80 },