k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-06-19 13:21:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(mcp): add error handling and logging to prevent silent crashes

Browse Source
This commit is contained in:
unknown
2026-04-06 15:21:55 +02:00
committed by jubnl
parent 39db61cc76
commit 1646caa66b
1 changed files with 24 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/mcp/index.ts
+24 -3
View File
@@ -52,17 +52,22 @@ function countSessionsForUser(userId: number): number {
const sessionSweepInterval = setInterval(() => { const sessionSweepInterval = setInterval(() => {
const cutoff = Date.now() - SESSION_TTL_MS; const cutoff = Date.now() - SESSION_TTL_MS;
let cleaned = 0;
for (const [sid, session] of sessions) { for (const [sid, session] of sessions) {
if (session.lastActivity < cutoff) { if (session.lastActivity < cutoff) {
try { session.server.close(); } catch { /* ignore */ } try { session.server.close(); } catch { /* ignore */ }
try { session.transport.close(); } catch { /* ignore */ } try { session.transport.close(); } catch { /* ignore */ }
sessions.delete(sid); sessions.delete(sid);
cleaned++;
} }
} }
const rateCutoff = Date.now() - RATE_LIMIT_WINDOW_MS; const rateCutoff = Date.now() - RATE_LIMIT_WINDOW_MS;
for (const [uid, entry] of rateLimitMap) { for (const [uid, entry] of rateLimitMap) {
if (entry.windowStart < rateCutoff) rateLimitMap.delete(uid); if (entry.windowStart < rateCutoff) rateLimitMap.delete(uid);
} }
if (cleaned > 0 || sessions.size > 0) {
console.log(`[MCP] Session sweep: cleaned ${cleaned}, active ${sessions.size}`);
}
}, 10 * 60 * 1000); // sweep every 10 minutes }, 10 * 60 * 1000); // sweep every 10 minutes
// Prevent the interval from keeping the process alive if nothing else is running // Prevent the interval from keeping the process alive if nothing else is running
@@ -112,7 +117,14 @@ export async function mcpHandler(req: Request, res: Response): Promise<void> {
return; return;
} }
session.lastActivity = Date.now(); session.lastActivity = Date.now();
await session.transport.handleRequest(req, res, req.body); try {
await session.transport.handleRequest(req, res, req.body);
} catch (err) {
console.error('[MCP] transport.handleRequest error:', err);
if (!res.headersSent) {
res.status(500).json({ error: 'Internal MCP error', detail: String(err) });
}
}
return; return;
} }
@@ -142,16 +154,25 @@ export async function mcpHandler(req: Request, res: Response): Promise<void> {
const transport = new StreamableHTTPServerTransport({ const transport = new StreamableHTTPServerTransport({
sessionIdGenerator: () => randomUUID(), sessionIdGenerator: () => randomUUID(),
allowedOrigins: ['*'],
onsessioninitialized: (sid) => { onsessioninitialized: (sid) => {
sessions.set(sid, { server, transport, userId: user.id, lastActivity: Date.now() }); sessions.set(sid, { server, transport, userId: user.id, lastActivity: Date.now() });
console.log(`[MCP] Session ${sid} created for user ${user.id}. Active sessions: ${sessions.size}`);
}, },
onsessionclosed: (sid) => { onsessionclosed: (sid) => {
sessions.delete(sid); sessions.delete(sid);
}, },
}); });
await server.connect(transport); try {
await transport.handleRequest(req, res, req.body); await server.connect(transport);
await transport.handleRequest(req, res, req.body);
} catch (err) {
console.error('[MCP] transport.handleRequest error:', err);
if (!res.headersSent) {
res.status(500).json({ error: 'Internal MCP error', detail: String(err) });
}
}
} }
/** Terminate all active MCP sessions for a specific user (e.g. on token revocation). */ /** Terminate all active MCP sessions for a specific user (e.g. on token revocation). */